search for: drm_err

...escp->pitch_align); - size = pitch * args->height; - size = ALIGN(size, PAGE_SIZE); + ret = drm_mode_size_dumb(ddev, args, descp->pitch_align, 0); + if (ret) + return ret; /* Maximum single bo size allowed is the half vram size available */ - if (size > ldev->vram_size / 2) { - drm_err(ddev, "Requesting(%zuMiB) failed\n", size >> 20); + if (args->size > ldev->vram_size / 2) { + drm_err(ddev, "Requesting(%zuMiB) failed\n", (size_t)(args->size >> PAGE_SHIFT)); return -ENOMEM; } - gobj = lsdc_gem_object_create(ddev, domain, size, f...

...er = drm_fb_helper_from_client(client); - struct drm_device *dev = client->dev; - struct radeon_device *rdev = dev->dev_private; - int ret; - - if (dev->fb_helper) - return drm_fb_helper_hotplug_event(dev->fb_helper); - - ret = drm_fb_helper_init(dev, fb_helper); - if (ret) - goto err_drm_err; - - if (!drm_drv_uses_atomic_modeset(dev)) - drm_helper_disable_unused_functions(dev); - - ret = drm_fb_helper_initial_config(fb_helper); - if (ret) - goto err_drm_fb_helper_fini; - - vga_switcheroo_client_fb_set(rdev->pdev, fb_helper->info); - - return 0; - -err_drm_fb_helper_fini: - drm_...

...ent mode and the disable->enable non-transparent mode > > + * sequence. > > + */ > > + drm_dp_lttpr_set_transparent_mode(aux, true); > > Error handling? Yes, this makes sense. But other than throwing an error I don't think there is much to be done. I'll add an drm_err here just in case. > > > + > > + if (lttpr_count > 0 && !drm_dp_lttpr_set_transparent_mode(aux, false)) > > No need to check lttpr_count again here. So the logic behind lttpr_count and this transparency mode changing, as specified in the DP standard, is as follo...

...gt; - */ > - if (!(intel_dp->dpcd[DP_TRAINING_AUX_RD_INTERVAL] & > - DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT)) > - return; > - > - if (drm_dp_dpcd_read(&intel_dp->aux, DP_DP13_DPCD_REV, > - &dpcd_ext, sizeof(dpcd_ext)) != sizeof(dpcd_ext)) { > - drm_err(&i915->drm, > - "DPCD failed read at extended capabilities\n"); > - return; > - } > - > - if (intel_dp->dpcd[DP_DPCD_REV] > dpcd_ext[DP_DPCD_REV]) { > - drm_dbg_kms(&i915->drm, > - "DPCD extended DPCD rev less than base DPCD rev\n&qu...

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I've been trying to get nouveau working on a Geforce 6600LE in a dual-core G5 PowerMac system. For various reasons, it's not working. The first problem I encountered was the lack of virt_to_bus on 64-bit PPC. After talking to benh on IRC, I created the attached patch. nouveau.ko can at least load on PPC64 now. :) However, during X-server

...e non-transparent mode >> > + * sequence. >> > + */ >> > + drm_dp_lttpr_set_transparent_mode(aux, true); >> >> Error handling? > > Yes, this makes sense. But other than throwing an error I don't think > there is much to be done. I'll add an drm_err here just in case. > >> >> > + >> > + if (lttpr_count > 0 && !drm_dp_lttpr_set_transparent_mode(aux, false)) >> >> No need to check lttpr_count again here. > > So the logic behind lttpr_count and this transparency mode changing, as > spe...

...to - * then compare 0000h and 2200h. - */ - if (!(intel_dp->dpcd[DP_TRAINING_AUX_RD_INTERVAL] & - DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT)) - return; - - if (drm_dp_dpcd_read(&intel_dp->aux, DP_DP13_DPCD_REV, - &dpcd_ext, sizeof(dpcd_ext)) != sizeof(dpcd_ext)) { - drm_err(&i915->drm, - "DPCD failed read at extended capabilities\n"); - return; - } - - if (intel_dp->dpcd[DP_DPCD_REV] > dpcd_ext[DP_DPCD_REV]) { - drm_dbg_kms(&i915->drm, - "DPCD extended DPCD rev less than base DPCD rev\n"); - return; - } - - if (!memcm...

On Wed, Dec 11, 2024 at 03:04:12PM +0200, Abel Vesa wrote: > +/** > + * drm_dp_lttpr_set_transparent_mode - set the LTTPR in transparent mode > + * @aux: DisplayPort AUX channel > + * @enable: Enable or disable transparent mode > + * > + * Returns 0 on success or a negative error code on failure. > + */ > +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool

Dumb-buffer pitch and size is specified by width, height, bits-per-pixel plus various hardware-specific alignments. The calculation of these values is inconsistent and duplicated among drivers. The results for formats with bpp < 8 are incorrect. This series fixes this for most drivers. Default scanline pitch and buffer size are now calculated with the existing 4CC helpers. There is a new

...> + ?????? (struct ttm_device_init_flags){ > > > + ?????? .use_dma_alloc = adev- > > > > need_swiotlb, > > > + ?????? .use_dma32 = > > > dma_addressing_limited(adev->dev) > > > + ?????? }); > > > ?? if (r) { > > > ?? DRM_ERROR("failed initializing buffer object > > > driver(%d).\n", r); > > > ?? return r; > > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > > > b/drivers/gpu/drm/drm_gem_vram_helper.c > > > index 22b1fe9c03b8..7c3165b00378 100644 > > &g...

...> + ?????? }); I can't say I like declaring the ttm_device_init_flags as part of the function arguments. I'd prefer this a local variable but this just an opinion. Not blocker but if other agree with me, maybe change this. Matt > > > > ?? if (r) { > > > > ?? DRM_ERROR("failed initializing buffer object > > > > driver(%d).\n", r); > > > > ?? return r; > > > > diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c > > > > b/drivers/gpu/drm/drm_gem_vram_helper.c > > > > index 22b1fe9c03b8..7c3165b...

Some graphics APIs differentiate between out-of-graphics-memory and out-of-host-memory (system memory). Add a device init flag to have -ENOSPC propagated from the resource managers instead of being converted to -ENOMEM, to aid driver stacks in determining what error code to return or whether corrective action can be taken at the driver level. The first patch deals with a ttm_device_init()

To start off: this patch series is less work to review then it looks - most (but not all) of the nouveau related work has already been reviewed elsewhere. Most of the reason I'm asking for an RFC here is because this code pulls a lot of code out of i915 and into shared DP helpers. Anyway-nouveau's HPD related code has been collecting dust for a while. Other then the occasional runtime PM

Most of the reason I'm asking for an RFC here is because this code pulls a lot of code out of i915 and into shared DP helpers. Anyway-nouveau's HPD related code has been collecting dust for a while. Other then the occasional runtime PM related and MST related fixes, we're missing a lot of nice things that have been added to DRM since this was originally written. Additionally, the code

To start off: this patch series is less work to review then it looks - most (but not all) of the nouveau related work has already been reviewed elsewhere. Most of the reason I'm asking for an RFC here is because this code pulls a lot of code out of i915 and into shared DP helpers. Anyway-nouveau's HPD related code has been collecting dust for a while. Other then the occasional runtime PM

Most of the reason I'm asking for an RFC here is because this code pulls a lot of code out of i915 and into shared DP helpers. Anyway-nouveau's HPD related code has been collecting dust for a while. Other then the occasional runtime PM related and MST related fixes, we're missing a lot of nice things that have been added to DRM since this was originally written. Additionally, the code