Displaying 7 results from an estimated 7 matches for "drm_dp_dpcd_".
2024 Dec 30
1
[PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode
...> > + */
> >> > +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool enable)
> >> > +{
> >> > + u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT :
> >> > + DP_PHY_REPEATER_MODE_NON_TRANSPARENT;
> >> > + int ret = drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, val);
> >> > +
> >> > + return ret == 1 ? 0 : ret;
> >>
> >> This looks correct, but I had to go look at drm_dp_dpcd_writeb() to make
> >> sure it never returns 0 (for short transfers).
> >
> > Will fol...
2024 Dec 30
1
[PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode
...ror code on failure.
>> > + */
>> > +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool enable)
>> > +{
>> > + u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT :
>> > + DP_PHY_REPEATER_MODE_NON_TRANSPARENT;
>> > + int ret = drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, val);
>> > +
>> > + return ret == 1 ? 0 : ret;
>>
>> This looks correct, but I had to go look at drm_dp_dpcd_writeb() to make
>> sure it never returns 0 (for short transfers).
>
> Will follow Dmitry's proposal here.
>...
2024 Dec 26
1
[PATCH v2 1/4] drm/dp: Add helper to set LTTPRs in transparent mode
...success or a negative error code on failure.
> > + */
> > +int drm_dp_lttpr_set_transparent_mode(struct drm_dp_aux *aux, bool enable)
> > +{
> > + u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT :
> > + DP_PHY_REPEATER_MODE_NON_TRANSPARENT;
> > + int ret = drm_dp_dpcd_writeb(aux, DP_PHY_REPEATER_MODE, val);
> > +
> > + return ret == 1 ? 0 : ret;
>
> This looks correct, but I had to go look at drm_dp_dpcd_writeb() to make
> sure it never returns 0 (for short transfers).
Will follow Dmitry's proposal here.
if (ret < 0)
retur...
2020 Aug 25
22
[RFC v4 00/20] drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915
...might as
clean this code up and implement missing DP features like the ones
mentioned here before moving on to those tasks.
Lyude Paul (20):
drm/nouveau/kms: Fix some indenting in nouveau_dp_detect()
drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc()
drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c
drm/nouveau/kms/nv50-: Use macros for DP registers in nouveau_dp.c
drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new()
drm/nouveau/kms: Search for encoders' connectors properly
drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in
nv50_sor...
2020 Aug 20
22
[RFC v2 00/20] drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915
...e an easier time with merging if they pull the pending patches for
nouveau from Ben's tree before merging drm-misc-next.
Lyude Paul (20):
drm/nouveau/kms: Fix some indenting in nouveau_dp_detect()
drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc()
drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c
drm/nouveau/kms/nv50-: Use macros for DP registers in nouveau_dp.c
drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new()
drm/nouveau/kms: Search for encoders' connectors properly
drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in
nv50_sor...
2020 Aug 26
23
[PATCH v5 00/20] drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915
...might as
clean this code up and implement missing DP features like the ones
mentioned here before moving on to those tasks.
Lyude Paul (20):
drm/nouveau/kms: Fix some indenting in nouveau_dp_detect()
drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc()
drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c
drm/nouveau/kms/nv50-: Use macros for DP registers in nouveau_dp.c
drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new()
drm/nouveau/kms: Search for encoders' connectors properly
drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in
nv50_sor...
2020 Aug 11
29
[RFC 00/20] drm/dp, i915, nouveau: Cleanup nouveau HPD and add DP features from i915
...e an easier time with merging if they pull the pending patches for
nouveau from Ben's tree before merging drm-misc-next.
Lyude Paul (20):
drm/nouveau/kms: Fix some indenting in nouveau_dp_detect()
drm/nouveau/kms/nv50-: Remove open-coded drm_dp_read_desc()
drm/nouveau/kms/nv50-: Just use drm_dp_dpcd_read() in nouveau_dp.c
drm/nouveau/kms/nv50-: Use macros for DP registers in nouveau_dp.c
drm/nouveau/kms: Don't clear DP_MST_CTRL DPCD in nv50_mstm_new()
drm/nouveau/kms: Search for encoders' connectors properly
drm/nouveau/kms/nv50-: Use drm_dp_dpcd_(readb|writeb)() in
nv50_sor...