search for: drm_dev_register

...here is that drm_register_connector has the following at the top: if (!connector->dev->registered) return 0; Before the troublesome commit, when we still had a load callback, this check would not be hit when nouveau_drm_load() (now nouveau_drm_device_init() ran as drm_dev_register does: dev->registered = true; if (dev->driver->load) { ret = dev->driver->load(dev, flags); if (ret) goto err_minors; } So would register the connectors directly from nouveau_drm_load()/nouveau_d...

The nouveau code used to call drm_fb_helper_initial_config() from nouveau_fbcon_init() before calling drm_dev_register(). This would probe all connectors so that drm_connector->status could be used during backlight registration which runs from nouveau_connector_late_register(). After commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") the fbdev emulation code, which now is a drm-clien...

...g you know someone fixed the regression with backlight controls upstream, looking into the weird bright screen after resume issue) On Sun, 2023-03-26 at 22:54 +0200, Hans de Goede wrote: > The nouveau code used to call drm_fb_helper_initial_config() from > nouveau_fbcon_init() before calling drm_dev_register(). This would > probe all connectors so that drm_connector->status could be used during > backlight registration which runs from nouveau_connector_late_register(). > > After commit 4a16dd9d18a0 ("drm/nouveau/kms: switch to drm fbdev helpers") > the fbdev emulation code,...

When running RISC-V QEMU with the Bochs device attached via PCIe the probe of the Bochs device fails with: [drm:bochs_hw_init] *ERROR* ID mismatch This was introduced by this commit: 7780eb9ce8 bochs: convert to drm_dev_register To fix the error we ensure that pci_enable_device() is called before bochs_load(). Signed-off-by: Alistair Francis <alistair.francis at wdc.com> Reported-by: David Abdurachmanov <david.abdurachmanov at gmail.com> --- drivers/gpu/drm/bochs/bochs_drv.c | 4 ++++ 1 file changed, 4 inser...

This is leftovers from the old drm_driver->load callback upside-down issues. It doesn't do anything for not-hotplugged connectors since drm_dev_register takes care of that. Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> Cc: Gerd Hoffmann <kraxel at redhat.com> Cc: virtualization at lists.linux-foundation.org --- drivers/gpu/drm/bochs/bochs_kms.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_...

When running RISC-V QEMU with the Bochs device attached via PCIe the probe of the Bochs device fails with: [drm:bochs_hw_init] *ERROR* ID mismatch This was introduced by this commit: 7780eb9ce8 bochs: convert to drm_dev_register To fix the error we ensure that pci_enable_device() is called before bochs_load(). Signed-off-by: Alistair Francis <alistair.francis at wdc.com> Reported-by: David Abdurachmanov <david.abdurachmanov at gmail.com> --- drivers/gpu/drm/bochs/bochs_drv.c | 4 ++++ 1 file changed, 4 inser...

...[ 19.120708] ffe0: bea73af8 bea73ae8 b6c44c14 b6b4b710 600d0010 0000000f 00000000 00000000 [ 19.128884] [<c068b938>] (drm_plane_register_all) from [<c068e45c>] (drm_modeset_register_all+0xc/0x70) [ 19.138273] [<c068e45c>] (drm_modeset_register_all) from [<c06751a4>] (drm_dev_register+0x168/0x1c4) [ 19.147581] [<c06751a4>] (drm_dev_register) from [<bf1c5cd4>] (nouveau_platform_probe+0x6c/0x88 [nouveau]) [ 19.157434] [<bf1c5cd4>] (nouveau_platform_probe [nouveau]) from [<c06a3f64>] (platform_drv_probe+0x48/0x98) [ 19.167256] [<c06a3f64>] (pl...

...tair Francis wrote: > > When running RISC-V QEMU with the Bochs device attached via PCIe the > > probe of the Bochs device fails with: > > [drm:bochs_hw_init] *ERROR* ID mismatch > > > > This was introduced by this commit: > > 7780eb9ce8 bochs: convert to drm_dev_register > > > > To fix the error we ensure that pci_enable_device() is called before > > bochs_load(). > > > > Signed-off-by: Alistair Francis <alistair.francis at wdc.com> > > Reported-by: David Abdurachmanov <david.abdurachmanov at gmail.com> > > Push...

...tair Francis wrote: > > When running RISC-V QEMU with the Bochs device attached via PCIe the > > probe of the Bochs device fails with: > > [drm:bochs_hw_init] *ERROR* ID mismatch > > > > This was introduced by this commit: > > 7780eb9ce8 bochs: convert to drm_dev_register > > > > To fix the error we ensure that pci_enable_device() is called before > > bochs_load(). > > > > Signed-off-by: Alistair Francis <alistair.francis at wdc.com> > > Reported-by: David Abdurachmanov <david.abdurachmanov at gmail.com> > > Push...

..._init+0x21/0x5c [nouveau] [ 7.404453] nouveau_cli_init+0x21f/0xe1f [nouveau] [ 7.404733] ? nouveau_drm_load+0x1d/0xe11 [nouveau] [ 7.405011] nouveau_drm_load+0x54/0xe11 [nouveau] [ 7.405112] ? kernfs_new_node+0x2b/0x8e [ 7.405209] ? kernfs_create_link+0x55/0xcd [ 7.405323] ? drm_dev_register+0x12f/0x2e0 [drm] [ 7.405437] drm_dev_register+0x168/0x2e0 [drm] [ 7.405538] ? pci_enable_device_flags+0xeb/0x15e [ 7.405651] drm_get_pci_dev+0xbf/0x230 [drm] [ 7.405924] nouveau_drm_probe+0x183/0x1ea [nouveau] [ 7.406035] pci_device_probe+0xaa/0x163 [ 7.406136] driver_probe...

...drm_helper_probe_single_connector_modes+0x7d/0x6b0 [drm_kms_helper] drm_setup_crtcs+0x15e/0xc90 [drm_kms_helper] __drm_fb_helper_initial_config_and_unlock+0x29/0x480 [drm_kms_helper] nouveau_fbcon_init+0x138/0x1a0 [nouveau] nouveau_drm_load+0x173/0x7e0 [nouveau] drm_dev_register+0x134/0x1c0 [drm] drm_get_pci_dev+0x8e/0x160 [drm] nouveau_drm_probe+0x1a9/0x230 [nouveau] pci_device_probe+0xcd/0x150 driver_probe_device+0x30b/0x480 __driver_attach+0xbc/0xe0 bus_for_each_dev+0x67/0x90 bus_add_driver+0x164/0x260 driver_regis...

...[ 8.603908] 7fe0: bea8f990 bea8f980 b6f71269 b6e9f6c0 400d0010 0000000f 00000000 00000000 [ 8.612096] [<c056200c>] (drm_plane_register_all) from [<c0564cc8>] (drm_modeset_register_all+0xc/0x70) [ 8.621499] [<c0564cc8>] (drm_modeset_register_all) from [<c054b5b8>] (drm_dev_register+0x168/0x1c4) [ 8.630855] [<c054b5b8>] (drm_dev_register) from [<bf0dc900>] (nouveau_platform_probe+0x6c/0x88 [nouveau]) [ 8.640739] [<bf0dc900>] (nouveau_platform_probe [nouveau]) from [<c05a9328>] (platform_drv_probe+0x48/0x98) [ 8.650574] [<c05a9328>] (platf...

...708] ffe0: bea73af8 bea73ae8 b6c44c14 b6b4b710 600d0010 0000000f 00000000 00000000 > [ 19.128884] [<c068b938>] (drm_plane_register_all) from [<c068e45c>] (drm_modeset_register_all+0xc/0x70) > [ 19.138273] [<c068e45c>] (drm_modeset_register_all) from [<c06751a4>] (drm_dev_register+0x168/0x1c4) > [ 19.147581] [<c06751a4>] (drm_dev_register) from [<bf1c5cd4>] (nouveau_platform_probe+0x6c/0x88 [nouveau]) > [ 19.157434] [<bf1c5cd4>] (nouveau_platform_probe [nouveau]) from [<c06a3f64>] (platform_drv_probe+0x48/0x98) > [ 19.167256] [<c0...

..._device_id *ent) drm_kms_helper_poll_init(&qdev->ddev); + /* unbind vgacon to make sure it doesn't touch our vga registers */ + console_lock(); + ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, true); + console_unlock(); + /* Complete initialization. */ ret = drm_dev_register(&qdev->ddev, ent->driver_data); if (ret) -- 2.9.3

..._device_id *ent) drm_kms_helper_poll_init(&qdev->ddev); + /* unbind vgacon to make sure it doesn't touch our vga registers */ + console_lock(); + ret = do_take_over_console(&dummy_con, 0, MAX_NR_CONSOLES - 1, true); + console_unlock(); + /* Complete initialization. */ ret = drm_dev_register(&qdev->ddev, ent->driver_data); if (ret) -- 2.9.3

...e9f6c0 400d0010 > > 0000000f 00000000 00000000 > > [ 8.612096] [<c056200c>] (drm_plane_register_all) from [<c0564cc8>] > > (drm_modeset_register_all+0xc/0x70) > > [ 8.621499] [<c0564cc8>] (drm_modeset_register_all) from > > [<c054b5b8>] (drm_dev_register+0x168/0x1c4) > > [ 8.630855] [<c054b5b8>] (drm_dev_register) from [<bf0dc900>] > > (nouveau_platform_probe+0x6c/0x88 [nouveau]) > > [ 8.640739] [<bf0dc900>] (nouveau_platform_probe [nouveau]) from > > [<c05a9328>] (platform_drv_probe+0x48/0x98)...

...veau] [77216.711308] [<ffff0000019e4620>] nv50_display_create+0x10c/0xa1c [nouveau] [77216.718340] [<ffff0000019df898>] nouveau_display_create+0x50c/0x59c [nouveau] [77216.725632] [<ffff0000019d3e24>] nouveau_drm_load+0x22c/0x8c0 [nouveau] [77216.732286] [<ffff00000137a1a0>] drm_dev_register+0xc0/0xf0 [drm] [77216.738409] [<ffff00000137b8a4>] drm_get_pci_dev+0xbc/0x188 [drm] [77216.744663] [<ffff0000019d35e8>] nouveau_drm_probe+0x180/0x208 [nouveau] [77216.751354] [<ffff0000084c30dc>] local_pci_probe+0x50/0xb4 [77216.756827] [<ffff0000084c3e40>] pci_device_probe...

...] nvif_device_init+0x9/0x40 [nouveau] [ 10.018136] nouveau_cli_init+0x234/0x12f0 [nouveau] [ 10.023253] ? idr_alloc_cyclic+0x6c/0x110 [ 10.027487] ? _cond_resched+0x1d/0x80 [ 10.031366] ? kmem_cache_alloc+0x1f0/0x2d0 [ 10.035790] nouveau_drm_load+0x71/0xec0 [nouveau] [ 10.040735] drm_dev_register+0x1b4/0x330 [ 10.044872] ? pci_enable_device_flags+0x155/0x200 [ 10.049806] drm_get_pci_dev+0xde/0x2c0 [ 10.053874] nouveau_drm_probe+0x1b9/0x240 [nouveau] [ 10.058986] ? __pm_runtime_resume+0x68/0xb0 [ 10.063409] local_pci_probe+0x5e/0xf0 [ 10.067300] work_for_cpu_fn+0x10/0x30 [...

...nouveau_accel_init+0x157/0x4e0 [nouveau] [ 37.497413] [<c05dda14>] ? kmem_cache_alloc_trace+0x364/0x3e0 [ 37.497413] [<f85b7431>] ? nouveau_hwmon_init+0x41/0x1d0 [nouveau] [ 37.497413] [<f85b6140>] nouveau_drm_load+0x3f0/0x5e0 [nouveau] [ 37.497413] [<f7e45066>] drm_dev_register+0x96/0xe0 [drm] [ 37.497413] [<f7e47b89>] drm_get_pci_dev+0x79/0x1c0 [drm] [ 37.497413] [<c07d9c1e>] ? pcibios_set_master+0x4e/0xa0 [ 37.497413] [<f85b654e>] nouveau_drm_probe+0x21e/0x260 [nouveau] [ 37.497413] [<c07dc24f>] pci_device_probe+0x6f/0xd0 [ 37.49741...

...f990 bea8f980 b6f71269 b6e9f6c0 400d0010 > 0000000f 00000000 00000000 > [ 8.612096] [<c056200c>] (drm_plane_register_all) from [<c0564cc8>] > (drm_modeset_register_all+0xc/0x70) > [ 8.621499] [<c0564cc8>] (drm_modeset_register_all) from > [<c054b5b8>] (drm_dev_register+0x168/0x1c4) > [ 8.630855] [<c054b5b8>] (drm_dev_register) from [<bf0dc900>] > (nouveau_platform_probe+0x6c/0x88 [nouveau]) > [ 8.640739] [<bf0dc900>] (nouveau_platform_probe [nouveau]) from > [<c05a9328>] (platform_drv_probe+0x48/0x98) > [ 8.650574]...