search for: drm_debug_atom

...drm_dp_mst_topology_state *state) > { > struct drm_dp_mst_topology_mgr *mgr = state->mgr; > struct drm_dp_vcpi_allocation *pos; > - int avail_slots = 63; > + int avail_slots = 63, payload_count = 0; > > list_for_each_entry(pos, &state->vcpis, next) { > DRM_DEBUG_ATOMIC("[MST PORT:%p] requires %d vcpi slots\n", > @@ -3251,6 +3251,12 @@ int drm_dp_mst_atomic_check(struct drm_dp_mst_topology_state *state) > avail_slots + pos->vcpi); > return -ENOSPC; > } > + > + if (++payload_count > mgr->max_payloads) { > +...

AMD's patch series for adding DSC support to the MST helpers unfortunately introduced a few regressions into the kernel that I didn't get around to fixing until just now. I would have reverted the changes earlier, but seeing as that would have reverted all of amd's DSC support + everything that was done on top of that I realllllly wanted to avoid doing that. Anyway, this should fix

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (6): drm/dp_mst: Deprecate drm_dp_find_vcpi_slots() drm/dp_mst: Remove all evil duplicate state

...to add even more error checking to make misusage of the helpers more obvious. I added this after having to chase down various use-after-free conditions that started popping up from the new helpers so no one else has to troubleshoot that. - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() - Update documentation again, note that find/release() should both not be called on the same port in a single atomic check phase (but multiple calls to one or the other is OK) Changes since v4: - Don't skip the atomic checks for VCPI allocations if no new VCPI allocations happen...

...gt; checking to make misusage of the helpers more obvious. I added this > after having to chase down various use-after-free conditions that > started popping up from the new helpers so no one else has to > troubleshoot that. > - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() > - Update documentation again, note that find/release() should both not be > called on the same port in a single atomic check phase (but multiple > calls to one or the other is OK) > > Changes since v4: > - Don't skip the atomic checks for VCPI allocations if no...

...to add even more error checking to make misusage of the helpers more obvious. I added this after having to chase down various use-after-free conditions that started popping up from the new helpers so no one else has to troubleshoot that. - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() - Update documentation again, note that find/release() should both not be called on the same port in a single atomic check phase (but multiple calls to one or the other is OK) Changes since v4: - Don't skip the atomic checks for VCPI allocations if no new VCPI allocations happen...

...gt; > > > that > > > > > > > started popping up from the new helpers so no one else has to > > > > > > > troubleshoot that. > > > > > > > - Move some accidental DRM_DEBUG_KMS() calls to > > > > > > > DRM_DEBUG_ATOMIC() > > > > > > > - Update documentation again, note that find/release() should > > > > > > > both > > > > > > > not > > > > > > > be > > > > > > > called on the same port in a single atomic...

...heck(struct drm_private_obj *obj, to_dp_mst_topology_state(state); struct drm_dp_mst_topology_mgr *mgr = mst_state->mgr; struct drm_dp_vcpi_allocation *pos; - int avail_slots = 63; + int avail_slots = 63, payload_count = 0; list_for_each_entry(pos, &mst_state->vcpis, next) { DRM_DEBUG_ATOMIC("[MST PORT:%p] requires %d vcpi slots\n", @@ -3238,6 +3238,12 @@ static int drm_dp_mst_atomic_check(struct drm_private_obj *obj, avail_slots + pos->vcpi); return -ENOSPC; } + + if (++payload_count > mgr->max_payloads) { + DRM_DEBUG_ATOMIC("[MST MGR:%p] sta...

...,7 @@ int drm_dp_mst_atomic_check(struct drm_dp_mst_topology_state *state) { struct drm_dp_mst_topology_mgr *mgr = state->mgr; struct drm_dp_vcpi_allocation *pos; - int avail_slots = 63; + int avail_slots = 63, payload_count = 0; list_for_each_entry(pos, &state->vcpis, next) { DRM_DEBUG_ATOMIC("[MST PORT:%p] requires %d vcpi slots\n", @@ -3251,6 +3251,12 @@ int drm_dp_mst_atomic_check(struct drm_dp_mst_topology_state *state) avail_slots + pos->vcpi); return -ENOSPC; } + + if (++payload_count > mgr->max_payloads) { + DRM_DEBUG_ATOMIC("[MST MGR:%p...

...> > > > after having to chase down various use-after-free conditions that > > > > > started popping up from the new helpers so no one else has to > > > > > troubleshoot that. > > > > > - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() > > > > > - Update documentation again, note that find/release() should both > > > > > not > > > > > be > > > > > called on the same port in a single atomic check phase (but > > > > > multiple > > > > &gt...

...helpers more obvious. I added this > > > after having to chase down various use-after-free conditions that > > > started popping up from the new helpers so no one else has to > > > troubleshoot that. > > > - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() > > > - Update documentation again, note that find/release() should both not > > > be > > > called on the same port in a single atomic check phase (but multiple > > > calls to one or the other is OK) > > > > > > Changes since v4: &gt...

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. [sorry for still not adding your R-Bs! I ended up needing to make a lot of changes to make it so we do actually kref() each port in the atomic state] Cc: Daniel

...OK: all we care > + * about is ensuring that userspace can't do anything but shut off the > + * display on a connector that was destroyed after its been notified, > + * not before. > + */ > + if (!READ_ONCE(connector->registered) && crtc_state->active) { > + DRM_DEBUG_ATOMIC("[CONNECTOR:%d:%s] is not registered\n", > + connector->base.id, connector->name); > + return -EINVAL; > + } This broke my ilk (and presumably snb-bdw as well). [ 25.593121] [drm:drm_atomic_helper_check_modeset [drm_kms_helper]] Updating routing for [CONNECTOR:55...

...ake misusage of the helpers more obvious. I added this > > after having to chase down various use-after-free conditions that > > started popping up from the new helpers so no one else has to > > troubleshoot that. > > - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() > > - Update documentation again, note that find/release() should both not be > > called on the same port in a single atomic check phase (but multiple > > calls to one or the other is OK) > > > > Changes since v4: > > - Don't skip the atomic chec...

...ake misusage of the helpers more obvious. I added this > > after having to chase down various use-after-free conditions that > > started popping up from the new helpers so no one else has to > > troubleshoot that. > > - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() > > - Update documentation again, note that find/release() should both not be > > called on the same port in a single atomic check phase (but multiple > > calls to one or the other is OK) > > > > Changes since v4: > > - Don't skip the atomic chec...

.... I added this > > > > after having to chase down various use-after-free conditions that > > > > started popping up from the new helpers so no one else has to > > > > troubleshoot that. > > > > - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() > > > > - Update documentation again, note that find/release() should both not > > > > be > > > > called on the same port in a single atomic check phase (but multiple > > > > calls to one or the other is OK) > > > > > > &...

...to add even more error checking to make misusage of the helpers more obvious. I added this after having to chase down various use-after-free conditions that started popping up from the new helpers so no one else has to troubleshoot that. - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() - Update documentation again, note that find/release() should both not be called on the same port in a single atomic check phase (but multiple calls to one or the other is OK) Changes since v4: - Don't skip the atomic checks for VCPI allocations if no new VCPI allocations happen...

...> after having to chase down various use-after-free conditions that > > > > > > started popping up from the new helpers so no one else has to > > > > > > troubleshoot that. > > > > > > - Move some accidental DRM_DEBUG_KMS() calls to DRM_DEBUG_ATOMIC() > > > > > > - Update documentation again, note that find/release() should both > > > > > > not > > > > > > be > > > > > > called on the same port in a single atomic check phase (but > > > > > > multipl...

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (4): drm/dp_mst: Add some atomic state iterator macros drm/dp_mst: Start tracking per-port VCPI

This patchset does some cleaning up of the atomic VCPI helpers for MST, and converts nouveau over to using them. I would have included amdgpu in this patch as well, but at the moment moving them over to the atomic helpers is nontrivial. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (5): drm/dp_mst: Add some atomic state iterator macros drm/dp_mst: Start tracking per-port VCPI