search for: drm_core_init

...gt; + return; > > + } > > + > > + /* Find the 'dri' root debugfs entry. Every GPU has a dentry under it */ > > + root = debugfs_lookup("dri", NULL); > > + if (IS_ERR(root)) { > > I don't think this can ever happen. This entry is created in drm_core_init(). So first, the check is wrong. It should be "if (!root)". However, I think it can happen. drm_core_init() does not fail if debugfs_create_dir() fails: drm_debugfs_root = debugfs_create_dir("dri", NULL); It doesn't even print a warning message. It just keeps going....

...gt; > > + > > > + /* Find the 'dri' root debugfs entry. Every GPU has a dentry under it */ > > > + root = debugfs_lookup("dri", NULL); > > > + if (IS_ERR(root)) { > > > > I don't think this can ever happen. This entry is created in drm_core_init(). Oh, I see how this reads. I think I didn't quite finish the reply. Sorry for the confusion. > > So first, the check is wrong. It should be "if (!root)". That's what I meant, it can't be an ERR_PTR. > > However, I think it can happen. drm_core_init() does...

...safe, i.e. nvif_log_shutdown() can't be called > with a random list_head and struct nvif_log::shutdown can't be called with the > "head instance" of struct struct nvif_log. Ok, I think I got it this time. I'll post a v7 soon. > > However, I think it can happen. drm_core_init() does not fail if > > debugfs_create_dir() fails: > > > > drm_debugfs_root = debugfs_create_dir("dri", NULL); > > > > It doesn't even print a warning message. It just keeps going. So I think > > there should be some error checking somewhere. &...

...gging buffers are empty\n"); > + return; > + } > + > + /* Find the 'dri' root debugfs entry. Every GPU has a dentry under it */ > + root = debugfs_lookup("dri", NULL); > + if (IS_ERR(root)) { I don't think this can ever happen. This entry is created in drm_core_init(). > + /* No debugfs, or no root dentry for DRM */ > + nvkm_warn(&gsp->subdev, "could not find debugfs dri root\n"); > + return; > + } > + > + /* Create a new debugfs root. It has the same name as the old one */ > + dir = debugfs_create_dir(dev_name(dev), r...

The LOGINIT, LOGINTR, LOGRM, and LOGPMU buffers are circular buffers that have printf-like logs from GSP-RM and PMU encoded in them. LOGINIT, LOGINTR, and LOGRM are allocated by Nouveau and their DMA addresses are passed to GSP-RM during initialization. The buffers are required for GSP-RM to initialize properly. LOGPMU is also allocated by Nouveau, but its contents are updated when Nouveau

Greetings, I got the below dmesg and the first bad commit is commit cf39c8e5352b4fb9efedfe7e9acb566a85ed847c Merge: 3398d25 23b7eaf Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Wed Sep 4 17:45:39 2013 -0700 Merge tag ''stable/for-linus-3.12-rc0-tag'' of git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip Pull Xen updates from Konrad