search for: drm_connector_regist

...73888e8 100644 --- a/drivers/gpu/drm/bochs/bochs_kms.c +++ b/drivers/gpu/drm/bochs/bochs_kms.c @@ -104,7 +104,6 @@ static void bochs_connector_init(struct drm_device *dev) DRM_MODE_CONNECTOR_VIRTUAL); drm_connector_helper_add(connector, &bochs_connector_connector_helper_funcs); - drm_connector_register(connector); bochs_hw_load_edid(bochs); if (bochs->edid) { -- 2.25.1

...uct drm_device *dev, if (ret) { nvif_event_dtor(&nv_connector->hpd); nvif_conn_dtor(&nv_connector->conn); - kfree(nv_connector); - return ERR_PTR(ret); + goto drm_conn_err; } } } @@ -1475,4 +1473,9 @@ nouveau_connector_create(struct drm_device *dev, drm_connector_register(connector); return connector; + +drm_conn_err: + drm_connector_cleanup(connector); + kfree(nv_connector); + return ERR_PTR(ret); } -- 2.41.0

...nd up sending a v2 anyway, so maybe you should wait for it. If you want to try this version anyway, I have fixed-up patches against your tree. Note that your tree currently won't build against -next because it uses drm_sysfs_connector_add/remove which are not available anymore (replaced by drm_connector_register/unregister I believe). Oh and while I'm at it, there seems to be a typo in line 131 of clock.h, which should read _nouveau_clock_fini and not _nouveau_clock_init. >> >> The last patch adds the GK20A clock device. Arguably the clock can be seen as a >> stripped-down versio...

...count = drm_add_modes_noedid(connector, 8192, 8192); + drm_set_preferred_mode(connector, defx, defy); + } return count; } @@ -271,6 +278,11 @@ static void bochs_connector_init(struct drm_device *dev) drm_connector_helper_add(connector, &bochs_connector_connector_helper_funcs); drm_connector_register(connector); + + if (bochs->edid) { + drm_connector_attach_edid_property(connector); + drm_connector_update_edid_property(connector, bochs->edid); + } } -- 2.9.3

...count = drm_add_modes_noedid(connector, 8192, 8192); + drm_set_preferred_mode(connector, defx, defy); + } return count; } @@ -239,6 +246,11 @@ static void bochs_connector_init(struct drm_device *dev) drm_connector_helper_add(connector, &bochs_connector_connector_helper_funcs); drm_connector_register(connector); + + if (bochs->edid) { + drm_connector_attach_edid_property(connector); + drm_connector_update_edid_property(connector, bochs->edid); + } } -- 2.9.3

...count = drm_add_modes_noedid(connector, 8192, 8192); + drm_set_preferred_mode(connector, defx, defy); + } return count; } @@ -239,6 +246,11 @@ static void bochs_connector_init(struct drm_device *dev) drm_connector_helper_add(connector, &bochs_connector_connector_helper_funcs); drm_connector_register(connector); + + if (bochs->edid) { + drm_connector_attach_edid_property(connector); + drm_connector_update_edid_property(connector, bochs->edid); + } } -- 2.9.3

...rm_dev_register(), turning the drm_register_connector() call at the end of nouveau_connector_create in a no-op for non dp-mst connectors. The connectors do get registered a bit later when drm_dev_register() calls drm_modeset_register_all() This subtle change in ordering is why I started poking at drm_connector_register and the functions it calls and how I found out that commenting out the drm_sysfs_hotplug_event() call reproduces the behavior on older working kernels. I have tried replacing this with a sleep call to rule out timing issues, that does not help. Other things I have checked is that one commit bef...

...77,9 +3278,7 @@ nv50_mstm_register_connector(struct drm_connector *connector) { struct nouveau_drm *drm = nouveau_drm(connector->dev); - drm_modeset_lock_all(drm->dev); drm_fb_helper_add_one_connector(&drm->fbcon->helper, connector); - drm_modeset_unlock_all(drm->dev); drm_connector_register(connector); } -- 2.14.3

...drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e42a28e3adc5..2c3660c36732 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -3626,9 +3626,17 @@ static int amdgpu_dm_connector_init(struct amdgpu_display_manager *dm, drm_connector_register(&aconnector->base); - if (connector_type == DRM_MODE_CONNECTOR_DisplayPort - || connector_type == DRM_MODE_CONNECTOR_eDP) - amdgpu_dm_initialize_dp_connector(dm, aconnector); + if (connector_type == DRM_MODE_CONNECTOR_DisplayPort || + connector_type == DRM_MODE_CONNECTOR_eDP) { +...

...drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e42a28e3adc5..2c3660c36732 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -3626,9 +3626,17 @@ static int amdgpu_dm_connector_init(struct amdgpu_display_manager *dm, drm_connector_register(&aconnector->base); - if (connector_type == DRM_MODE_CONNECTOR_DisplayPort - || connector_type == DRM_MODE_CONNECTOR_eDP) - amdgpu_dm_initialize_dp_connector(dm, aconnector); + if (connector_type == DRM_MODE_CONNECTOR_DisplayPort || + connector_type == DRM_MODE_CONNECTOR_eDP) { +...

...drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index e42a28e3adc5..2c3660c36732 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -3626,9 +3626,17 @@ static int amdgpu_dm_connector_init(struct amdgpu_display_manager *dm, drm_connector_register(&aconnector->base); - if (connector_type == DRM_MODE_CONNECTOR_DisplayPort - || connector_type == DRM_MODE_CONNECTOR_eDP) - amdgpu_dm_initialize_dp_connector(dm, aconnector); + if (connector_type == DRM_MODE_CONNECTOR_DisplayPort || + connector_type == DRM_MODE_CONNECTOR_eDP) { +...

Latest version of https://patchwork.freedesktop.org/series/39642/ , hopefully patchwork understands this and doesn't break anything! Lots of changes. Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() drm/dp_mst: Remove all evil duplicate state

Latest version of PW series 39642, hopefully this should also actually come up on intel-gfx and go through CI. No changes other than rebasing to the current drm-intel-next-queued Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() drm/dp_mst: Remove all

Next version of https://patchwork.freedesktop.org/series/41576/ Only changes are removing duplicate SoBs that git send-email annoyingly added. Sorry about that :( Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() drm/dp_mst: Remove all evil duplicate

Next version of https://patchwork.freedesktop.org/series/41576/ All changes in this patch series are just to make checkpatch a little happier, no functional changes. Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state() drm/dp_mst: Remove all evil duplicate

...ig.mutex. This ends up creating an extremely rude chain: &kn->count -> &drm->mode_config.mutex -> crtc_ww_class_mutex/crtc_ww_class_acquire -> &connector->mutex I mean, look at that thing! It's just evil!!! This gross thing ends up making any calls to drm_connector_register()/drm_connector_unregister() impossible when holding any kind of modesetting lock. This is annoying because ideally, we always want to ensure that drm_dp_mst_port->connector never changes when doing an atomic commit or check that would affect the atomic topology state so that it can reliably a...

...work. > > So what do we do with this? It fixes a problem upstream. There's no > Fixes: to identify the bad commit. Any idea on that? It's either this or > we dig out the bad commit (Chris probably knows which one?) and revert. The real trouble is the drm_for_each_connector in drm_connector_register_all(). This introduced the new depency. The proper fix imo is to fix up the connector_list locking, but for 4.8 we could do the same hack+comment like we do in unregister_all. It's not the only place that's broken anyway, and much less invasive than this here. If someone confirms I'l...

...fffa0127eb2>] intel_backlight_device_register+0xa2/0x160 [i915] [ 18.983892] [<ffffffffa00f46be>] intel_connector_register+0xe/0x10 [i915] [ 18.983932] [<ffffffffa0112bfb>] intel_dp_connector_register+0x1b/0x80 [i915] [ 18.983936] [<ffffffff8159dfea>] drm_connector_register+0x4a/0x80 [ 18.983938] [<ffffffff8159fe44>] drm_connector_register_all+0x64/0xf0 [ 18.983940] [<ffffffff815a2a64>] drm_modeset_register_all+0x174/0x1c0 [ 18.983942] [<ffffffff81599b72>] drm_dev_register+0xc2/0xd0 [ 18.983976] [<ffffffffa006...

...light_device_register+0xa2/0x160 [i915] >> [ 18.983892] [<ffffffffa00f46be>] intel_connector_register+0xe/0x10 [i915] >> [ 18.983932] [<ffffffffa0112bfb>] intel_dp_connector_register+0x1b/0x80 [i915] >> [ 18.983936] [<ffffffff8159dfea>] drm_connector_register+0x4a/0x80 >> [ 18.983938] [<ffffffff8159fe44>] drm_connector_register_all+0x64/0xf0 >> [ 18.983940] [<ffffffff815a2a64>] drm_modeset_register_all+0x174/0x1c0 >> [ 18.983942] [<ffffffff81599b72>] drm_dev_register+0xc2/0xd0 >> [...

...tor = &cirrus_connector->base; > - > - drm_connector_init(dev, connector, > - &cirrus_vga_connector_funcs, DRM_MODE_CONNECTOR_VGA); > - > - drm_connector_helper_add(connector, &cirrus_vga_connector_helper_funcs); > - > - drm_connector_register(connector); > - return connector; > -} > - > - > -int cirrus_modeset_init(struct cirrus_device *cdev) > -{ > - struct drm_encoder *encoder; > - struct drm_connector *connector; > - int ret; > - > - drm_mode_config_init(cdev->dev);...