search for: drm_atomic_helper_update_plane

...lanes.c index 600fa7bd7f52..0f0f8234fe21 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -128,7 +128,6 @@ static void malidp_plane_atomic_print_state(struct drm_printer *p, static const struct drm_plane_funcs malidp_de_plane_funcs = { .update_plane = drm_atomic_helper_update_plane, .disable_plane = drm_atomic_helper_disable_plane, - .set_property = drm_atomic_helper_plane_set_property, .destroy = malidp_de_plane_destroy, .reset = malidp_plane_reset, .atomic_duplicate_state = malidp_duplicate_plane_state, diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/...

...t+0x36/0xf0 ... Oops: 0000 [#1] SMP Modules linked in: ... nouveau ... CPU: 0 PID: 6895 Comm: Xorg Not tainted 4.10.5-1001.fc24.x86_64 #1 ... Call Trace: drm_atomic_helper_wait_for_fences+0x48/0x120 [drm_kms_helper] nv50_disp_atomic_commit+0x19c/0x2a0 [nouveau] drm_atomic_commit+0x4b/0x50 [drm] drm_atomic_helper_update_plane+0xec/0x150 [drm_kms_helper] __setplane_internal+0x1b4/0x280 [drm] drm_mode_cursor_universal+0x126/0x210 [drm] drm_mode_cursor_common+0x86/0x180 [drm] drm_mode_cursor_ioctl+0x50/0x70 [drm] drm_ioctl+0x21b/0x4c0 [drm] ? drm_mode_setplane+0x1a0/0x1a0 [drm] nouveau_drm_ioctl+0x74/0xc0 [nouveau]...

...es+0xb9/0x220 [drm_kms_helper] [354073.738371] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] [354073.738374] commit_tail+0x67/0x70 [drm_kms_helper] [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] [354073.738402] __setplane_atomic+0xd3/0x120 [drm] [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [354073.738432] drm_mode_cursor2_ioctl+0xe/...

...es+0xb9/0x220 [drm_kms_helper] [354073.738371] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] [354073.738374] commit_tail+0x67/0x70 [drm_kms_helper] [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] [354073.738402] __setplane_atomic+0xd3/0x120 [drm] [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [354073.738432] drm_mode_cursor2_ioctl+0xe/...

On 05.09.19 10:14, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 09:00:10PM +0300, Jaak Ristioja wrote: >> Hello! >> >> I'm writing to report a crash in the QXL / DRM code in the Linux kernel. >> I originally filed the issue on LaunchPad and more details can be found >> there, although I doubt whether these details are useful. > > Any change with kernel

On 05.09.19 10:14, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 09:00:10PM +0300, Jaak Ristioja wrote: >> Hello! >> >> I'm writing to report a crash in the QXL / DRM code in the Linux kernel. >> I originally filed the issue on LaunchPad and more details can be found >> there, although I doubt whether these details are useful. > > Any change with kernel

...[qxl] qxl_cursor_atomic_update+0x1b0/0x2e0 [qxl] drm_atomic_helper_commit_planes+0xb9/0x220 [drm_kms_helper] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] commit_tail+0x67/0x70 [drm_kms_helper] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] drm_atomic_commit+0x4a/0x50 [drm] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] __setplane_atomic+0xd6/0x120 [drm] drm_mode_cursor_universal+0x145/0x270 [drm] drm_mode_cursor_common+0x18f/0x200 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] drm_mode_cursor2_ioctl+0xe/0x10 [drm] drm_ioctl_kernel+0xad/0xf0 [drm] ? ___sys_recvmsg+0x16c/0x200 drm...

...[qxl] qxl_cursor_atomic_update+0x1b0/0x2e0 [qxl] drm_atomic_helper_commit_planes+0xb9/0x220 [drm_kms_helper] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] commit_tail+0x67/0x70 [drm_kms_helper] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] drm_atomic_commit+0x4a/0x50 [drm] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] __setplane_atomic+0xd6/0x120 [drm] drm_mode_cursor_universal+0x145/0x270 [drm] drm_mode_cursor_common+0x18f/0x200 [drm] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] drm_mode_cursor2_ioctl+0xe/0x10 [drm] drm_ioctl_kernel+0xad/0xf0 [drm] ? ___sys_recvmsg+0x16c/0x200 drm...

....c:2444 (discriminator 2)) [ 37.725324] vgdev_atomic_commit_tail (linux/drivers/gpu/drm/virtio/virtgpu_display.c:332) [ 37.725835] commit_tail (linux/drivers/gpu/drm/drm_atomic_helper.c:1612) [ 37.726204] drm_atomic_helper_commit (linux/drivers/gpu/drm/drm_atomic_helper.c:1824) [ 37.726729] drm_atomic_helper_update_plane (linux/drivers/gpu/drm/drm_atomic_helper.c:2858) [ 37.727391] drm_mode_cursor_universal (linux/drivers/gpu/drm/drm_plane.c:909) [...] [ 37.729585] drm_mode_cursor_common (linux/drivers/gpu/drm/drm_plane.c:995) [...] [ 37.731491] drm_ioctl_kernel (linux/drivers/gpu/drm/drm_ioctl.c:792) [...] [...

...es+0xd5/0x220 [drm_kms_helper] [124212.551388] drm_atomic_helper_commit_tail+0x2c/0x70 [drm_kms_helper] [124212.551392] commit_tail+0x68/0x70 [drm_kms_helper] [124212.551395] drm_atomic_helper_commit+0x118/0x120 [drm_kms_helper] [124212.551407] drm_atomic_commit+0x4a/0x50 [drm] [124212.551411] drm_atomic_helper_update_plane+0xea/0x100 [drm_kms_helper] [124212.551418] __setplane_atomic+0xcb/0x110 [drm] [124212.551428] drm_mode_cursor_universal+0x140/0x260 [drm] [124212.551435] drm_mode_cursor_common+0xcc/0x220 [drm] [124212.551441] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] [124212.551447] drm_mode_cursor2_ioctl+0xe/...

...lper] > [124212.551388] drm_atomic_helper_commit_tail+0x2c/0x70 [drm_kms_helper] > [124212.551392] commit_tail+0x68/0x70 [drm_kms_helper] > [124212.551395] drm_atomic_helper_commit+0x118/0x120 [drm_kms_helper] > [124212.551407] drm_atomic_commit+0x4a/0x50 [drm] > [124212.551411] drm_atomic_helper_update_plane+0xea/0x100 [drm_kms_helper] > [124212.551418] __setplane_atomic+0xcb/0x110 [drm] > [124212.551428] drm_mode_cursor_universal+0x140/0x260 [drm] > [124212.551435] drm_mode_cursor_common+0xcc/0x220 [drm] > [124212.551441] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [124212.551447] dr...

...ersal(crtc, req, file_priv); + if (drm_core_check_feature(DRIVER_ATOMIC)) + ret = drm_mode_cursor_atomic(crtc, req, file_priv); + else + ret = drm_mode_cursor_universal(crtc, req, file_priv); goto out; } drm_mode_cursor_atomic would simply be a fusing of drm_mode_cursor_universal + drm_atomic_helper_update_plane (dump all the intermediate variables and store directly in the plane state), with the addition of also storing hot_x/y into the plane state. Sorry that this turned into a bit of a project, I've forgotten that we haven't wired up hot_x/y at all for atomic ... If you don't want to b...

...ersal(crtc, req, file_priv); + if (drm_core_check_feature(DRIVER_ATOMIC)) + ret = drm_mode_cursor_atomic(crtc, req, file_priv); + else + ret = drm_mode_cursor_universal(crtc, req, file_priv); goto out; } drm_mode_cursor_atomic would simply be a fusing of drm_mode_cursor_universal + drm_atomic_helper_update_plane (dump all the intermediate variables and store directly in the plane state), with the addition of also storing hot_x/y into the plane state. Sorry that this turned into a bit of a project, I've forgotten that we haven't wired up hot_x/y at all for atomic ... If you don't want to b...

...lper] > [354073.738371] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] > [354073.738374] commit_tail+0x67/0x70 [drm_kms_helper] > [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] > [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] > [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] > [354073.738402] __setplane_atomic+0xd3/0x120 [drm] > [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] > [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] > [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [354073.738432] dr...

...lper] > [354073.738371] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] > [354073.738374] commit_tail+0x67/0x70 [drm_kms_helper] > [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] > [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] > [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] > [354073.738402] __setplane_atomic+0xd3/0x120 [drm] > [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] > [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] > [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] > [354073.738432] dr...

...em_cache_alloc_trace+0xf1/0x280 (mm/slub.c:2739) nv50_head_atomic_duplicate_state+0x72/0x700 [nouveau] (drivers/gpu/drm/nouveau/nv50_display.c:2323) drm_atomic_get_crtc_state+0x1be/0x3d0 (drivers/gpu/drm/drm_atomic.c:264) drm_atomic_get_plane_state+0x2a5/0x3e0 (drivers/gpu/drm/drm_atomic.c:679) drm_atomic_helper_update_plane+0x10b/0x3b0 (drivers/gpu/drm/drm_atomic_helper.c:2089) __setplane_internal+0x417/0x950 (drivers/gpu/drm/drm_plane.c:457) drm_mode_cursor_universal+0x397/0xb30 (drivers/gpu/drm/drm_plane.c:599) drm_mode_cursor_common+0x173/0x750 (drivers/gpu/drm/drm_plane.c:675) drm_mode_cursor_ioctl+0x90/0xb0 (...

...gt; + if (drm_core_check_feature(DRIVER_ATOMIC)) > + ret = drm_mode_cursor_atomic(crtc, req, file_priv); > + else > + ret = drm_mode_cursor_universal(crtc, req, file_priv); > goto out; > drm_mode_cursor_atomic would simply be a fusing of > drm_mode_cursor_universal + drm_atomic_helper_update_plane (dump all the > intermediate variables and store directly in the plane state), with the > addition of also storing hot_x/y into the plane state. Hmm, that'll either make drm_mode_cursor_atomic a big cut+pasted function, or need quite some refactoring to move common code into function...

...bo); +} + +static const struct drm_plane_helper_funcs bochs_plane_helper_funcs = { + .atomic_update = bochs_plane_atomic_update, + .prepare_fb = bochs_plane_prepare_fb, + .cleanup_fb = bochs_plane_cleanup_fb, +}; + +static const struct drm_plane_funcs bochs_plane_funcs = { + .update_plane = drm_atomic_helper_update_plane, + .disable_plane = drm_atomic_helper_disable_plane, + .destroy = drm_primary_helper_destroy, + .reset = drm_atomic_helper_plane_reset, + .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, + .atomic_destroy_state = drm_atomic_helper_pla...

...38371] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] > > [354073.738374] commit_tail+0x67/0x70 [drm_kms_helper] > > [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] > > [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] > > [354073.738394] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] > > [354073.738402] __setplane_atomic+0xd3/0x120 [drm] > > [354073.738410] drm_mode_cursor_universal+0x142/0x270 [drm] > > [354073.738418] drm_mode_cursor_common+0xcb/0x220 [drm] > > [354073.738425] ? drm_mode_cursor_ioctl+0x60/0x60 [drm] >...

...0000 ES: 0000 CR0: 0000000080050033 [ 211.555448] CR2: 0000000000000021 CR3: 0000000419549000 CR4: 00000000001406f0 [ 211.555470] Call Trace: [ 211.555514] drm_atomic_helper_wait_for_fences+0x48/0x130 [drm_kms_helper] [ 211.555607] nv50_disp_atomic_commit+0x18e/0x290 [nouveau] [ 211.555643] drm_atomic_helper_update_plane+0xeb/0x150 [drm_kms_helper] [ 211.555690] __setplane_internal+0x1d9/0x2a0 [drm] [ 211.555718] ? enqueue_entity+0x110/0x6d0 [ 211.555754] drm_mode_cursor_universal+0x10b/0x1e0 [drm] [ 211.555792] drm_mode_cursor_common+0x80/0x170 [drm] [ 211.555829] drm_mode_cursor_ioctl+0x44/0x50 [drm] [...