search for: drm_atomic_helper_duplicate_state

...to be happening because we destroy the VCPI allocations > when disabling all connected displays while suspending, and those VCPI > allocations don't get restored on resume due to failing to restore the > atomic state. > > So, fix this by introducing the suspending option to > drm_atomic_helper_duplicate_state() and use that to indicate in the > atomic state that it's being used for suspending or resuming the system, > and thus needs to be fixed up by the driver. We can then use the new > state->duplicated hook to tell update_connector_routing() in > drm_atomic_check_modeset() to allow...

...00000009fd2899a This appears to be happening because we destroy the VCPI allocations when disabling all connected displays while suspending, and those VCPI allocations don't get restored on resume due to failing to restore the atomic state. So, fix this by introducing the suspending option to drm_atomic_helper_duplicate_state() and use that to indicate in the atomic state that it's being used for suspending or resuming the system, and thus needs to be fixed up by the driver. We can then use the new state->duplicated hook to tell update_connector_routing() in drm_atomic_check_modeset() to allow for modesets on unr...

...00000009fd2899a This appears to be happening because we destroy the VCPI allocations when disabling all connected displays while suspending, and those VCPI allocations don't get restored on resume due to failing to restore the atomic state. So, fix this by introducing the suspending option to drm_atomic_helper_duplicate_state() and use that to indicate in the atomic state that it's being used for suspending or resuming the system, and thus needs to be fixed up by the driver. We can then use the new state->duplicated hook to tell update_connector_routing() in drm_atomic_check_modeset() to allow for modesets on unr...

...troy the VCPI allocations > > when disabling all connected displays while suspending, and those VCPI > > allocations don't get restored on resume due to failing to restore the > > atomic state. > > > > So, fix this by introducing the suspending option to > > drm_atomic_helper_duplicate_state() and use that to indicate in the > > atomic state that it's being used for suspending or resuming the system, > > and thus needs to be fixed up by the driver. We can then use the new > > state->duplicated hook to tell update_connector_routing() in > > drm_atomic_chec...

This fixes the extra issues I discovered upstream after the introduction of my rework of the atomic VCPI helpers that occur during suspend/resume. This time around, we use a slightly different but much less complicated approach for fixing said issues. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (4): drm/dp_mst: Fix unbalanced malloc ref in drm_dp_mst_deallocate_vcpi()

This fixes the extra issues I discovered upstream after the introduction of my rework of the atomic VCPI helpers that occur during suspend/resume. This time around, we use a slightly different but much less complicated approach for fixing said issues. Cc: Daniel Vetter <daniel at ffwll.ch> Lyude Paul (4): drm/dp_mst: Fix unbalanced malloc ref in drm_dp_mst_deallocate_vcpi()

...ic_suspend(struct drm_device *dev) -{ - struct drm_modeset_acquire_ctx ctx; - struct drm_atomic_state *state; - int ret; - - drm_modeset_acquire_init(&ctx, 0); - -retry: - ret = drm_modeset_lock_all_ctx(dev, &ctx); - if (ret < 0) { - state = ERR_PTR(ret); - goto unlock; - } - - state = drm_atomic_helper_duplicate_state(dev, &ctx); - if (IS_ERR(state)) - goto unlock; - - ret = nouveau_atomic_disable(dev, &ctx); - if (ret < 0) { - drm_atomic_state_put(state); - state = ERR_PTR(ret); - goto unlock; - } - -unlock: - if (PTR_ERR(state) == -EDEADLK) { - drm_modeset_backoff(&ctx); - goto retry; - }...

...ic_suspend(struct drm_device *dev) -{ - struct drm_modeset_acquire_ctx ctx; - struct drm_atomic_state *state; - int ret; - - drm_modeset_acquire_init(&ctx, 0); - -retry: - ret = drm_modeset_lock_all_ctx(dev, &ctx); - if (ret < 0) { - state = ERR_PTR(ret); - goto unlock; - } - - state = drm_atomic_helper_duplicate_state(dev, &ctx); - if (IS_ERR(state)) - goto unlock; - - ret = nouveau_atomic_disable(dev, &ctx); - if (ret < 0) { - drm_atomic_state_put(state); - state = ERR_PTR(ret); - goto unlock; - } - -unlock: - if (PTR_ERR(state) == -EDEADLK) { - drm_modeset_backoff(&ctx); - goto retry; - }...

...e_ctx ctx; > - struct drm_atomic_state *state; > - int ret; > - > - drm_modeset_acquire_init(&ctx, 0); > - > -retry: > - ret = drm_modeset_lock_all_ctx(dev, &ctx); > - if (ret < 0) { > - state = ERR_PTR(ret); > - goto unlock; > - } > - > - state = drm_atomic_helper_duplicate_state(dev, &ctx); > - if (IS_ERR(state)) > - goto unlock; > - > - ret = nouveau_atomic_disable(dev, &ctx); > - if (ret < 0) { > - drm_atomic_state_put(state); > - state = ERR_PTR(ret); > - goto unlock; > - } > - > -unlock: > - if (PTR_ERR(state) == -EDEA...