search for: drm_atomic_helper_commit_planes

virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index 4e192aa..75ec172 100644...

virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and because of that it must be called for disabled planes too. Ask drm_atomic_helper_commit_planes to do that. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c index 4e192aa..75ec172 100644...

...lowpath+0x16/0x20 [354073.738347] ww_mutex_lock+0x34/0x50 [354073.738352] ttm_eu_reserve_buffers+0x1f9/0x2e0 [ttm] [354073.738356] qxl_release_reserve_list+0x67/0x150 [qxl] [354073.738358] ? qxl_bo_pin+0xaa/0x190 [qxl] [354073.738359] qxl_cursor_atomic_update+0x1b0/0x2e0 [qxl] [354073.738367] drm_atomic_helper_commit_planes+0xb9/0x220 [drm_kms_helper] [354073.738371] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] [354073.738374] commit_tail+0x67/0x70 [drm_kms_helper] [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] [354073.738394] dr...

...lowpath+0x16/0x20 [354073.738347] ww_mutex_lock+0x34/0x50 [354073.738352] ttm_eu_reserve_buffers+0x1f9/0x2e0 [ttm] [354073.738356] qxl_release_reserve_list+0x67/0x150 [qxl] [354073.738358] ? qxl_bo_pin+0xaa/0x190 [qxl] [354073.738359] qxl_cursor_atomic_update+0x1b0/0x2e0 [qxl] [354073.738367] drm_atomic_helper_commit_planes+0xb9/0x220 [drm_kms_helper] [354073.738371] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] [354073.738374] commit_tail+0x67/0x70 [drm_kms_helper] [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] [354073.738390] drm_atomic_commit+0x4a/0x50 [drm] [354073.738394] dr...

On 05.09.19 10:14, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 09:00:10PM +0300, Jaak Ristioja wrote: >> Hello! >> >> I'm writing to report a crash in the QXL / DRM code in the Linux kernel. >> I originally filed the issue on LaunchPad and more details can be found >> there, although I doubt whether these details are useful. > > Any change with kernel

On 05.09.19 10:14, Gerd Hoffmann wrote: > On Tue, Aug 06, 2019 at 09:00:10PM +0300, Jaak Ristioja wrote: >> Hello! >> >> I'm writing to report a crash in the QXL / DRM code in the Linux kernel. >> I originally filed the issue on LaunchPad and more details can be found >> there, although I doubt whether these details are useful. > > Any change with kernel

...(struct drm_device *dev, return &virtio_gpu_fb->base; } -static void vgdev_atomic_commit_tail(struct drm_atomic_state *state) -{ - struct drm_device *dev = state->dev; - - drm_atomic_helper_commit_modeset_disables(dev, state); - drm_atomic_helper_commit_modeset_enables(dev, state); - drm_atomic_helper_commit_planes(dev, state, 0); - - drm_atomic_helper_fake_vblank(state); - drm_atomic_helper_commit_hw_done(state); - - drm_atomic_helper_wait_for_vblanks(dev, state); - drm_atomic_helper_cleanup_planes(dev, state); -} - -static const struct drm_mode_config_helper_funcs virtio_mode_config_helpers = { - .atomic_co...

...(struct drm_device *dev, return &virtio_gpu_fb->base; } -static void vgdev_atomic_commit_tail(struct drm_atomic_state *state) -{ - struct drm_device *dev = state->dev; - - drm_atomic_helper_commit_modeset_disables(dev, state); - drm_atomic_helper_commit_modeset_enables(dev, state); - drm_atomic_helper_commit_planes(dev, state, 0); - - drm_atomic_helper_fake_vblank(state); - drm_atomic_helper_commit_hw_done(state); - - drm_atomic_helper_wait_for_vblanks(dev, state); - drm_atomic_helper_cleanup_planes(dev, state); -} - -static const struct drm_mode_config_helper_funcs virtio_mode_config_helpers = { - .atomic_co...

...x70 schedule_preempt_disabled+0xe/0x10 __ww_mutex_lock.isra.11+0x3e0/0x750 __ww_mutex_lock_slowpath+0x16/0x20 ww_mutex_lock+0x34/0x50 ttm_eu_reserve_buffers+0x1f9/0x2e0 [ttm] qxl_release_reserve_list+0x67/0x150 [qxl] ? qxl_bo_pin+0x11d/0x200 [qxl] qxl_cursor_atomic_update+0x1b0/0x2e0 [qxl] drm_atomic_helper_commit_planes+0xb9/0x220 [drm_kms_helper] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] commit_tail+0x67/0x70 [drm_kms_helper] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] drm_atomic_commit+0x4a/0x50 [drm] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] __setplane_atomic+0xd6...

...x70 schedule_preempt_disabled+0xe/0x10 __ww_mutex_lock.isra.11+0x3e0/0x750 __ww_mutex_lock_slowpath+0x16/0x20 ww_mutex_lock+0x34/0x50 ttm_eu_reserve_buffers+0x1f9/0x2e0 [ttm] qxl_release_reserve_list+0x67/0x150 [qxl] ? qxl_bo_pin+0x11d/0x200 [qxl] qxl_cursor_atomic_update+0x1b0/0x2e0 [qxl] drm_atomic_helper_commit_planes+0xb9/0x220 [drm_kms_helper] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] commit_tail+0x67/0x70 [drm_kms_helper] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] drm_atomic_commit+0x4a/0x50 [drm] drm_atomic_helper_update_plane+0xe9/0x100 [drm_kms_helper] __setplane_atomic+0xd6...

...ke for rockchip. I have a gut feeling that should also take care of your troubles. Using the old crtc is definitely not what you want. Another option is that virtio isn't happy about bashing in plane state for disabled crtc. Again helpers have you covered, look at the active_only parameter for drm_atomic_helper_commit_planes(). Aside, if you wonder why these defaults: They match what the crtc helpers are doing, but they are a bit surprising indeed. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

...ke for rockchip. I have a gut feeling that should also take care of your troubles. Using the old crtc is definitely not what you want. Another option is that virtio isn't happy about bashing in plane state for disabled crtc. Again helpers have you covered, look at the active_only parameter for drm_atomic_helper_commit_planes(). Aside, if you wonder why these defaults: They match what the crtc helpers are doing, but they are a bit surprising indeed. Cheers, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

...array_add_fence (linux/drivers/gpu/drm/virtio/virtgpu_gem.c:230 (discriminator 3)) [ 37.720925] virtio_gpu_queue_fenced_ctrl_buffer (linux/drivers/gpu/drm/virtio/virtgpu_vq.c:391) [...] [ 37.724065] virtio_gpu_cursor_plane_update (linux/drivers/gpu/drm/virtio/virtgpu_plane.c:240) [ 37.724656] drm_atomic_helper_commit_planes (linux/drivers/gpu/drm/drm_atomic_helper.c:2444 (discriminator 2)) [ 37.725324] vgdev_atomic_commit_tail (linux/drivers/gpu/drm/virtio/virtgpu_display.c:332) [ 37.725835] commit_tail (linux/drivers/gpu/drm/drm_atomic_helper.c:1612) [ 37.726204] drm_atomic_helper_commit (linux/drivers/gpu/drm/...

Do modesets first, then call drm_atomic_helper_commit_planes with active_only = true. That way the outputs doesn't get disabled temporarly on atomic commits. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_display.c | 22 +++++++++++++++++++++- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + 2 files change...

.../virtgpu_display.c index ecf4ba7cc32b..7b0f0643bb2d 100644 --- a/drivers/gpu/drm/virtio/virtgpu_display.c +++ b/drivers/gpu/drm/virtio/virtgpu_display.c @@ -324,6 +324,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state) drm_atomic_helper_commit_modeset_enables(dev, state); drm_atomic_helper_commit_planes(dev, state, 0); + drm_atomic_helper_fake_vblank(state); drm_atomic_helper_commit_hw_done(state); drm_atomic_helper_wait_for_vblanks(dev, state); -- 2.18.1

Do modesets first, then call drm_atomic_helper_commit_planes with active_only = true. That way the outputs doesn't get disabled temporarly on atomic commits. Signed-off-by: Gerd Hoffmann <kraxel at redhat.com> --- drivers/gpu/drm/virtio/virtgpu_display.c | 22 +++++++++++++++++++++- drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + 2 files change...

...ystemd" > #0 [6beef4c0] __schedule at a55d60 > #1 [6beef530] schedule at a563f2 > #2 [6beef548] virtio_gpu_queue_ctrl_buffer_locked at 7ea708 > #3 [6beef650] virtio_gpu_queue_ctrl_buffer at 7ea830 > #4 [6beef680] virtio_gpu_primary_plane_update at 7ed5ee > #5 [6beef710] drm_atomic_helper_commit_planes at 7a2b46 > #6 [6beef760] vgdev_atomic_commit_tail at 7e9dbc > #7 [6beef790] commit_tail at 7a7126 > #8 [6beef7c0] drm_atomic_helper_commit at 7a73fe > #9 [6beef800] restore_fbdev_mode_atomic at 7aa38a > #10 [6beef8a0] drm_fb_helper_pan_display at 7ab7aa > #11 [6beef8f0] fb_pa...

...k+0x38/0x90 [124212.551352] ttm_eu_reserve_buffers+0x1cc/0x2f0 [ttm] [124212.551371] qxl_release_reserve_list+0x6d/0x150 [qxl] [124212.551373] ? qxl_bo_pin+0xf4/0x190 [qxl] [124212.551375] qxl_cursor_atomic_update+0x1ab/0x2e0 [qxl] [124212.551376] ? qxl_bo_pin+0xf4/0x190 [qxl] [124212.551384] drm_atomic_helper_commit_planes+0xd5/0x220 [drm_kms_helper] [124212.551388] drm_atomic_helper_commit_tail+0x2c/0x70 [drm_kms_helper] [124212.551392] commit_tail+0x68/0x70 [drm_kms_helper] [124212.551395] drm_atomic_helper_commit+0x118/0x120 [drm_kms_helper] [124212.551407] drm_atomic_commit+0x4a/0x50 [drm] [124212.551411] dr...

...2] ttm_eu_reserve_buffers+0x1cc/0x2f0 [ttm] > [124212.551371] qxl_release_reserve_list+0x6d/0x150 [qxl] > [124212.551373] ? qxl_bo_pin+0xf4/0x190 [qxl] > [124212.551375] qxl_cursor_atomic_update+0x1ab/0x2e0 [qxl] > [124212.551376] ? qxl_bo_pin+0xf4/0x190 [qxl] > [124212.551384] drm_atomic_helper_commit_planes+0xd5/0x220 [drm_kms_helper] > [124212.551388] drm_atomic_helper_commit_tail+0x2c/0x70 [drm_kms_helper] > [124212.551392] commit_tail+0x68/0x70 [drm_kms_helper] > [124212.551395] drm_atomic_helper_commit+0x118/0x120 [drm_kms_helper] > [124212.551407] drm_atomic_commit+0x4a/0x50 [drm]...

....738347] ww_mutex_lock+0x34/0x50 > [354073.738352] ttm_eu_reserve_buffers+0x1f9/0x2e0 [ttm] > [354073.738356] qxl_release_reserve_list+0x67/0x150 [qxl] > [354073.738358] ? qxl_bo_pin+0xaa/0x190 [qxl] > [354073.738359] qxl_cursor_atomic_update+0x1b0/0x2e0 [qxl] > [354073.738367] drm_atomic_helper_commit_planes+0xb9/0x220 [drm_kms_helper] > [354073.738371] drm_atomic_helper_commit_tail+0x2b/0x70 [drm_kms_helper] > [354073.738374] commit_tail+0x67/0x70 [drm_kms_helper] > [354073.738378] drm_atomic_helper_commit+0x113/0x120 [drm_kms_helper] > [354073.738390] drm_atomic_commit+0x4a/0x50 [drm]...