search for: drive_protocol

...unix) { + error (g, _("spdk: only unix transport is supported")); + return NULL; + } + + return create_drive_non_file (g, data); +} + +bool +guestfs_int_has_spdk_drive (guestfs_h *g) +{ + size_t i; + struct drive *drv; + ITER_DRIVES(g, i, drv) { + if (drv->src.protocol == drive_protocol_spdk) { + return true; + } + } + return false; +} + /** * Create the special F</dev/null> drive. * @@ -494,6 +533,7 @@ guestfs_int_drive_protocol_to_string (enum drive_protocol protocol) case drive_protocol_sheepdog: return "sheepdog"; case drive_protocol_ssh: r...

Note this patch requires a non-upstream qemu patch that I've been experimenting with. See qemu-devel list. Rich.

NB: This requires a qemu patch by Eduardo which is currently awaiting review: https://www.mail-archive.com/qemu-devel@nongnu.org/msg422959.html So not to be applied yet unless that qemu change goes upstream. Rich.

On Tuesday 11 March 2014 23:13:46 Richard W.M. Jones wrote: > diff --git a/src/drives.c b/src/drives.c > index 2c85b52..68e37f7 100644 > --- a/src/drives.c > +++ b/src/drives.c > @@ -115,7 +115,8 @@ static struct drive * > create_drive_file (guestfs_h *g, const char *path, > bool readonly, const char *format, > const char *iface,

...g, char **code, char **vars) +{ + *code = *vars = NULL; + return 0; +} + +#endif /* !__aarch64__ */ diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h index 58f657c..d438be3 100644 --- a/src/guestfs-internal.h +++ b/src/guestfs-internal.h @@ -752,6 +752,7 @@ extern const char *guestfs___drive_protocol_to_string (enum drive_protocol proto /* appliance.c */ extern int guestfs___build_appliance (guestfs_h *g, char **kernel, char **dtb, char **initrd, char **appliance); +extern int guestfs___get_uefi (guestfs_h *g, char **code, char **vars); /* launch.c */ extern int64_t guestfs___timeval_di...

...donly, const char *format, + const char *iface, const char *name, + const char *disk_label, + bool use_cache_none) { struct drive *drv = safe_malloc (g, sizeof (struct drive)); - drv->path = safe_strdup (g, path); + drv->protocol = drive_protocol_file; + drv->u.path = safe_strdup (g, path); + drv->readonly = readonly; drv->format = format ? safe_strdup (g, format) : NULL; drv->iface = iface ? safe_strdup (g, iface) : NULL; drv->name = name ? safe_strdup (g, name) : NULL; drv->disk_label = disk_label ? safe_...

These patches contain the beginnings of discard (a.k.a. trim or unmap) support. This will allow us to change virt-sparsify to work on disk images in-place (instead of using slow & inefficient copying). The approach used is to add an optional 'discard' parameter to add-drive. It has 3 possible settings: - 'disable' : the default, no discard is done - 'besteffort' :

This is only lightly tested. In particularly I only tested that the non-secure-boot path still works. I didn't test it on RHEL 7.3 yet because I haven't got enough free disk space for these giant source *.ova files :-( Will try to give that a go later. Rich.

This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. This is now working, after fixing the rather stupid bug in fstrim. I've pushed the ones which were ACKed previously + the fstrim fix. Rich.

QEMU upstream has broken snapshot=on ... again. These two patches stop using it entirely. Instead we run 'qemu-img create' to create overlay disks as required. Note that the libvirt and UML backends were already doing this: The libvirt backend because <transient/> has never worked, and the UML backend was running uml_mkcow because the UML-equivalent syntax of snapshot=on was

...= data->cachemode ? safe_strdup (g, data->cachemode) : NULL; drv->discard = data->discard; drv->copyonread = data->copyonread; + drv->blocksize = data->blocksize; if (data->readonly) { if (create_overlay (g, drv) == -1) { @@ -501,8 +504,13 @@ guestfs_int_drive_protocol_to_string (enum drive_protocol protocol) static char * drive_to_string (guestfs_h *g, const struct drive *drv) { + CLEANUP_FREE char *s_blocksize = NULL; + + if (drv->blocksize) + s_blocksize = safe_asprintf (g, "%d", drv->blocksize); + return safe_asprintf - (g, &quot...

This series improves ceph rbd support in libguestfs. It uses the servers list, adds support for a custom username, and starts to add support for custom secret.

...= data->cachemode ? safe_strdup (g, data->cachemode) : NULL; drv->discard = data->discard; drv->copyonread = data->copyonread; + drv->blocksize = data->blocksize; if (data->readonly) { if (create_overlay (g, drv) == -1) { @@ -501,8 +504,13 @@ guestfs_int_drive_protocol_to_string (enum drive_protocol protocol) static char * drive_to_string (guestfs_h *g, const struct drive *drv) { + CLEANUP_FREE char *s_blocksize = NULL; + + if (drv->blocksize) + s_blocksize = safe_asprintf (g, "%d", drv->blocksize); + return safe_asprintf - (g, &quot...

First version was posted here: https://www.redhat.com/archives/libguestfs/2016-August/thread.html#00100 This is semantically the same as the first version. However I've split the patch up into two parts. In the first part, I factor out the UEFI paths so now they are created by the generator and written in the library and v2v/ directory directly, instead of the complex business of having a C

This still isn't working at the moment. See: http://marc.info/?t=139457409300003&r=1&w=2 This set of patches: - Adds new APIs to support discard in libguestfs. - Adds discard support to virt-format. - Adds discard support to virt-sysprep. - Implements virt-sparsify --in-place. Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.