search for: dri_screen

From: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4016871..c02ee61 100644 --- a/configure.ac +++ b/configure.ac @@ -73,7 +73,7 @@ LIBDRM_RADEON_REQUIRED=2.4.56 LIBDRM_AMDGPU_REQUIRED=2.4.63 LIBDRM_INTEL_REQUIRED=2.4.61

From: Ben Skeggs <bskeggs at redhat.com> v2. forgot bump for non-gallium driver Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index b6680d0..965c6f7 100644 --- a/configure.ac +++ b/configure.ac @@ -72,8 +72,8 @@ LIBDRM_REQUIRED=2.4.60

...uVeau driver bug. I will attach both Mozilla Firefox valgrind log and glxtest one. But there is a common part : Invalid read of size 4 at 0x8DBA0BE: nouveau_fence_wait (nouveau_fence.c:205) by 0x8E4AFF4: nv50_screen_destroy (nv50_screen.c:293) by 0x8DAACDE: dri_destroy_screen_helper (dri_screen.c:378) by 0x8DAAD74: dri_destroy_screen (dri_screen.c:388) by 0x8AB13D6: driDestroyScreen (dri_util.c:234) by 0x69A06C1: dri2DestroyScreen (dri2_glx.c:712) by 0x697CFE5: FreeScreenConfigs.isra.3 (glxext.c:208) by 0x697D064: glx_display_free (glxext.c:231) by 0x697D164: __glX...

...g symbols for Mozilla Firefox trunk code. And log for mozilla Firefox trunk code. Always the same beginning : Invalid read of size 4 at 0x161590BE: nouveau_fence_wait (nouveau_fence.c:205) by 0x161E9FF4: nv50_screen_destroy (nv50_screen.c:293) by 0x16149CDE: dri_destroy_screen_helper (dri_screen.c:378) by 0x16149D74: dri_destroy_screen (dri_screen.c:388) by 0x15E503D6: driDestroyScreen (dri_util.c:234) by 0x1256D6C1: dri2DestroyScreen (dri2_glx.c:712) by 0x12549FE5: FreeScreenConfigs.isra.3 (glxext.c:208) by 0x1254A064: glx_display_free (glxext.c:231) by 0x1254A164:...

From: Ben Skeggs <bskeggs at redhat.com> Signed-off-by: Ben Skeggs <bskeggs at redhat.com> --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 4016871..c02ee61 100644 --- a/configure.ac +++ b/configure.ac @@ -73,7 +73,7 @@ LIBDRM_RADEON_REQUIRED=2.4.56 LIBDRM_AMDGPU_REQUIRED=2.4.63 LIBDRM_INTEL_REQUIRED=2.4.61

...found)...done. (gdb) r Starting program: /usr/bin/glxinfo [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/i386-linux-gnu/libthread_db.so.1". name of display: :0.0 Program received signal SIGSEGV, Segmentation fault. 0xb79ff07d in nouveau_init_screen2 (dri_screen=0x806d1f8) at ../../../../../../../src/mesa/drivers/dri/nouveau/nouveau_screen.c:105 105 ../../../../../../../src/mesa/drivers/dri/nouveau/nouveau_screen.c: No such file or directory. (gdb) bt #0 0xb79ff07d in nouveau_init_screen2 (dri_screen=0x806d1f8) at ../../../../../../../src/mesa/...

...n 32 bit machine. The build dies with: CC nouveau_surface.lo nouveau_screen.c: In function ‘nouveau_init_screen2’: nouveau_screen.c:105:8: error: implicit declaration of function ‘nouveau_drm_new’; did you mean ‘nouveau_bo_new’? [-Werror=implicit-function-declaration] ret = nouveau_drm_new(dri_screen->fd, &screen->drm); ^~~~~~~~~~~~~~~ nouveau_bo_new nouveau_screen.c:111:8: error: implicit declaration of function ‘nouveau_device_new’; did you mean ‘nouveau_device_del’? [-Werror=implicit-function-declaration] ret = nouveau_device_new(&screen->drm->client, NV...

...ULL, diff --git a/src/mesa/drivers/dri/nouveau/nouveau_screen.c b/src/mesa/drivers/dri/nouveau/nouveau_screen.c index 1a74ae2..6f61f66 100644 --- a/src/mesa/drivers/dri/nouveau/nouveau_screen.c +++ b/src/mesa/drivers/dri/nouveau/nouveau_screen.c @@ -108,8 +108,6 @@ nouveau_init_screen2(__DRIscreen *dri_screen) goto fail; } - screen->drm->nvif = false; - ret = nouveau_device_new(&screen->drm->client, NV_DEVICE, &(struct nv_device_v0) { .device = ~0ULL, -- 2.6.3

...ULL, diff --git a/src/mesa/drivers/dri/nouveau/nouveau_screen.c b/src/mesa/drivers/dri/nouveau/nouveau_screen.c index 6f61f66..1a74ae2 100644 --- a/src/mesa/drivers/dri/nouveau/nouveau_screen.c +++ b/src/mesa/drivers/dri/nouveau/nouveau_screen.c @@ -108,6 +108,8 @@ nouveau_init_screen2(__DRIscreen *dri_screen) goto fail; } + screen->drm->nvif = false; + ret = nouveau_device_new(&screen->drm->client, NV_DEVICE, &(struct nv_device_v0) { .device = ~0ULL, -- 2.4.10

...kware. I've been doing this for a long time. My build fails with: CC nouveau_screen.lo nouveau_screen.c: In function ‘nouveau_init_screen2’: nouveau_screen.c:105:8: error: implicit declaration of function ‘nouveau_drm_new’ [-Werror=implicit-function-declaration] ret = nouveau_drm_new(dri_screen->fd, &screen->drm); ^~~~~~~~~~~~~~~ nouveau_screen.c:111:8: error: implicit declaration of function ‘nouveau_device_new’ [-Werror=implicit-function-declaration] ret = nouveau_device_new(&screen->drm->client, NV_DEVICE, ^~~~~~~~~~~~~~~~~~ nouveau_screen.c:111:39...

...all the >> same places: >> >> https://github.com/imirkin/mesa/commits/30bpp >> > > Wrt. mesa, those patches are now in master and i think we have a bit of a > problem under X11+GLX: > > https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/dri/dri_screen.c#n108 > > dri_fill_in_modes() defines MESA_FORMAT_R10G10B10A2_UNORM, > MESA_FORMAT_R10G10B10X2_UNORM at the top inbetween the BGRX/A formats > ignoring the instructions that > "/* The 32-bit RGBA format must not precede the 32-bit BGRA format. > * Likewise for RGBX and BGR...

...t;>> >>> https://github.com/imirkin/mesa/commits/30bpp >>> >> >> Wrt. mesa, those patches are now in master and i think we have a bit of a >> problem under X11+GLX: >> >> https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/dri/dri_screen.c#n108 >> >> dri_fill_in_modes() defines MESA_FORMAT_R10G10B10A2_UNORM, >> MESA_FORMAT_R10G10B10X2_UNORM at the top inbetween the BGRX/A formats >> ignoring the instructions that >> "/* The 32-bit RGBA format must not precede the 32-bit BGRA format. >> *...

...RGB, so I've piped XBGR through all the > same places: > > https://github.com/imirkin/mesa/commits/30bpp > Wrt. mesa, those patches are now in master and i think we have a bit of a problem under X11+GLX: https://cgit.freedesktop.org/mesa/mesa/tree/src/gallium/state_trackers/dri/dri_screen.c#n108 dri_fill_in_modes() defines MESA_FORMAT_R10G10B10A2_UNORM, MESA_FORMAT_R10G10B10X2_UNORM at the top inbetween the BGRX/A formats ignoring the instructions that "/* The 32-bit RGBA format must not precede the 32-bit BGRA format. * Likewise for RGBX and BGRX. Otherwise, the GLX cli...

In case anyone's curious about 30bpp framebuffer support, here's the current status: Kernel: Ben and I have switched the code to using a 256-based LUT for Kepler+, and I've also written a patch to cause the addfb ioctl to use the proper format. You can pick this up at: https://github.com/skeggsb/linux/commits/linux-4.16 (note the branch!)

...ws=<value optimized out>, dev=<value optimized out>) at nv50_screen.c:312 #9 0x00007fc5c71e2ef6 in nouveau_drm_create_screen (api=0x7fc5c7634f20, fd=<value optimized out>, arg=0x7fff40065e80) at nouveau_drm_api.c:108 #10 0x00007fc5c71e1188 in dri_init_screen2 (sPriv=0x117b1f0) at dri_screen.c:304 #11 0x00007fc5c71de3e9 in dri2CreateNewScreen (scrn=<value optimized out>, fd=<value optimized out>, extensions=<value optimized out>, driver_configs=0x7fff40065f60, data=<value optimized out>) at ../../../../../../src/mesa/drivers/dri/common/dri_util.c:802 #12 0x0...