search for: dp_set_power

...onnector(nv_encoder, state); + struct drm_dp_aux *aux = &nv_connector->aux; + u8 pwr; nv_encoder->crtc = NULL; - if (nv_crtc) { - struct drm_dp_aux *aux = &nv_connector->aux; - u8 pwr; + if (nv_encoder->dcb->type == DCB_OUTPUT_DP) { + int ret = drm_dp_dpcd_readb(aux, DP_SET_POWER, &pwr); - if (nv_encoder->dcb->type == DCB_OUTPUT_DP) { - int ret = drm_dp_dpcd_readb(aux, DP_SET_POWER, &pwr); - - if (ret == 0) { - pwr &= ~DP_SET_POWER_MASK; - pwr |= DP_SET_POWER_D3; - drm_dp_dpcd_writeb(aux, DP_SET_POWER, pwr); - } + if (ret == 0) { + pw...

...;> commit, some by a later cleanup done by 9a7046d55f319b2dde5d2536cc2adb01ebdbe09e >> >> The code was updated to make it compatible with the current state of the driver. >> Here is how it now works. If the connection is DCB_OUTPUT_DP, call >> nouveau_dp_dpms() which does DP_SET_POWER and, if we are resuming, initiates >> DP link training by sending NV94_DISP_SOR_DP_TRAIN to have nv50_sor_mthd() >> call nouveau_dp_train(). > Thank you. This, as you've seen, would appear to solve the issue. > There's a little more to the power-down to be done however (s...

...d code was removed by the aforementioned commit, some by a later cleanup done by 9a7046d55f319b2dde5d2536cc2adb01ebdbe09e The code was updated to make it compatible with the current state of the driver. Here is how it now works. If the connection is DCB_OUTPUT_DP, call nouveau_dp_dpms() which does DP_SET_POWER and, if we are resuming, initiates DP link training by sending NV94_DISP_SOR_DP_TRAIN to have nv50_sor_mthd() call nouveau_dp_train(). Cc: Ben Skeggs <bskeggs at redhat.com> Cc: Dave Airlie <airlied at redhat.com> Signed-off-by: Sergei Antonov <saproj at gmail.com> --- drivers/g...

...e aforementioned > commit, some by a later cleanup done by 9a7046d55f319b2dde5d2536cc2adb01ebdbe09e > > The code was updated to make it compatible with the current state of the driver. > Here is how it now works. If the connection is DCB_OUTPUT_DP, call > nouveau_dp_dpms() which does DP_SET_POWER and, if we are resuming, initiates > DP link training by sending NV94_DISP_SOR_DP_TRAIN to have nv50_sor_mthd() > call nouveau_dp_train(). Thank you. This, as you've seen, would appear to solve the issue. There's a little more to the power-down to be done however (such as shutting do...

...;index); @@ -1633,8 +1640,6 @@ nv50_sor_atomic_disable(struct drm_encoder *encoder, struct drm_atomic_state *st struct drm_dp_aux *aux = &nv_connector->aux; u8 pwr; - nv_encoder->crtc = NULL; - if (nv_encoder->dcb->type == DCB_OUTPUT_DP) { int ret = drm_dp_dpcd_readb(aux, DP_SET_POWER, &pwr); @@ -1649,6 +1654,7 @@ nv50_sor_atomic_disable(struct drm_encoder *encoder, struct drm_atomic_state *st nv50_audio_disable(encoder, nv_crtc); nv50_hdmi_disable(&nv_encoder->base.base, nv_crtc); nv50_outp_release(nv_encoder); + nv_encoder->crtc = NULL; } static void...

Most of the reason I'm asking for an RFC here is because this code pulls a lot of code out of i915 and into shared DP helpers. Anyway-nouveau's HPD related code has been collecting dust for a while. Other then the occasional runtime PM related and MST related fixes, we're missing a lot of nice things that have been added to DRM since this was originally written. Additionally, the code

To start off: this patch series is less work to review then it looks - most (but not all) of the nouveau related work has already been reviewed elsewhere. Most of the reason I'm asking for an RFC here is because this code pulls a lot of code out of i915 and into shared DP helpers. Anyway-nouveau's HPD related code has been collecting dust for a while. Other then the occasional runtime PM

Most of the reason I'm asking for an RFC here is because this code pulls a lot of code out of i915 and into shared DP helpers. Anyway-nouveau's HPD related code has been collecting dust for a while. Other then the occasional runtime PM related and MST related fixes, we're missing a lot of nice things that have been added to DRM since this was originally written. Additionally, the code

To start off: this patch series is less work to review then it looks - most (but not all) of the nouveau related work has already been reviewed elsewhere. Most of the reason I'm asking for an RFC here is because this code pulls a lot of code out of i915 and into shared DP helpers. Anyway-nouveau's HPD related code has been collecting dust for a while. Other then the occasional runtime PM