search for: domain_exists

https://bugzilla.redhat.com/show_bug.cgi?id=889082

...rt hypervisor capabilities: %s"), - err->message); - virConnectClose (conn); - caml_invalid_argument (errmsg); - } - - capabilitiesv = caml_copy_string (capabilities); - free (capabilities); - - virConnectClose (conn); - - CAMLreturn (capabilitiesv); -} - -value -v2v_domain_exists (value connv, value domnamev) -{ - CAMLparam2 (connv, domnamev); - const char *conn_uri = NULL; - const char *domname; - /* We have to assemble the error on the stack because a dynamic - * string couldn't be freed. - */ - char errmsg[ERROR_MESSAGE_LEN]; - virErrorPtr err; - virConnec...

...rt hypervisor capabilities: %s"), err->message); - virConnectClose (conn); caml_invalid_argument (errmsg); } capabilitiesv = caml_copy_string (capabilities); free (capabilities); - virConnectClose (conn); - CAMLreturn (capabilitiesv); } value -v2v_domain_exists (value connv, value domnamev) +v2v_libvirt_domain_exists (value connv, value domnamev) { CAMLparam2 (connv, domnamev); - const char *conn_uri = NULL; const char *domname; /* We have to assemble the error on the stack because a dynamic * string couldn't be freed. @@ -437,31 +453,8...

...error { message } -> error (f_"cannot get libvirt hypervisor capabilities: %s") @@ -96,7 +98,7 @@ class output_libvirt oc output_pool = object capabilities_doc <- Some doc; (* Does the domain already exist on the target? (RHBZ#889082) *) - if Libvirt_utils.domain_exists conn source.s_name then ( + if Libvirt_utils.domain_exists self#conn source.s_name then ( if source.s_hypervisor = Physical then (* virt-p2v user *) error (f_"a libvirt domain called ‘%s’ already exists on the target.\n\nIf using virt-p2v, select a different ‘Name’ in the ‘T...

.../input_libvirt_xen_ssh.ml | 2 +- v2v/v2v.ml | 12 ++++++++++++ 8 files changed, 72 insertions(+), 7 deletions(-) diff --git a/v2v/domainxml-c.c b/v2v/domainxml-c.c index 3b00cad..eb6deab 100644 --- a/v2v/domainxml-c.c +++ b/v2v/domainxml-c.c @@ -487,6 +487,43 @@ v2v_domain_exists (value connv, value domnamev) CAMLreturn (Val_bool (domain_exists)); } +/* XXX This function is stuffed here for convenience (accessing + * libvirt), not because it belongs logically with the rest of the + * functions in this file. + */ +value +v2v_libvirt_get_version (value unitv) +{ + CAML...

Hi, this series switches virt-2v to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not test all

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this is a mostly done attempt to switch to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not

Hi, this series switches virt-2v to ocaml-libvirt, embedding the latest version of it from git. This way, it is possible to improve the way v2v connects to libvirt for both input, and output modules, and interacts with libvirt (e.g. no more virsh calls needed in virt-v2v). As side effect, virt-v2v now requires libvirt, as keeping it optional would create too much burden. I could not test all

This patch is dependant on the previously submitted storage admin patch.

..._details_page(screen) + elif page == CONFIRM_PAGE: return self.get_confirm_page(screen) + return [] + + def validate_input(self, page, errors): + if page == VM_DETAILS_PAGE: + if len(self.__guest_name.value()) > 0: + if self.get_libvirt().domain_exists(self.__guest_name.value()): + errors.append("Guest name '%s' is already in use." % self.__guest_name.value()) + else: + return True + else: + errors.append("Guest name must be a string between 0 an...

This version of the patch includes feedback from jboggs at redhat.com, including fixes to the BuildRequires and Requires in the spec file.

This patch obsoletes any previous ones. This is an upstream candidate, so I'm looking for feedback so we can push this and start using it.

This version fixes a few bugs found by jboggs. It also includes some logging facilities that need to be fleshed out more.

This patch is ready for pushing upstream.

The previous patch was missing this file. Resending.

...just looking for some feedback on the direction I'm going. The code won't get all the way to the define stage since I'm in the middle of retrofitting it to use virtinst instead of a home spun node definition.

...nnot open libvirt connection '%s'"), conn_uri); + _("cannot open libvirt connection ‘%s’"), conn_uri); else snprintf (errmsg, sizeof errmsg, _("cannot open libvirt connection")); caml_invalid_argument (errmsg); @@ -449,7 +449,7 @@ v2v_domain_exists (value connv, value domnamev) if (conn == NULL) { if (conn_uri) snprintf (errmsg, sizeof errmsg, - _("cannot open libvirt connection '%s'"), conn_uri); + _("cannot open libvirt connection ‘%s’"), conn_uri); else sn...