search for: domain_class

Displaying 20 results from an estimated 21 matches for "domain_class".

2014 Sep 23
0
[PATCH 02/13] syntax-check: fix error_message_period check
...(* OpenStack only supports single image VMs, I think? *) let nr_targets = List.length targets in diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml index bb77787..cfdc76e 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhev.ml @@ -49,7 +49,7 @@ let rec mount_and_check_storage_domain verbose domain_class os = sprintf "mount %s:%s %s" (quote server) (quote export) (quote mp) in if verbose then printf "%s\n%!" cmd; if Sys.command cmd <> 0 then - error (f_"mount command failed, see earlier errors.\n\nThis probably means you didn't specify the ri...
2016 Dec 01
2
[PATCH] v2v: Rename RHEV to RHV throughout.
...ool_path "/rhev-apt.exe"; (* XXX *) diff --git a/v2v/output_rhev.ml b/v2v/output_rhv.ml similarity index 90% rename from v2v/output_rhev.ml rename to v2v/output_rhv.ml index 3280150..5ddcefa 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhv.ml @@ -66,7 +66,7 @@ and check_storage_domain domain_class os mp = let entries = try Sys.readdir mp with Sys_error msg -> - error (f_"could not read the %s specified by the '-os %s' parameter on the command line. Is it really an OVirt or RHEV-M %s? The original error is: %s") domain_class os domain_class msg in +...
2016 Dec 07
0
[PATCH v2] v2v: Rename RHEV to RHV throughout.
...ool_path "/rhev-apt.exe"; (* XXX *) diff --git a/v2v/output_rhev.ml b/v2v/output_rhv.ml similarity index 90% rename from v2v/output_rhev.ml rename to v2v/output_rhv.ml index 3280150..5ddcefa 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhv.ml @@ -66,7 +66,7 @@ and check_storage_domain domain_class os mp = let entries = try Sys.readdir mp with Sys_error msg -> - error (f_"could not read the %s specified by the '-os %s' parameter on the command line. Is it really an OVirt or RHEV-M %s? The original error is: %s") domain_class os domain_class msg in +...
2016 Dec 07
2
[PATCH v2] v2v: Rename RHEV to RHV throughout.
v2: - Fix virt-p2v messages too. Rich.
2015 May 15
0
[PATCH 3/4] ocaml tools: Use global variables to store trace (-x) and verbose (-v) flags.
...al files with a qemu script to start the guest locally. *) diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml index 911705e..365c35e 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhev.ml @@ -26,13 +26,13 @@ open Types open Utils open DOM -let rec mount_and_check_storage_domain verbose domain_class os = +let rec mount_and_check_storage_domain domain_class os = (* The user can either specify -os nfs:/export, or a local directory * which is assumed to be the already-mounted NFS export. *) match string_split ":/" os with | mp, "" ->...
2016 May 23
0
[PATCH 5/5] mllib: add a new run_command helper
...irt XML is still available in '%s'. Try running 'virsh define %s' yourself instead.") diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml index 971c1af..7daa727 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhev.ml @@ -43,15 +43,14 @@ let rec mount_and_check_storage_domain domain_class os = chmod mp 0o755; (* Try mounting it. *) - let cmd = - sprintf "mount %s:%s %s" (quote server) (quote export) (quote mp) in - if shell_command cmd <> 0 then + let cmd = [| "mount"; sprintf "%s:%s" server export; mp |] in + if run_c...
2016 May 23
7
[PATCH 1/5] mllib: make external_command echo the command executed
Add an optional parameter to disable this behaviour, so the Curl module in v2v won't print user-sensible data (like passwords). --- builder/checksums.ml | 1 - builder/downloader.ml | 1 - builder/sigchecker.ml | 1 - mllib/common_utils.ml | 4 +++- mllib/common_utils.mli | 7 +++++-- v2v/curl.ml | 2 +- 6 files changed, 9 insertions(+), 7 deletions(-) diff --git
2014 Sep 23
27
[PATCH 00/13] syntax-check
Hi Rich, This series includes patches to make `make syntax-check` pass. Some of the fix require change to maint.mk, but the file is not in git repo. Is it intended? Thanks! Hu Tao (13): syntax-check: dirty hack to pass bindtextdomain check syntax-check: fix error_message_period check syntax-check: fix makefile_at_at_check syntax-check: fix prohibit_assert_without_use check
2015 May 15
5
[PATCH 0/4] Only tell people to use -v -x when reporting bugs if they're not using those flags.
.. and a lot of refactoring. https://bugzilla.redhat.com/show_bug.cgi?id=1167623 Rich.
2015 May 15
6
[PATCH v2 0/4] Only tell people to use -v -x when reporting bugs if they're not using those flags.
https://bugzilla.redhat.com/show_bug.cgi?id=1167623
2020 Apr 06
0
[v2v PATCH 2/2] Consolidate handling of temporary files/dirs
...json" in let fd = descr_of_out_channel chan in (* Note that Tools_utils.run_command closes fd. diff --git a/v2v/output_rhv.ml b/v2v/output_rhv.ml index 49cc0381..49bfaaa8 100644 --- a/v2v/output_rhv.ml +++ b/v2v/output_rhv.ml @@ -40,7 +40,7 @@ let rec mount_and_check_storage_domain domain_class os = (* Create a mountpoint. Default mode is too restrictive for us * when we need to write into the directory as 36:36. *) - let mp = Mkdtemp.temp_dir "v2v." in + let mp = Mkdtemp.temp_dir ~base_dir:tmpdir "v2v." in chmod mp 0o755; (* Try mou...
2016 May 22
0
[PATCH 2/2] ocaml tools: Use a common debug function.
...doc_to_chan stderr doc; + eprintf "\n%!"; ); (* Define the domain in libvirt. *) diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml index b1c6850..6301d9a 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhev.ml @@ -45,14 +45,14 @@ let rec mount_and_check_storage_domain domain_class os = (* Try mounting it. *) let cmd = sprintf "mount %s:%s %s" (quote server) (quote export) (quote mp) in - if verbose () then printf "%s\n%!" cmd; + debug "%s" cmd; if Sys.command cmd <> 0 then error (f_"mount command fai...
2016 May 22
4
ocaml tools: Use a common debug function.
Add a Common_utils.debug function for printing messages only when in verbose mode. Rich.
2020 Apr 06
4
[v2v PATCH 1/2] v2v: nbdkit: change base dir for nbdkit sockets/pidfiles
Since this new temporary directory will contain UNIX sockets for communicating with nbdkit, then its path must not be too long. Use the existing directory that libguestfs exposes for this, i.e. sockdir. --- v2v/nbdkit.ml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/v2v/nbdkit.ml b/v2v/nbdkit.ml index 65317f9b..46b20c9d 100644 --- a/v2v/nbdkit.ml +++ b/v2v/nbdkit.ml
2015 Oct 06
0
[PATCH 5/5] mllib: Replace various ad hoc string_* functions with String.*
...format=%s,if=scsi,bus=0,unit=%d,media=disk" qemu_quoted_filename t.target_format i in diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml index d3f367e..aa0472f 100644 --- a/v2v/output_rhev.ml +++ b/v2v/output_rhev.ml @@ -30,7 +30,7 @@ let rec mount_and_check_storage_domain domain_class os = (* The user can either specify -os nfs:/export, or a local directory * which is assumed to be the already-mounted NFS export. *) - match string_split ":/" os with + match String.split ":/" os with | mp, "" -> (* Already m...
2017 Apr 04
1
[PATCH] Use Unicode single quotes ‘’ in place of short single quoted strings throughout.
...L is still available in ‘%s’. Try running ‘virsh define %s’ yourself instead.") tmpfile tmpfile ); end diff --git a/v2v/output_rhv.ml b/v2v/output_rhv.ml index f407b4eda..c7b96ab86 100644 --- a/v2v/output_rhv.ml +++ b/v2v/output_rhv.ml @@ -89,7 +89,7 @@ and check_storage_domain domain_class os mp = let () = let master_vms_dir = mp // uuid // "master" // "vms" in if not (is_directory master_vms_dir) then - error (f_"%s does not exist or is not a directory.\n\nMost likely cause: Either the %s (%s) has not been attached to any Data Center, or th...
2016 Apr 26
4
v2v: Remove --no-trim, --vmtype options and other fixes.
The first two patches implement the change discussed here: https://www.redhat.com/archives/libguestfs/2016-April/msg00178.html The third patch fixes the mapping of inspection data to OVF VmType which was inherited directly from old virt-v2v and had never been changed. It had a number of problems. The fourth patch is only slightly related to the others. It adds an extra slow test to ensure that
2015 Oct 06
10
[PATCH 0/5] mllib: Hide bad String functions and miscellaneous refactoring.
Hide/prevent the use of bad string functions like String.lowercase. These are replaced by safe functions that won't break UTF-8 strings. Other miscellaneous refactoring. Rich.
2017 Jul 21
2
[PATCH] common/mlutils: Remove bogus suffix parameter from Mkdtemp.temp_dir.
...quot; in + let t = Mkdtemp.temp_dir ~base_dir "null." in rmdir_on_exit t; t in object diff --git a/v2v/output_rhv.ml b/v2v/output_rhv.ml index 0c02df612..f1a193bde 100644 --- a/v2v/output_rhv.ml +++ b/v2v/output_rhv.ml @@ -40,7 +40,7 @@ let rec mount_and_check_storage_domain domain_class os = (* Create a mountpoint. Default mode is too restrictive for us * when we need to write into the directory as 36:36. *) - let mp = Mkdtemp.temp_dir "v2v." "" in + let mp = Mkdtemp.temp_dir "v2v." in chmod mp 0o755; (* Try mountin...
2016 Jul 07
12
[PATCH v3 0/8] v2v: Move Curl wrapper to mllib and more.
v2 -> v3: - Changes to the Curl API suggested by Pino.