search for: do_write

...; + if (dent == NULL) { > > > + return 0; > > > + } > > > > So this seems to just be picking the first filename reported by > > readdir that isn't starting with '.'. Surely this can't the right > > logic when your corresponding do_write method can pick several > > different filenames, its potluck which do_read will give back. > > Do you mean that it'd be better to check a list of known filenames and > fail if not? No, I mean that you have several different VIRTIO_PSTORE_TYPE_nnn and use a different file for ea...

...; + if (dent == NULL) { > > > + return 0; > > > + } > > > > So this seems to just be picking the first filename reported by > > readdir that isn't starting with '.'. Surely this can't the right > > logic when your corresponding do_write method can pick several > > different filenames, its potluck which do_read will give back. > > Do you mean that it'd be better to check a list of known filenames and > fail if not? No, I mean that you have several different VIRTIO_PSTORE_TYPE_nnn and use a different file for ea...

...setup_req(struct blockdev *bd, + int type, struct request *req, struct lguest_dma *dma) +{ + bd->lb_page->type = type; + bd->lb_page->sector = req->sector; + bd->lb_page->result = 0; + bd->req = req; + bd->lb_page->bytes = req_to_dma(req, dma); +} + +static void do_write(struct blockdev *bd, struct request *req) +{ + struct lguest_dma send; + + pr_debug("lgb: WRITE sector %li\n", (long)req->sector); + setup_req(bd, 1, req, &send); + + hcall(LHCALL_SEND_DMA, bd->phys_addr, __pa(&send), 0); +} + +static void do_read(struct blockdev *bd, struct...

...setup_req(struct blockdev *bd, + int type, struct request *req, struct lguest_dma *dma) +{ + bd->lb_page->type = type; + bd->lb_page->sector = req->sector; + bd->lb_page->result = 0; + bd->req = req; + bd->lb_page->bytes = req_to_dma(req, dma); +} + +static void do_write(struct blockdev *bd, struct request *req) +{ + struct lguest_dma send; + + pr_debug("lgb: WRITE sector %li\n", (long)req->sector); + setup_req(bd, 1, req, &send); + + hcall(LHCALL_SEND_DMA, bd->phys_addr, __pa(&send), 0); +} + +static void do_read(struct blockdev *bd, struct...

...+ dent = readdir(s->dirp); > + } > + > + if (dent == NULL) { > + return 0; > + } So this seems to just be picking the first filename reported by readdir that isn't starting with '.'. Surely this can't the right logic when your corresponding do_write method can pick several different filenames, its potluck which do_read will give back. > + > + /* skip res and fileinfo */ > + sg_num = iov_copy(sg, sg_num, in_sg, in_num, offset, > + iov_size(in_sg, in_num) - offset); > + > + virtio_pstore_from_file...

...+ dent = readdir(s->dirp); > + } > + > + if (dent == NULL) { > + return 0; > + } So this seems to just be picking the first filename reported by readdir that isn't starting with '.'. Surely this can't the right logic when your corresponding do_write method can pick several different filenames, its potluck which do_read will give back. > + > + /* skip res and fileinfo */ > + sg_num = iov_copy(sg, sg_num, in_sg, in_num, offset, > + iov_size(in_sg, in_num) - offset); > + > + virtio_pstore_from_file...

Hi again all, It turns out that networking really wants ordered requests, which the previous patches didn't allow. This patch changes it to a callback mechanism; kudos to Avi. The downside is that locking is more complicated, and after a few dead ends I implemented the simplest solution: the struct virtio_device contains the spinlock to use, and it's held when your callbacks get

Hi again all, It turns out that networking really wants ordered requests, which the previous patches didn't allow. This patch changes it to a callback mechanism; kudos to Avi. The downside is that locking is more complicated, and after a few dead ends I implemented the simplest solution: the struct virtio_device contains the spinlock to use, and it's held when your callbacks get

Hi again all, It turns out that networking really wants ordered requests, which the previous patches didn't allow. This patch changes it to a callback mechanism; kudos to Avi. The downside is that locking is more complicated, and after a few dead ends I implemented the simplest solution: the struct virtio_device contains the spinlock to use, and it's held when your callbacks get

...-charset => ISO-8859-1,utf-8;q=0.7,*;q=0.7 request-header: content-length => 47 request-header: keep-alive => 300 Errno::EPIPE: Broken pipe from /usr/local/lib/ruby/1.8/openssl/buffering.rb:178:in `syswrite'' from /usr/local/lib/ruby/1.8/openssl/buffering.rb:178:in `do_write'' from /usr/local/lib/ruby/1.8/openssl/buffering.rb:192:in `write'' from /usr/local/lib/ruby/1.8/net/protocol.rb:175:in `write0'' from /usr/local/lib/ruby/1.8/net/protocol.rb:151:in `write'' from /usr/local/lib/ruby/1.8/net/protocol.rb...

...end_error(conn, errno); - - return send_reply(conn, XS_READ, value, size); + send_error(conn, errno); + else + send_reply(conn, XS_READ, value, size); } /* Create a new directory. Optionally put data in it (if data != NULL) */ @@ -893,7 +898,7 @@ } /* path, flags, data... */ -static bool do_write(struct connection *conn, struct buffered_data *in) +static void do_write(struct connection *conn, struct buffered_data *in) { unsigned int offset, datalen; char *vec[2]; @@ -902,15 +907,19 @@ struct stat st; /* Extra "strings" can be created by binary data. */ - if (get_strings...

> So the make process gets an EAGAIN on the write syscall and doesn't > retry? That sounds like a bug in whatever make you're using, since > that could potentially occur in other circumstances too. What other circumstances? EAGAIN means that something put the device into non-blocking mode, and normally, that should only happen if the program calling write had itself previously

...t; + } > > + > > + if (dent == NULL) { > > + return 0; > > + } > > So this seems to just be picking the first filename reported by > readdir that isn't starting with '.'. Surely this can't the right > logic when your corresponding do_write method can pick several > different filenames, its potluck which do_read will give back. Do you mean that it'd be better to check a list of known filenames and fail if not? > > > + > > + /* skip res and fileinfo */ > > + sg_num = iov_copy(sg, sg_num, in_sg, in_n...

...:145: warning: unused variable 'idx' drivers/block/lguest_blk.c:145: warning: unused variable 'i' drivers/block/lguest_blk.c: In function 'setup_req': drivers/block/lguest_blk.c:185: error: dereferencing pointer to incomplete type drivers/block/lguest_blk.c: In function 'do_write': drivers/block/lguest_blk.c:202: error: dereferencing pointer to incomplete type drivers/block/lguest_blk.c: In function 'do_read': drivers/block/lguest_blk.c:215: error: dereferencing pointer to incomplete type drivers/block/lguest_blk.c: In function 'do_lgb_request': drivers/...

...:145: warning: unused variable 'idx' drivers/block/lguest_blk.c:145: warning: unused variable 'i' drivers/block/lguest_blk.c: In function 'setup_req': drivers/block/lguest_blk.c:185: error: dereferencing pointer to incomplete type drivers/block/lguest_blk.c: In function 'do_write': drivers/block/lguest_blk.c:202: error: dereferencing pointer to incomplete type drivers/block/lguest_blk.c: In function 'do_read': drivers/block/lguest_blk.c:215: error: dereferencing pointer to incomplete type drivers/block/lguest_blk.c: In function 'do_lgb_request': drivers/...

...39;' /usr/lib/ruby/site_ruby/1.8/puppet/application.rb:217:in `run'' /usr/sbin/puppetmasterd:66 [2010-07-01 13:27:31] ERROR OpenSSL::SSL::SSLError: SSL_write:: internal error /usr/lib/ruby/1.8/openssl/buffering.rb:178:in `syswrite'' /usr/lib/ruby/1.8/openssl/buffering.rb:178:in `do_write'' /usr/lib/ruby/1.8/openssl/buffering.rb:197:in `<<'' /usr/lib/ruby/1.8/webrick/httpresponse.rb:324:in `_write_data'' /usr/lib/ruby/1.8/webrick/httpresponse.rb:296:in `send_body_string'' /usr/lib/ruby/1.8/webrick/httpresponse.rb:187:in `send_body'' /usr...

Hello, This is v2 of the virtio-pstore work. In this patchset I addressed most of feedbacks from previous version. Limiting disk size is not implemented yet. * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buffer size configurable (Cornelia) - support PSTORE_TYPE_CONSOLE (Kees) - use separate virtqueues for read and write - support concurrent async

Hello, This is v2 of the virtio-pstore work. In this patchset I addressed most of feedbacks from previous version. Limiting disk size is not implemented yet. * changes in v2) - update VIRTIO_ID_PSTORE to 22 (Cornelia, Stefan) - make buffer size configurable (Cornelia) - support PSTORE_TYPE_CONSOLE (Kees) - use separate virtqueues for read and write - support concurrent async

Hi all, These are the patches I'm planning to submit for 2.6.24. Comments gratefully accepted. Along with the usual cleanups and improvements are Jes' de-i386-ification patches, and a new "virtio" mechanism designed to be shared with KVM (and hopefully other hypervisors). Cheers, Rusty. Documentation/lguest/Makefile | 30 Documentation/lguest/lguest.c

Hi all, These are the patches I'm planning to submit for 2.6.24. Comments gratefully accepted. Along with the usual cleanups and improvements are Jes' de-i386-ification patches, and a new "virtio" mechanism designed to be shared with KVM (and hopefully other hypervisors). Cheers, Rusty. Documentation/lguest/Makefile | 30 Documentation/lguest/lguest.c