search for: do_umount

Here's one final (I hope) question without a complete patch. Given that I already ensure that stubs.c invokes REQUIRE_ROOT_OR_RESOLVE_DEVICE just before calling do_umount, does this new version of do_umount look ok? /* Again, use the external /bin/umount program, so that /etc/mtab * is kept updated. */ int do_umount (const char *pathordevice) { int r; char *err; char *buf = sysroot_path (pathordevice); if (buf == NULL) { reply_with_perror ("mall...

...g on "/" first before many operations. * Hence we have an internal function which can test if something is * mounted on *or under* the sysroot directory. (It has to be *or @@ -187,12 +189,16 @@ do_mount_options (const char *options, const char *device, * is kept updated. */ int -do_umount (const char *pathordevice) +do_umount (const char *pathordevice, + int force, int lazyunmount) { int r; char *err; char *buf; int is_dev; + char prog[] = "umount"; + const char *argv[MAX_ARGS]; + size_t i = 0; is_dev = STREQLEN (pathordevice, "/dev/&quo...

...g on "/" first before many operations. * Hence we have an internal function which can test if something is * mounted on *or under* the sysroot directory. (It has to be *or @@ -187,12 +189,16 @@ do_mount_options (const char *options, const char *device, * is kept updated. */ int -do_umount (const char *pathordevice) +do_umount (const char *pathordevice, + int force, int lazyunmount) { int r; char *err; char *buf; int is_dev; + char prog[] = "umount"; + const char *argv[MAX_ARGS]; + size_t i = 0; is_dev = STREQLEN (pathordevice, "/dev/&quo...

...* NB: * (1) You must match CHROOT_IN and CHROOT_OUT even along error paths. * (2) You must not change directory! cwd must always be "/", otherwise diff --git a/daemon/mount.c b/daemon/mount.c index 0661eb8..1843165 100644 --- a/daemon/mount.c +++ b/daemon/mount.c @@ -192,18 +192,9 @@ do_umount (const char *pathordevice) int r; char *err; char *buf; - int is_dev; - is_dev = STREQLEN (pathordevice, "/dev/", 5); - buf = is_dev ? strdup (pathordevice) - : sysroot_path (pathordevice); - if (buf == NULL) { - reply_with_perror ("malloc"); -...

...blem). > I am inclined to agree with you. I also test liburing examples apps on ext4 partition, everything looks fine. I used below bpftrace method, the retval is '3'. bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') Thanks, Heming > > On 2/24/23 8:32 AM, Heming Zhao wrote: >> Hello List, >> >> I found a weird bug on ocfs2. I am busying with other jobs, if anyone have time >> he/she could fix it. This bug is blocking fstest generic/013 test...

...o agree with you. I also test liburing examples apps > on ext4 partition, everything looks fine. > > I used below bpftrace method, the retval is '3'. > ?bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' > > It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') > Yes, that's the place return EBUSY. So the problem seems to be getmnt/putmnt not match in this case. Thanks, Joseph > >> >> On 2/24/23 8:32 AM, Heming Zhao wrote: >>> Hello List, >>> >>> I found a weird bu...

...o test liburing examples apps >> on ext4 partition, everything looks fine. >> >> I used below bpftrace method, the retval is '3'. >> ?bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' >> >> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') >> > Yes, that's the place return EBUSY. > So the problem seems to be getmnt/putmnt not match in this case. > I didn't familiar with setting up kernel bi-search env. I used one last year openSUSE tumblweed (with kernel 5.16.2), this um...

...apps >>> on ext4 partition, everything looks fine. >>> >>> I used below bpftrace method, the retval is '3'. >>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' >>> >>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') >>> >> Yes, that's the place return EBUSY. >> So the problem seems to be getmnt/putmnt not match in this case. >> > > I didn't familiar with setting up kernel bi-search env. I used one last year > openSUSE tumblweed...

...* NB: * (1) You must match CHROOT_IN and CHROOT_OUT even along error paths. * (2) You must not change directory! cwd must always be "/", otherwise diff --git a/daemon/mount.c b/daemon/mount.c index 0661eb8..1bac1a7 100644 --- a/daemon/mount.c +++ b/daemon/mount.c @@ -192,18 +192,9 @@ do_umount (const char *pathordevice) int r; char *err; char *buf; - int is_dev; - is_dev = STREQLEN (pathordevice, "/dev/", 5); - buf = is_dev ? strdup (pathordevice) - : sysroot_path (pathordevice); - if (buf == NULL) { - reply_with_perror ("malloc"); -...

...>>>>>> >>>>>> I used below bpftrace method, the retval is '3'. >>>>>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' >>>>>> >>>>>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') >>>>>> >>>>> Yes, that's the place return EBUSY. >>>>> So the problem seems to be getmnt/putmnt not match in this case. >>>>> >>>> >>>> I didn't familiar with settin...

...4 partition, everything looks fine. > >>> > >>> I used below bpftrace method, the retval is '3'. > >>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' > >>> > >>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') > >>> > >> Yes, that's the place return EBUSY. > >> So the problem seems to be getmnt/putmnt not match in this case. > >> > > > > I didn't familiar with setting up kernel bi-search env. I used one las...

...ooks fine. > > >>> > > >>> I used below bpftrace method, the retval is '3'. > > >>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' > > >>> > > >>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') > > >>> > > >> Yes, that's the place return EBUSY. > > >> So the problem seems to be getmnt/putmnt not match in this case. > > >> > > > > > > I didn't familiar with setting up kernel...

...;>> >>>>>>> I used below bpftrace method, the retval is '3'. >>>>>>> ??bpftrace -e 'kr:mnt_get_count{printf("%d\n", retval);}' >>>>>>> >>>>>>> It responds to flow: path_umount() => do_umount => mnt_get_count (gets '3') >>>>>>> >>>>>> Yes, that's the place return EBUSY. >>>>>> So the problem seems to be getmnt/putmnt not match in this case. >>>>>> >>>>> >>>>> I didn...

On Fri, Apr 21, 2023 at 03:35:01PM +0800, Joseph Qi wrote: > Hi, > Could you please share a reproducer? > Anyone could access & download the URL [1] (I wrote it in patch commit log) without register SUSE account. Please check attachment file, which I downloaded from [1] and modified under the BZ comment 1. The trigger method is also in comment 1, I copy here: ./defragfs_test.sh -d

I can reproduce this in my local VM. I've traced ocfs2_dismount_volume and found that it hasn't been called. So EBUSY is returned in VFS layer. I guess something wrong when doing a copy with linked SQEs (normal copy seems no problem). Thanks, Joseph On 2/24/23 8:32 AM, Heming Zhao wrote: > Hello List, > > I found a weird bug on ocfs2. I am busying with other jobs, if anyone

hello. I found there are a few mistakes in linux/syslinux.c (hope i'm not wrong since it's my first patch). diff --git a/linux/syslinux.c b/linux/syslinux.c index 37a54fd..5d38e6f 100644 --- a/linux/syslinux.c +++ b/linux/syslinux.c @@ -316,7 +316,6 @@ void do_umount(const char *mntpath, int cookie) int main(int argc, char *argv[]) { static unsigned char sectbuf[SECTOR_SIZE]; - unsigned char *dp; const unsigned char *cdp; int dev_fd, fd; struct stat st; @@ -498,7 +497,7 @@ int main(int argc, char *argv[]) goto umount; } - dp += nb...

The two patches attached allow 9p filesystems to be mounted and listed. Note that I did *not* test the new list-9p function, because I don't have a guest with a new enough kernel handy. 9p filesystems are not included in the output of list-filesystems. Because a lot of existing code feeds the output of list-filesystems directly into the input of mount-options, mount-ro or (even worse) plain

...t;ro", NULL, mountable, mountpoint); -} - -int -do_mount_options (const char *options, const mountable_t *mountable, - const char *mountpoint) -{ - return do_mount_vfs (options, NULL, mountable, mountpoint); -} - /* Takes optional arguments, consult optargs_bitmask. */ int do_umount (const char *pathordevice, diff --git a/daemon/mount.ml b/daemon/mount.ml new file mode 100644 index 000000000..4bb74fb82 --- /dev/null +++ b/daemon/mount.ml @@ -0,0 +1,62 @@ +(* guestfs-inspection + * Copyright (C) 2009-2017 Red Hat Inc. + * + * This program is free software; you can redistribute...

...+ let is_dev = is_device_parameter path in (* For non-dev, check this is a regular file, else just return the * file type as a string (RHBZ#582484). diff --git a/daemon/mount.c b/daemon/mount.c index bf58bd527..61ce64449 100644 --- a/daemon/mount.c +++ b/daemon/mount.c @@ -120,7 +120,7 @@ do_umount (const char *pathordevice, const char *argv[MAX_ARGS]; size_t i = 0; - is_dev = STREQLEN (pathordevice, "/dev/", 5); + is_dev = is_device_parameter (pathordevice); buf = is_dev ? strdup (pathordevice) : sysroot_path (pathordevice); if (buf == NULL) { diff --git a/daem...

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-