search for: do_suspend

...the deprecated) stop_machine_run in the tree. Signed-off-by: Rusty Russell <rusty at rustcorp.com.au> diff -r 332ec042cb4d drivers/xen/manage.c --- a/drivers/xen/manage.c Wed Aug 13 10:48:27 2008 +1000 +++ b/drivers/xen/manage.c Wed Aug 13 15:50:02 2008 +1000 @@ -102,7 +102,7 @@ static void do_suspend(void) /* XXX use normal device tree? */ xenbus_suspend(); - err = stop_machine_run(xen_suspend, &cancelled, 0); + err = stop_machine(xen_suspend, &cancelled, &cpumask_of_cpu(0)); if (err) { printk(KERN_ERR "failed to start xen_suspend: %d\n", err); goto out;

linux-next-20080618/drivers/xen/manage.c: In function 'xen_suspend': linux-next-20080618/drivers/xen/manage.c:66: error: too few arguments to function 'device_power_up' linux-next-20080618/drivers/xen/manage.c: In function 'do_suspend': linux-next-20080618/drivers/xen/manage.c:115: error: too few arguments to function 'device_resume' make[3]: *** [drivers/xen/manage.o] Error 1 --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/

...en_suspend': linux-next-20080528/drivers/xen/manage.c:43: error: implicit declaration of function 'device_power_down' linux-next-20080528/drivers/xen/manage.c:65: error: implicit declaration of function 'device_power_up' linux-next-20080528/drivers/xen/manage.c: In function 'do_suspend': linux-next-20080528/drivers/xen/manage.c:114: error: implicit declaration of function 'device_resume' make[3]: *** [drivers/xen/manage.o] Error 1 --- ~Randy "He closes his eyes and drops the goggles. You can't get hurt by looking at a bitmap. Or can you?" ------------...

...en_suspend': linux-next-20080528/drivers/xen/manage.c:43: error: implicit declaration of function 'device_power_down' linux-next-20080528/drivers/xen/manage.c:65: error: implicit declaration of function 'device_power_up' linux-next-20080528/drivers/xen/manage.c: In function 'do_suspend': linux-next-20080528/drivers/xen/manage.c:114: error: implicit declaration of function 'device_resume' make[3]: *** [drivers/xen/manage.o] Error 1 --- ~Randy "He closes his eyes and drops the goggles. You can't get hurt by looking at a bitmap. Or can you?" ------------...

linux-next-20080618/drivers/xen/manage.c: In function 'xen_suspend': linux-next-20080618/drivers/xen/manage.c:66: error: too few arguments to function 'device_power_up' linux-next-20080618/drivers/xen/manage.c: In function 'do_suspend': linux-next-20080618/drivers/xen/manage.c:115: error: too few arguments to function 'device_resume' make[3]: *** [drivers/xen/manage.o] Error 1 --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/

.../manage.c @@ -63,7 +63,7 @@ static int xen_suspend(void *data) BUG_ON(!irqs_disabled()); - err = sysdev_suspend(PMSG_SUSPEND); + err = sysdev_suspend(PMSG_FREEZE); if (err) { printk(KERN_ERR "xen_suspend: sysdev_suspend failed: %d\n", err); @@ -114,16 +114,16 @@ static void do_suspend(void) } #endif - err = dpm_suspend_start(PMSG_SUSPEND); + err = dpm_suspend_start(PMSG_FREEZE); if (err) { printk(KERN_ERR "xen suspend: dpm_suspend_start %d\n", err); goto out_thaw; } - printk(KERN_DEBUG "suspending xenstore...\n"); + /* printk(KERN_DEBUG &quot...

...ell@citrix.com> commit 4877c737283813bdb4bebfa3168c1585f6e3a8ca upstream. In general the semantics of IPIs are that they are are expected to continue functioning after dpm_suspend_noirq(). Specifically I have seen a deadlock between the callfunc IPI and the stop machine used by xen''s do_suspend() routine. If one CPU has already called dpm_suspend_noirq() then there is a window where it can be sent a callfunc IPI before all the other CPUs have entered stop_cpu(). If this happens then the first CPU ends up spinning in stop_cpu() waiting for the other to rendezvous in state STOPMACHINE_PREP...

.../drivers/xen/manage.c index db3c4bd..e8db90c 100644 --- a/drivers/xen/manage.c +++ b/drivers/xen/manage.c @@ -66,6 +66,7 @@ static int xen_suspend(void *data) if (!*cancelled) { xen_irq_resume(); xen_console_resume(); + xen_timer_resume(); } return 0; @@ -105,9 +106,10 @@ static void do_suspend(void) goto out; } - if (!cancelled) + if (!cancelled) { + xen_arch_resume(); xenbus_resume(); - else + } else xenbus_suspend_cancel(); device_resume(); diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index a706d6a..883a21b 100644 --- a/include/xen/xen-ops.h +++ b/includ...

.../drivers/xen/manage.c index db3c4bd..e8db90c 100644 --- a/drivers/xen/manage.c +++ b/drivers/xen/manage.c @@ -66,6 +66,7 @@ static int xen_suspend(void *data) if (!*cancelled) { xen_irq_resume(); xen_console_resume(); + xen_timer_resume(); } return 0; @@ -105,9 +106,10 @@ static void do_suspend(void) goto out; } - if (!cancelled) + if (!cancelled) { + xen_arch_resume(); xenbus_resume(); - else + } else xenbus_suspend_cancel(); device_resume(); diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index a706d6a..883a21b 100644 --- a/include/xen/xen-ops.h +++ b/includ...

.../drivers/xen/manage.c index db3c4bd..e8db90c 100644 --- a/drivers/xen/manage.c +++ b/drivers/xen/manage.c @@ -66,6 +66,7 @@ static int xen_suspend(void *data) if (!*cancelled) { xen_irq_resume(); xen_console_resume(); + xen_timer_resume(); } return 0; @@ -105,9 +106,10 @@ static void do_suspend(void) goto out; } - if (!cancelled) + if (!cancelled) { + xen_arch_resume(); xenbus_resume(); - else + } else xenbus_suspend_cancel(); device_resume(); diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h index a706d6a..883a21b 100644 --- a/include/xen/xen-ops.h +++ b/includ...

...39; + * is not SMP safe so we depend on reboot notifiers to set ''shutting_down'' + * so that we will ignore XenBus shutdown requests. + */ +static atomic_t shutting_down = ATOMIC_INIT(SHUTDOWN_INVALID); struct suspend_info { int cancelled; @@ -109,7 +117,7 @@ static void do_suspend(void) int err; struct suspend_info si; - shutting_down = SHUTDOWN_SUSPEND; + atomic_set(&shutting_down, SHUTDOWN_SUSPEND); #ifdef CONFIG_PREEMPT /* If the kernel is preemptible, we need to freeze all the processes @@ -173,7 +181,7 @@ out_thaw: thaw_processes(); out: #endif - shut...

...this issue solved? Sincerely Philipp PS: bisecting did not help much, since 2.6.32.59 contains a lot of back-ports from 2.6.33, 35, 36 and 37. 2.6.33 needs 281ff33 # x86_64, cpa: Don''t work hard in preserving kernel 2M mappings when using 4K already 2.6.33-rc1: c5cae66 fixes 65f6338 # do_suspend error handling 2.6.35-rc1: e7a3481 fixes 489fb49 # global sync point 2.6.37 needs ceff1a7 # /proc/kcore: fix seeking -- Philipp Hahn Open Source Software Engineer hahn@univention.de Univention GmbH be open. fon: +49 421 22 232- 0 Mary-Somerville-Str.1 D...