search for: do_suggest

--autosysroot option uses suggestions to user on how to mount filesystems and change root suggested by --suggest option in virt-rescue. Commands are passed on kernel command line in format guestfs_command=command;. Command ends with a semicolon and there can be multiple commands specified. These are executed just before bash starts. On successfull run user is presented directly with bash in

...-rescue: Syncing the disk now before exiting ..." diff --git a/rescue/rescue.c b/rescue/rescue.c index 135c9e6..77b6544 100644 --- a/rescue/rescue.c +++ b/rescue/rescue.c @@ -37,7 +37,7 @@ #include "options.h" static void add_scratch_disks (int n, struct drv **drvs); -static void do_suggestion (struct drv *drvs); +static char ** do_suggestion (struct drv *drvs); /* Currently open libguestfs handle. */ guestfs_h *g; @@ -50,6 +50,9 @@ int echo_keys = 0; const char *libvirt_uri = NULL; int inspector = 0; +static void use_suggestions (char **cmds); +static void parse_opts(int argc...

--autosysroot option uses suggestions to user on how to mount filesystems and change root suggested by --suggest option in virt-rescue. Commands are passed on kernel command line in format guestfs_command=command;. Command ends with a semicolon and there can be multiple commands specified. These are executed just before bash starts. On successfull run user is presented directly with bash in

......" > diff --git a/rescue/rescue.c b/rescue/rescue.c > index 135c9e6..77b6544 100644 > --- a/rescue/rescue.c > +++ b/rescue/rescue.c > @@ -37,7 +37,7 @@ > #include "options.h" > > static void add_scratch_disks (int n, struct drv **drvs); > -static void do_suggestion (struct drv *drvs); > +static char ** do_suggestion (struct drv *drvs); > > /* Currently open libguestfs handle. */ > guestfs_h *g; > @@ -50,6 +50,9 @@ int echo_keys = 0; > const char *libvirt_uri = NULL; > int inspector = 0; > > +static void use_suggestions (c...

...rescue.c b/rescue/rescue.c >> index 135c9e6..77b6544 100644 >> --- a/rescue/rescue.c >> +++ b/rescue/rescue.c >> @@ -37,7 +37,7 @@ >> #include "options.h" >> >> static void add_scratch_disks (int n, struct drv **drvs); >> -static void do_suggestion (struct drv *drvs); >> +static char ** do_suggestion (struct drv *drvs); >> >> /* Currently open libguestfs handle. */ >> guestfs_h *g; >> @@ -50,6 +50,9 @@ int echo_keys = 0; >> const char *libvirt_uri = NULL; >> int inspector = 0; >>...

...rbind instead of --bind. This also allows us to remove the /dev/pts line. --- rescue/rescue.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/rescue/rescue.c b/rescue/rescue.c index 53afdae..9a7c988 100644 --- a/rescue/rescue.c +++ b/rescue/rescue.c @@ -453,10 +453,9 @@ do_suggestion (struct drv *drvs) /* If it's Linux, print the bind-mounts. */ if (type && STREQ (type, "linux")) { - printf ("mount --bind /dev /sysroot/dev\n"); - printf ("mount --bind /dev/pts /sysroot/dev/pts\n"); - printf ("mount --b...

..."); drv->type = drv_scratch; - drv->nr_drives = -1; drv->scratch.size = INT64_C (10737418240); drv->next = *drvs; *drvs = drv; diff --git a/rescue/suggest.c b/rescue/suggest.c index 78792f2..f1d0fb6 100644 --- a/rescue/suggest.c +++ b/rescue/suggest.c @@ -54,7 +54,7 @@ do_suggestion (struct drv *drvs) read_only = 1; /* Add drives. */ - add_drives (drvs, 'a'); + add_drives (drvs, 0); /* Free up data structures, no longer needed after this point. */ free_drives (drvs); -- 2.9.3

This set of patches fixes virt-rescue rather cleanly. In particular the problems with handling ^C are completely fixed. Work still to be done before this can go upstream: - Shutdown doesn't work properly if you exit the shell. At the moment to exit you must do 'reboot -f'. Future improvements: - An escape sequence and escape commands that could be handled by virt-rescue,

This fixes the main issues in virt-rescue and is usable. There are some enhancements which could be made (in follow up work): - An escape sequence and escape commands that could be handled by virt-rescue, eg. to shut down the appliance, mount or unmount filesystems. - `virt-rescue -i' could be implemented cleanly by performing the right API calls before handing control to the

This implements most of RHBZ#1367738. I didn't bother with virt-v2v-copy-to-local and virt-win-reg, but all the other tools now have full bash completion. Rich.

This supersedes the two previous patch series: https://www.redhat.com/archives/libguestfs/2017-March/msg00017.html https://www.redhat.com/archives/libguestfs/2017-March/msg00046.html Rich.

Version 3: - Tidies up the code further. - Implements correct handling of SIGTSTP and SIGCONT. - Adds: ^] s - sync filesystems - Adds: ^] z - suspend virt-rescue Rich.

libguestfs has used double and triple underscores in identifiers. These aren't valid for global names in C++. (http://stackoverflow.com/a/228797) These large but completely mechanical patches change the illegal identifiers to legal ones. Rich.