search for: do_server_sender

https://bugzilla.samba.org/show_bug.cgi?id=13104 Bug ID: 13104 Summary: NULL deref do_server_sender when argc=0 Product: rsync Version: 3.1.3 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 Component: core Assignee: wayned at samba.org Reporter: jeriko.one at gmx.us...

Hello,I'm studying the source code of rsync-0.1 recently.Because the latest version is so complicated, I have to start my study from rsync-0.1 for simplicity. In the main.c file of rsync-0.1, there are two functions--"do_server_sender" and "do_server_recv".I don't know when they work.When I want to transfer files between a local client and a remote server, I could use command: rsync src user@host:dest or rsync user@host:src dest.But what's the commant format if I want to call --"do_server_sender&quot...

...000000000042649f in hash_search (f=1, s=0x192d220, buf=0x192d1e0, len=214748364800) at match.c:236 #2 0x0000000000426cf4 in match_sums (f=1, s=0x192d220, buf=0x192d1e0, len=214748364800) at match.c:398 #3 0x000000000041a175 in send_files (f_in=0, f_out=1) at sender.c:391 #4 0x0000000000423620 in do_server_sender (f_in=0, f_out=1, argc=1, argv=0x18da238) at main.c:822 #5 0x0000000000423f1f in start_server (f_in=0, f_out=1, argc=2, argv=0x18da230) at main.c:1089 #6 0x0000000000425282 in main (argc=2, argv=0x18da230) at main.c:1630 (gdb) quit -- a number of seconds later -- root at st1:~# gdb /usr/bin/rsync...

...dless of running it manually or via cron. I'm using "rsync -avzu --stats /mnt/server/share /mnt/backup2/server/share" as a command line. Thanks!! Here is the portion of main.c starting with line 577: **************************snip********************************** static void do_server_sender(int f_in, int f_out, int argc, char *argv[]) { struct file_list *flist; char *dir = argv[0]; if (verbose > 2) { rprintf(FINFO, "server_sender starting pid=%ld\n", (long)getpid()); } if (am_daemon && lp_write_only(module_id)) { rprintf(FERROR, "ERROR: module...

...at io.c:498 #4 0x24f24 in io_flush () at io.c:518 #5 0x24940 in readfd (fd=0, buffer=0xffbe7020 "?\002r\215?/\201R", N=4) at io.c:314 #6 0x24998 in read_int (f=0) at io.c:329 #7 0x199a4 in send_files (flist=0x574e8, f_out=1, f_in=0) at sender.c:110 #8 0x1d1e8 in do_server_sender (f_in=0, f_out=1, argc=1, argv=0x56f74) at main.c:300 #9 0x1d708 in start_server (f_in=0, f_out=1, argc=2, argv=0x56f70) at main.c:476 #10 0x1e08c in main (argc=2, argv=0x56f70) at main.c:838 Backtrace #1 on client (the parent): #0 0xef5b7904 in _poll () #1 0xef5d3d40 in _s...

...#39;ve done everything right - so if any one would like to point areas I'm falling down on I'd appreciate it. J ------------------------------------ --- rsync-2.6.0/main.c.orig Thu Feb 12 11:47:38 2004 +++ rsync-2.6.0/main.c Thu Feb 12 11:48:16 2004 @@ -347,12 +347,19 @@ static void do_server_sender(int f_in, i int i; struct file_list *flist; char *dir = argv[0]; + extern int module_id; extern int relative_paths; extern int recurse; if (verbose > 2) rprintf(FINFO,"server_sender starting pid=%d\n",(int)getpid(...

...5c0, type_ptr=0xbf85f5db "\200var/svn/hot_backups/foobar-www-5/hooks/ pre-unlock", buf=0xbf85f5dc "var/svn/hot_backups/foobar-www-5/hooks/ pre-unlock", len_ptr=0xbf85f5bc) at rsync.c:257 #8 0x0805e5fa in send_files (f_in=0, f_out=1) at sender.c:187 #9 0x080671c0 in do_server_sender (f_in=0, f_out=1, argc=1, argv=0x94339c4) at main.c:726 #10 0x08067a5c in start_server (f_in=0, f_out=1, argc=2, argv=0x94339c0) at main.c:971 #11 0x08068c7b in main (argc=2, argv=0x94339c0) at main.c:1501 Any suggestions? Should I file a bug report? Blair

...+ * if (am_sender) + * write_longint stuff; + * else + * read_longing stuff; + * + * This would have several advantages: 1) It simplifies the + * protocol by removing variation based on server-ness. 2) It + * makes the client_run()-if(am_sender) path look more like + * do_server_sender (ideally, these should be the same). 3) + * It removes the need for write_batch corrections that have + * to record a canonical (independent of server-ness) record + * of the transmission, and read_batch corrections that have + * to replay this canonical record. + */ + if (am_server)...

Rsync 2.5.5; transfer via ssh; sparc-sun-solaris2.5 (Ultra 1); gcc 2.8.1. Every time rsync on this box causes boundary violation. I attached two strange examples. I have a few rsync's corefiles (100MB and above) and I can examine them. I will be grateful for any help. -Mirek <-------------------------------------------------------------------------> received 966761 names done

...fe7c1aa380 "", len=len at entry=4) at io.c:1840 #4 0x00007f9a71e47851 in read_int (f=<optimized out>) at io.c:1711 #5 0x00007f9a71e2f652 in receive_sums (f=<optimized out>) at sender.c:96 #6 send_files (f_in=4, f_out=1930300096) at sender.c:332 #7 0x00007f9a71e37f6c in do_server_sender (argv=<optimized out>, argc=<optimized out>, f_out=3, f_in=3) at main.c:840 #8 start_server (f_in=3, f_out=3, argc=2, argv=0x7f9a7302f240) at main.c:1107 #9 0x00007f9a71e5a34e in rsync_module (f_in=3, f_out=3, i=0, addr=0x7f9a72098518 <numeric_ids> "\377\377\377\377"...

...ile = file->F_NEXT) != NULL) { + while ((file = file->F_NEXT) != first) { hlink2 = f_name(file); if (link_stat(hlink2, &st2) == 0) { if (st2.st_dev == st1.st_dev --- main.c 20 Jan 2004 17:46:31 -0000 1.183 +++ main.c 25 Jan 2004 09:19:45 -0000 @@ -409,6 +409,7 @@ static void do_server_sender(int f_in, i static int do_recv(int f_in,int f_out,struct file_list *flist,char *local_name) { + int i; int pid; int status=0; int error_pipe[2]; @@ -463,6 +464,19 @@ static int do_recv(int f_in,int f_out,st generate_files(f_out, flist, local_name); get_redo_num(); /* Read final -1,...

> Just curious: what about the rsync+ patch? Thanks for the reminder. I've just committed Jos's rsync+ patch onto the "branch_mbp_rsyncplus_merge" branch. If it works OK and nobody screams I will move it across onto the main tree tomorrow or Wednesday. I see the patch doesn't add documentation about the new options to the man page, so we should fix that in the future.