search for: do_pwrite

Only compile tested. I'm keeping this as a separate patch for the moment until the relevant change on the oVirt side goes upstream. Rich.

...pread(h, count, offset): return r.read() def pwrite(h, buf, offset): + http = h['http'] + transfer=h['transfer'] + transfer_service=h['transfer_service'] count = len(buf) - h['highestwrite'] = max(h['highestwrite'], offset+count) - do_pwrite(h, buf, offset, count) - -def do_pwrite(h, buf, offset, count): - http = h['http'] - transfer=h['transfer'] - transfer_service=h['transfer_service'] http.putrequest("PUT", h['path']) http.putheader("Authorization", transfer.si...

...ns correct, but redundant. --- daemon/file.c | 20 +++++++++++++------- src/generator.ml | 6 ------ 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index da899b6..9ce0783 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -501,7 +501,6 @@ int do_pwrite (const char *path, const char *content, size_t size, int64_t offset) { int fd; - ssize_t r; CHROOT_IN; fd = open (path, O_WRONLY); @@ -512,11 +511,18 @@ do_pwrite (const char *path, const char *content, size_t size, int64_t offset) return -1; } - r = pwrite (fd, content, siz...

From: "Richard W.M. Jones" <rjones at redhat.com> In Linux, close (fd) closes the file descriptor even if it returns an error. --- daemon/file.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/daemon/file.c b/daemon/file.c index e0f8794..91746e0 100644 --- a/daemon/file.c +++ b/daemon/file.c @@ -483,7 +483,6 @@ pread_fd (int fd, int count, int64_t

This is a possibly better work-around for bug 769304, the bug where blkid runs from udev whenever a device closes, causing the subsequent operation to fail. For background to this change, see: https://rwmj.wordpress.com/2012/01/19/udev-unexpectedness/#content So far we have noticed this problem in two places (although I'm fairly certain it affects many more): - in virt-resize, after

...BLKRRPART. 'settle' - * flag is only set on block devices. - * - * XXX We should be smarter about when we do this or should get rid - * of the udev rules since we don't use blkid in cached mode. - */ - if (settle) - udev_settle (); - return r; } @@ -575,7 +563,7 @@ do_pwrite (const char *path, const char *content, size_t size, int64_t offset) return -1; } - return pwrite_fd (fd, content, size, offset, path, 0); + return pwrite_fd (fd, content, size, offset, path); } int @@ -593,7 +581,7 @@ do_pwrite_device (const char *device, const char *content, size_...

These APIs provide handle-based read/write streaming and random access to files and block devices. --- daemon/.gitignore | 1 + daemon/Makefile.am | 1 + daemon/hfile.c | 196 +++++++++++++++++++++++++++++++++++++++++++++ daemon/m4/gnulib-cache.m4 | 3 +- po/POTFILES.in | 2 + regressions/Makefile.am | 1 + regressions/test-hfile.pl | 102