search for: do_pre_login

do_pre_login() in session.c is used (in do_exec_pty()) before it's declared, which is causing some problems for me. please move it up a couple hundred lines in the file. patch included for 0807 snapshot. thanks, wendy % diff -u session.c.orig session.c.mod --- session.c.orig Tue Aug 7 13:11:51 2...

Re: openssh-2.9.9p2 versus Solaris 2.6, Forte C version 6upd2 The compiler treated the call to do_pre_login in session.c line 581 as a prototype, warned of inconsistency with the function definition starting line 628: "session.c", line 628: identifier redeclared: do_pre_login current : static function(pointer to struct Session {[struct definition suppressed]}) returning void previ...

...PROGRAM=\"/usr/local/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/usr/local/sbin/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/usr/local/sbin/sftp-server\" -D_PATH_SSH_PIDDIR=\"/var/run\" -DHAVE_CONFIG_H -c session.c "session.c", line 628: identifier redeclared: do_pre_login current : static function(pointer to struct Session {int used, int self, pointer to struct passwd {..} pw, pointer to struct Authctxt {..} authctxt, int pid, pointer to char term, int ptyfd, int ttyfd, int ptymaster, int row, int col, int xpixel, int ypixel, array[64] of char tty, pointer t...

FYI-- session.c fails from openSSH 2.9.9p2 with SunPro C compiler on Solaris 7, 8. The function do_pre_login had to be moved to before its use in do_exec_pty (a predeclaration would work). It does appear to work correctly, given the above fix. Still having the largefile problem (argh), so if anyone can help with /that/ ... -- Austin David -- Sr. Systems Architect Wink Communications Austin.David at Wink...

...Index: session.c --- session.c 2001/04/18 15:29:34 1.111 +++ session.c 2001/04/29 18:12:41 @@ -127,6 +127,9 @@ void do_exec_pty(Session *s, const char *command); void do_exec_no_pty(Session *s, const char *command); void do_login(Session *s, const char *command); +#ifdef LOGIN_NEEDS_UTMPX +void do_pre_login(Session *s); +#endif void do_child(Session *s, const char *command); void do_motd(void); int check_quietlogin(Session *s, const char *command); @@ -644,6 +647,10 @@ #ifndef HAVE_OSF_SIA if (!(options.use_login && command == NULL)) do_login(s, command); +# ifdef LOGIN_NEEDS_UTMPX...

I found this problem on 32-bit Solaris 8 sparc. session.c uses two void functions without declaring them first; this violates the C standard, which requires declarations for such functions. Here's a patch. 2001-09-28 Paul Eggert <eggert at twinsun.com> * session.c (do_pre_login, record_utmp_only): Add missing declarations. =================================================================== RCS file: session.c,v retrieving revision 2.9.9.2 retrieving revision 2.9.9.2.0.1 diff -pu -r2.9.9.2 -r2.9.9.2.0.1 --- session.c 2001/09/16 22:17:15 2.9.9.2 +++ session.c 200...

...8,7 @@ void do_exec_pty(Session *, const char *); void do_exec_no_pty(Session *, const char *); void do_exec(Session *, const char *); -void do_login(Session *, const char *); +void do_login(Session *, const char *, const time_t, const char *); #ifdef LOGIN_NEEDS_UTMPX static void do_pre_login(Session *s); #endif @@ -548,11 +548,17 @@ { int fdout, ptyfd, ttyfd, ptymaster; pid_t pid; + char hostname[MAXHOSTNAMELEN]; + time_t last_login_time; if (s == NULL) fatal("do_exec_pty: no session"); ptyfd = s->ptyfd;...

http://bass.directhit.com/openssh_snap/ Starting tonight I plan on tracking changes very closely with the OpenBSD tree. I need people to test the latest snapshot (9/14 at of right now) and report success or failure on compiling. I am starting this now because we are looking at a code freeze soon and I really want to ensure it compiles and runs on all existing platforms. So we (the portable

.../opt/openssh/bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/opt/openssh/libexec/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/opt/openssh/libexec/sftp-server\" -D_PATH_SSH_PIDDIR=\"/var/ssh\" -DHAVE_CONFIG_H -c session.c "session.c", line 628: identifier redeclared: do_pre_login current : function(pointer to struct Session {int used, int self, pointer to struct passwd {..} pw, pointer to struct Authctxt {..} authctxt, int pid, pointer to char term, int ptyfd, int ttyfd, int ptymaster, int row, int col, int xpixel, int ypixel, array[64] of char tty, pointer to char...

...bin/ssh\" -D_PATH_SSH_ASKPASS_DEFAULT=\"/opt/openssh-2.9.9p2/libexec/ssh-askpass\" -D_PATH_SFTP_SERVER=\"/opt/openssh-2.9.9p2/libexec/sftp-server\" -D_PATH_SSH_PIDDIR=\"/var/run\" -DHAVE_CONFIG_H -c session.c "session.c", line 628: identifier redeclared: do_pre_login current : static function(pointer to struct Session {int used, int self, pointer to struct passwd {..} pw, pointer to struct Authctxt ... previous: function() returning int : "session.c", line 581 cc: acomp failed for session.c *** Error code 2 make: Fatal error: Command f...

...amp;& command == NULL)) + { +# ifdef _CRAY + cray_init_job(s->pw); /* set up cray jid and tmpdir */ +# endif /* _CRAY */ do_login(s, command); + } # ifdef LOGIN_NEEDS_UTMPX else do_pre_login(s); @@ -528,6 +543,9 @@ do_child(s, command); /* NOTREACHED */ } +#ifdef _CRAY + signal(WJSIGNAL, cray_job_termination_handler); +#endif /* _CRAY */ #ifdef HAVE_CYGWIN if (is_winnt) cygwin_set_impersonation_token(INVALID_HANDLE_...

...p; command == NULL)) + { +# ifdef _CRAY + cray_init_job(s->pw); /* set up cray jid and tmpdir */ +# endif /* _CRAY */ do_login(s, command); + } # ifdef LOGIN_NEEDS_UTMPX else do_pre_login(s); @@ -597,6 +611,9 @@ do_child(s, command); /* NOTREACHED */ } +#ifdef _CRAY + signal(WJSIGNAL, cray_job_termination_handler); +#endif /* _CRAY */ #ifdef HAVE_CYGWIN if (is_winnt) cygwin_set_impersonation_token(INVALID_HANDLE_...

...ee the following when the client > attempts to login: (the JRT lines are my attempting to trace > the program execution flow) > > debug1: Authentication succeeded (publickey). > debug1: channel 0: new [client-session] > debug1: Entering interactive session. > debug1: JRT-03: do_pre_login > debug1: JRT-04: do_child > Environment: > TZ=NZ > SSH_CLIENT=xxx.xx.xx.xxx 34811 2222 > SSH_CONNECTION=xxx.xx.xx.xxx 34811 xxx.xx.xx.xx 2222 > SSH_TTY=/dev/pts/6 > TERM=xterm > debug1: JRT-05: launch_login > > However, if I then query the environment of th...

...ent and server in debug mode, I can see the following when the client attempts to login: (the JRT lines are my attempting to trace the program execution flow) debug1: Authentication succeeded (publickey). debug1: channel 0: new [client-session] debug1: Entering interactive session. debug1: JRT-03: do_pre_login debug1: JRT-04: do_child Environment: TZ=NZ SSH_CLIENT=xxx.xx.xx.xxx 34811 2222 SSH_CONNECTION=xxx.xx.xx.xxx 34811 xxx.xx.xx.xx 2222 SSH_TTY=/dev/pts/6 TERM=xterm debug1: JRT-05: launch_login However, if I then query the environment of the logged in process, none of the variables have be...

...yfd = s->ptyfd; ttyfd = s->ttyfd; -#if defined(USE_PAM) - do_pam_session(s->pw->pw_name, s->tty); - do_pam_setcred(1); -#endif - /* Fork the child. */ if ((pid = fork()) == 0) { /* Child. Reinitialize the log because the pid has changed. */ @@ -609,6 +607,23 @@ else do_pre_login(s); # endif +#endif + +#if defined(USE_PAM) + /* The PAM session code must be after do_login because the + pam_open_session handler in the pam_unix module in + Solaris updates the lastlog file, which causes do_login + to report the current login as the last one. A lastlog + entry...

...o_exec_no_pty(Session *, const char *); - -void do_exec(Session *, const char *); - -void do_login(Session *, const char *); +void do_exec(Session *, const char *, const char *realname); +void do_login(Session *, const char *, const char *realname); #ifdef LOGIN_NEEDS_UTMPX static void do_pre_login(Session *s); #endif @@ -109,8 +109,8 @@ void do_motd(void); int check_quietlogin(Session *, const char *); - -static void do_authenticated1(Authctxt *); - -static void do_authenticated2(Authctxt *); +static void do_authenticated1(Authctxt *, const char *realname); +static void do_authentic...

OpenBSD tree is heading into a lock and this includes OpenSSH. So we are winding up for a 3.5 release. If we can get people to test the current snapshots and report any problems that would improve the odds that your platform won't be broke for 3.5. Issues I know off of right now. 1. I can't test NeXT. So I TRULY need someone in that community to test for me. Last I heard there was

...** --- 126,132 ---- void session_proctitle(Session *s); void do_exec_pty(Session *s, const char *command); void do_exec_no_pty(Session *s, const char *command); + void do_exec(Session *s, const char *command); void do_login(Session *s, const char *command); #ifdef LOGIN_NEEDS_UTMPX void do_pre_login(Session *s); *************** *** 394,411 **** command = NULL; packet_integrity_check(plen, 0, type); } ! if (forced_command != NULL) { ! original_command = command; ! command = forced_command; ! debug("Forced command '%.500s'", forced_command); !...

Could everyone please test the latest snapshots as we will be making a new release soon. If you have any patches you would like us to consider, please resend them to the list ASAP. -d -- | Damien Miller <djm at mindrot.org> \ ``E-mail attachments are the poor man's | http://www.mindrot.org / distributed filesystem'' - Dan Geer