search for: do_part_get_gpt_typ

...------- 1 file changed, 37 insertions(+), 16 deletions(-) diff --git a/daemon/parted.c b/daemon/parted.c index bd81986..5282adb 100644 --- a/daemon/parted.c +++ b/daemon/parted.c @@ -784,8 +784,9 @@ do_part_set_gpt_type(const char *device, int partnum, const char *guid) return 0; } -char * -do_part_get_gpt_type(const char *device, int partnum) +static char * +sgdisk_info_extract_field (const char *device, int partnum, const char *field, + char *(*extract) (const char *path)) { if (partnum <= 0) { reply_with_error ("partition number must be >= 1"); @@ -81...

Hi, attached there are few patches to implement a way to get the label of GPT partitions (refactoring an existing function and adding a new daemon API) and using it in virt-resize to restore them when copying partitions. Thanks, Pino Toscano (3): daemon: parted: refactor sgdisk info parsing code New API: part-get-name (RHBZ#593511). resize: preserve GPT partition names (RHBZ#1060404).

On Tue, Feb 04, 2014 at 04:01:31PM +0100, Pino Toscano wrote: > @@ -832,28 +835,22 @@ do_part_get_gpt_type(const char *device, int partnum) > /* Split the line in 2 at the colon */ > char *colon = strchr (line, ':'); > if (colon) { > -#define SEARCH "Partition GUID code" > - if (colon - line == strlen(SEARCH) && > - memcmp (line,...

...(value[0] == '"' && value[value_len - 1] == '"'))) { + value_len -= 2; + ++value; + } + + char *ret = strndup (value, value_len); + if (ret == NULL) { + reply_with_perror ("strndup"); + return NULL; + } + + return ret; +} + char * do_part_get_gpt_type (const char *device, int partnum) { return sgdisk_info_extract_field (device, partnum, "Partition GUID code", extract_uuid); } + +char * +do_part_get_name (const char *device, int partnum) +{ + char *parttype = do_part_get_parttype (device); +...

...ULL, &err, str_sgdisk, device, "-t", typecode, NULL); + + if (r == -1) { + reply_with_error ("%s %s -t %s: %s", str_sgdisk, device, typecode, err); + free (typecode); + free (err); + return -1; + } + free (typecode); + free (err); + + return 0; +} + +char * +do_part_get_gpt_type(const char *device, int partnum) +{ + if (partnum <= 0) { + reply_with_error ("partition number must be >= 1"); + return NULL; + } + + char *partnum_str = NULL; + if (asprintf (&partnum_str, "%i", partnum) == -1) { + reply_with_perror ("asprintf&quot...

virt-resize didn't preserve the per-partition GPT GUID. Now that guests using UEFI are becoming common (basically it's the default on aarch64) we need to take into account that sometimes the partition GUID is used by the bootloader NVRAM variables to identify the boot partition, so it must be preserved across resize. This bug caused the 'virt-builder --size' option to fail on

I think this fixes everything mentioned: - Added the Optgroups module as suggested. - Remove command temporary files. - Replace command ~flags with ?fold_stdout_on_stderr. - Nest _with_mounted function. - Rebase & retest. Rich.

v1 was posted here: https://www.redhat.com/archives/libguestfs/2017-July/msg00098.html This series now depends on two small patches which I posted separately: https://www.redhat.com/archives/libguestfs/2017-July/msg00207.html https://www.redhat.com/archives/libguestfs/2017-July/msg00209.html v1 -> v2: - Previously changes to generator/daemon.ml were made incrementally through the patch

Previously posted as part of the mega utilities/inspection series here: https://www.redhat.com/archives/libguestfs/2017-June/msg00232.html What I've done is to extract just the parts related to rewriting daemon APIs in OCaml, rebase them on top of the current master, fix a few things, and recompile and test everything. Rich.

v6 was posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00103.html and this requires the utilities refactoring posted here: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html Inspection is now complete[*], although not very well tested. I'm intending to compare the output of many guests using old & new virt-inspector to see if I can find any

v5: https://www.redhat.com/archives/libguestfs/2017-June/msg00065.html Since v5, this now implements inspection almost completely for Linux and Windows guests. Rich.

v7 was: https://www.redhat.com/archives/libguestfs/2017-June/msg00169.html https://www.redhat.com/archives/libguestfs/2017-June/msg00184.html I believe this addresses all comments received so far. Also it now passes a test where I compared about 100 disk images processed with old and new virt-inspector binaries. The output is identical in all cases except one which is caused by a bug in blkid