search for: do_mktemp

...hopefully developers can answer: - In direct-write mode, I open without O_EXCL, as the file likely does exist. Should the destination file be deleted instead? (I do not know what exactly the race condition is) - There is a section after the assignment of fnametmp, and before the open that does do_mktemp, then receive_data. What is the purpose of this part? I skip it for direct-write, and it works, but what do I know? -don -------------- next part -------------- Only in rsync-2.4.6-direct-write/lib: dummy diff -ru rsync-2.4.6/options.c rsync-2.4.6-direct-write/options.c --- rsync-2.4.6/options...

...TFILES | 2 ++ src/MAX_PROC_NR | 2 +- 5 files changed, 104 insertions(+), 3 deletions(-) diff --git a/daemon/dir.c b/daemon/dir.c index aed45d6..b58cc2a 100644 --- a/daemon/dir.c +++ b/daemon/dir.c @@ -212,3 +212,64 @@ do_mkdtemp (const char *template) return r; } + +char * +do_mktemp (const char *template, + int dir, + const char *suffix) +{ + char *dest_name = NULL; + size_t suffix_len = 0; + char *r; + int err; + if (!(optargs_bitmask & GUESTFS_MKTEMP_DIR_BITMASK)) + dir = 0; + + if (optargs_bitmask & GUESTFS_MKTEMP_SUFFIX_BITMASK) { +...

The following code in receiver.c around line 421 (2.5.6pre1) contains some dead code: /* we initially set the perms without the setuid/setgid bits to ensure that there is no race condition. They are then correctly updated after the lchown. Thanks to snabb@epipe.fi for pointing this out. We also set it initially without group access