search for: do_mkf

...----------------- 2 files changed, 66 insertions(+), 21 deletions(-) diff --git a/daemon/mkfs.c b/daemon/mkfs.c index 95ab874..2994307 100644 --- a/daemon/mkfs.c +++ b/daemon/mkfs.c @@ -36,7 +36,7 @@ GUESTFSD_EXT_CMD(str_mkfs, mkfs); /* Takes optional arguments, consult optargs_bitmask. */ int do_mkfs (const char *fstype, const char *device, int blocksize, - const char *features, int inode, int sectorsize) + const char *features, int inode, int sectorsize, const char *label) { const char *argv[MAX_ARGS]; size_t i = 0; @@ -194,6 +194,47 @@ do_mkfs (const char *fstype, cons...

Hi, easy series to improve the support for f2fs filesystems: while we should be able to mount them already (if the used kernel has the support for this filesystem), put in the appliance f2fs-tools, so we can also create them. Unfortunately, there isn't much in f2fs-tools, so all that can be done is simply setting a different label only when creating a filesystem. Thanks, Pino Toscano (2):

On Fri, Apr 21, 2023 at 03:35:01PM +0800, Joseph Qi wrote: > Hi, > Could you please share a reproducer? > Anyone could access & download the URL [1] (I wrote it in patch commit log) without register SUSE account. Please check attachment file, which I downloaded from [1] and modified under the BZ comment 1. The trigger method is also in comment 1, I copy here: ./defragfs_test.sh -d

Pass -L $LABEL to set the label of a f2fs filesystem when creating it. --- daemon/mkfs.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/daemon/mkfs.c b/daemon/mkfs.c index cef3574..a0617a0 100644 --- a/daemon/mkfs.c +++ b/daemon/mkfs.c @@ -228,6 +228,10 @@ do_mkfs (const char *fstype, const char *device, int blocksize, ADD_ARG (argv, i, "-L"); ADD_ARG (argv, i, label); } + else if (STREQ (fstype, "f2fs")) { + ADD_ARG (argv, i, "-l"); + ADD_ARG (argv, i, label); + } else { reply_wit...

...518, <PIPE> line 1. With this patch, the error goes away and partitionless disks can be created. --- daemon/mkfs.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/daemon/mkfs.c b/daemon/mkfs.c index e753d9a..ee0e9d1 100644 --- a/daemon/mkfs.c +++ b/daemon/mkfs.c @@ -96,6 +96,11 @@ do_mkfs (const char *fstype, const char *device, int blocksize, ADD_ARG (argv, i, "-O"); } + /* Force mkfs.fat to create a whole disk filesystem (RHBZ#1039995). */ + if (STREQ (fstype, "fat") || STREQ (fstype, "vfat") || + STREQ (fstype, "msdos")) +...

This simple patch adds support for the BSD "growfs" command, so you can grow BSD filesystems [in theory -- see below]. It also adds a new optional group called "ufsutils" which indicates if the libguestfs API supports the guestfs_ufs_growfs call, since it's not available on Fedora. (http://libguestfs.org/guestfs.3.html#availability) I tested this on Debian, and although

...e(find_partitions)) return NULL; + + /* Sort the partition list */ + sort_strings (r, size-1); + + /* NULL-terminate the partition list */ + if (add_string (&r, &size, &alloc, NULL) == -1) { return NULL; } - sort_strings (r, size-1); return r; } @@ -179,3 +147,58 @@ do_mkfs (char *fstype, char *device) free (err); return 0; } + +static int +foreach_block_device (block_dev_func_t func) +{ + DIR *dir; + struct dirent *d; + int success = 1; + + dir = opendir ("/sys/block"); + if (!dir) { + reply_with_perror ("opendir: /sys/block"); +...

...dv (NULL, &err, mdadm); if (r == -1) { - reply_with_error("%s", err); + reply_with_error ("%s", err); return -1; } return 0; diff --git a/daemon/mkfs.c b/daemon/mkfs.c index da28e86..ee9e46d 100644 --- a/daemon/mkfs.c +++ b/daemon/mkfs.c @@ -86,7 +86,7 @@ do_mkfs (const char *fstype, const char *device, int blocksize, */ if (STREQ (fstype, "reiserfs") || STREQ (fstype, "jfs") || STREQ (fstype, "xfs")) - ADD_ARG(argv, i, "-f"); + ADD_ARG (argv, i, "-f"); /* For GFS, GFS2, assume a si...

Add some warnings. Well, the first patch is a miscellaneous change, but patches 2-5 add some warnings. Rich.

...+51,7 @@ do_btrfs_filesystem_resize (const char *filesystem, int64_t size) size_t i = 0; char size_str[32]; - ADD_ARG (argv, i, "btrfs"); + ADD_ARG (argv, i, str_btrfs); ADD_ARG (argv, i, "filesystem"); ADD_ARG (argv, i, "resize"); @@ -109,7 +114,7 @@ do_mkfs_btrfs (char *const *devices, char nodesize_s[64]; char sectorsize_s[64]; - ADD_ARG (argv, i, "mkfs.btrfs"); + ADD_ARG (argv, i, str_mkfs_btrfs); /* Optional arguments. */ if (optargs_bitmask & GUESTFS_MKFS_BTRFS_ALLOCSTART_BITMASK) { @@ -225,7 +230,7 @@ do_btrfs_sub...

...+51,7 @@ do_btrfs_filesystem_resize (const char *filesystem, int64_t size) size_t i = 0; char size_str[32]; - ADD_ARG (argv, i, "btrfs"); + ADD_ARG (argv, i, str_btrfs); ADD_ARG (argv, i, "filesystem"); ADD_ARG (argv, i, "resize"); @@ -109,7 +114,7 @@ do_mkfs_btrfs (char *const *devices, char nodesize_s[64]; char sectorsize_s[64]; - ADD_ARG (argv, i, "mkfs.btrfs"); + ADD_ARG (argv, i, str_mkfs_btrfs); /* Optional arguments. */ if (optargs_bitmask & GUESTFS_MKFS_BTRFS_ALLOCSTART_BITMASK) { @@ -225,7 +230,7 @@ do_btrfs_sub...

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-

...103,7 @@ do_btrfs_filesystem_resize (const char *filesystem, int64_t size) size_t i = 0; char size_str[32]; - ADD_ARG (argv, i, str_btrfs); + ADD_ARG (argv, i, "btrfs"); ADD_ARG (argv, i, "filesystem"); ADD_ARG (argv, i, "resize"); @@ -169,7 +162,7 @@ do_mkfs_btrfs (char *const *devices, return -1; } - ADD_ARG (argv, i, str_mkfs_btrfs); + ADD_ARG (argv, i, "mkfs.btrfs"); /* Optional arguments. */ if (optargs_bitmask & GUESTFS_MKFS_BTRFS_ALLOCSTART_BITMASK) { @@ -290,7 +283,7 @@ do_btrfs_subvolume_snapshot (const char *...

This rather complex set of patches allow non-optargs functions to gain optional arguments, while preserving source and binary backwards compatibility. The problem is that we cannot add an optional argument to an existing function. For example, we might want to add flags to the 'lvresize' API which currently has no optional arguments.

This is a simpler patch that removes GUESTFSD_EXT_CMD completely.

...106,7 @@ do_btrfs_filesystem_resize (const char *filesystem, int64_t size) size_t i = 0; char size_str[32]; - ADD_ARG (argv, i, str_btrfs); + ADD_ARG (argv, i, "btrfs"); ADD_ARG (argv, i, "filesystem"); ADD_ARG (argv, i, "resize"); @@ -169,7 +165,7 @@ do_mkfs_btrfs (char *const *devices, return -1; } - ADD_ARG (argv, i, str_mkfs_btrfs); + ADD_ARG (argv, i, "mkfs.btrfs"); /* Optional arguments. */ if (optargs_bitmask & GUESTFS_MKFS_BTRFS_ALLOCSTART_BITMASK) { @@ -290,7 +286,7 @@ do_btrfs_subvolume_snapshot (const char *...

Replace GUESTFSD_EXT_CMD with a command line option ‘./guestfsd --print-external-commands’