search for: do_lgetxattrs

Move all the common code to a new _getxattr function, much like done for other xattrs operations. Mostly code motion, no functional changes. --- daemon/xattr.c | 54 +++++++++++------------------------------------------- 1 file changed, 11 insertions(+), 43 deletions(-) diff --git a/daemon/xattr.c b/daemon/xattr.c index abed5ff..d8ad59a 100644 --- a/daemon/xattr.c +++ b/daemon/xattr.c @@ -55,6

...on/xattr.c index 2445748..1b98555 100644 --- a/daemon/xattr.c +++ b/daemon/xattr.c @@ -520,55 +520,55 @@ optgroup_linuxxattrs_available (void) guestfs_int_xattr_list * do_getxattrs (const char *path) { - NOT_AVAILABLE (NULL); + NOT_AVAILABLE (linuxxattrs, NULL); } guestfs_int_xattr_list * do_lgetxattrs (const char *path) { - NOT_AVAILABLE (NULL); + NOT_AVAILABLE (linuxxattrs, NULL); } int do_setxattr (const char *xattr, const char *val, int vallen, const char *path) { - NOT_AVAILABLE (-1); + NOT_AVAILABLE (linuxxattrs, -1); } int do_lsetxattr (const char *xattr, const char *val, i...

On Tuesday 07 January 2014 21:04:36 Richard W.M. Jones wrote: > On Tue, Jan 07, 2014 at 04:06:43PM +0100, Pino Toscano wrote: > > diff --git a/daemon/xattr.c b/daemon/xattr.c > > index af8bfd4..97a94d5 100644 > > --- a/daemon/xattr.c > > +++ b/daemon/xattr.c > > @@ -545,8 +545,98 @@ do_lgetxattr (const char *path, const char > > *name, size_t *size_r)>

Hi, attached there is a prototype of patch for adding a new copy-attributes command. Such command would allow copy the attributes of a "file" to another, so for example in guestfish: copy-attributes foo bar permissions:true xattributes:false would only copy the permissions of foo to bar, not copying its extended attributes too. Just few notes: - my first daemon command, so

This allows one to copy attributes (like permissions, xattrs, ownership) from a file to another. --- daemon/daemon.h | 3 + daemon/file.c | 72 ++++++++++++++++++++++ daemon/xattr.c | 69 +++++++++++++++++++++ fish/Makefile.am | 1 + fish/test-file-attrs.sh | 157 ++++++++++++++++++++++++++++++++++++++++++++++++ generator/actions.ml | 38 ++++++++++++

On Tue, Jan 07, 2014 at 04:06:43PM +0100, Pino Toscano wrote: > Hi, > > attached there is a prototype of patch for adding a new copy-attributes > command. Such command would allow copy the attributes of a "file" to > another, so for example in guestfish: > copy-attributes foo bar permissions:true xattributes:false > would only copy the permissions of foo to bar,

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-