search for: do_getgraphicsev

Hey all. Setting a time limit with setTimeLimit(), and then using getGraphicsEvent(), will cause graphics event handling for the current device to break on timeout, until the device is destroyed and recreated. The problem lies in do_getGraphicsEvent() checking the value of dd->gettingEvent and concluding it's being called recursively (ironically this same test fails to detect actual recursion). The gettingEvent value is not reset on error conditions, so the device becomes unusable for the remainder of its life. As far as I've be...

...nested too deeply: infinite recursion / options(expressions=)? A quick scan of the SVN logs suggests this code has been untouched since its introduction in 2004, so I'm left to wonder if this is intended behavior. It stands out as a bit of a sore thumb due to the generic check for recursion in do_getGraphicsEvent() in the same file, which will error out with error(_("recursive use of 'getGraphicsEvent' not supported")) if dd->gettingEvent is already set to TRUE. Which would suggest recursively calling it is very much not intended to be possible. To me, setting gettingEvent to FALSE...

...ons(expressions=)? >> >> A quick scan of the SVN logs suggests this code has been untouched since >> its introduction in 2004, so I'm left to wonder if this is intended >> behavior. It stands out as a bit of a sore thumb due to the generic >> check for recursion in do_getGraphicsEvent() in the same file, which >> will error out with error(_("recursive use of 'getGraphicsEvent' not >> supported")) if dd->gettingEvent is already set to TRUE. Which would >> suggest recursively calling it is very much not intended to be possible. >> &g...

...ecursion / > options(expressions=)? > > A quick scan of the SVN logs suggests this code has been untouched since > its introduction in 2004, so I'm left to wonder if this is intended > behavior. It stands out as a bit of a sore thumb due to the generic > check for recursion in do_getGraphicsEvent() in the same file, which > will error out with error(_("recursive use of 'getGraphicsEvent' not > supported")) if dd->gettingEvent is already set to TRUE. Which would > suggest recursively calling it is very much not intended to be possible. > > To me, settin...

...be available to the linker in the current build script for gevents.c's module, which would make it a more invasive patch to use. I'm also not certain it'd work the way I'd want it to, from looking at its internals. As far as I can tell, the prompt value is only used in two places; do_getGraphicsEvent() in src/main/gevents.c, and GA_eventHelper() in library/grDevices/src/devWindows.c. The latter has a sanity check for string-ness already, so making NA a possibility should be safe there, as well. That apparent lack of use elsewhere leads me to a question about the help file for getGraphicsEve...