Displaying 4 results from an estimated 4 matches for "do_generic".
2019 Apr 22
1
[PATCH v5 1/6] libnvdimm: nd_region flush callback support
...; else
>> > object->op(object);
>> >
>> > ...in hot paths?
>>
>> I don't think nvdimm_flush is a hot path. Numbers of some
>> representative workload would prove one of us right.
>
> I'd rather say that the if "if (!op) do_generic()" pattern is more
> readable in the general case, saves grepping for who set the op in the
> common case. The fact that it has the potential to be faster is gravy
> at that point.
If the primary motivation is performance, then I'd expect performance
numbers to back it up. If th...
2019 Apr 22
2
[PATCH v5 1/6] libnvdimm: nd_region flush callback support
Dan Williams <dan.j.williams at intel.com> writes:
> On Thu, Apr 18, 2019 at 9:18 AM Christoph Hellwig <hch at infradead.org> wrote:
>>
>> On Thu, Apr 18, 2019 at 09:05:05AM -0700, Dan Williams wrote:
>> > > > I'd either add a comment about avoiding retpoline overhead here or just
>> > > > make ->flush == NULL mean
2019 Apr 22
2
[PATCH v5 1/6] libnvdimm: nd_region flush callback support
Dan Williams <dan.j.williams at intel.com> writes:
> On Thu, Apr 18, 2019 at 9:18 AM Christoph Hellwig <hch at infradead.org> wrote:
>>
>> On Thu, Apr 18, 2019 at 09:05:05AM -0700, Dan Williams wrote:
>> > > > I'd either add a comment about avoiding retpoline overhead here or just
>> > > > make ->flush == NULL mean
2019 Apr 22
0
[PATCH v5 1/6] libnvdimm: nd_region flush callback support
...generic_op(object);
> > else
> > object->op(object);
> >
> > ...in hot paths?
>
> I don't think nvdimm_flush is a hot path. Numbers of some
> representative workload would prove one of us right.
I'd rather say that the if "if (!op) do_generic()" pattern is more
readable in the general case, saves grepping for who set the op in the
common case. The fact that it has the potential to be faster is gravy
at that point.