search for: do_checksum

Just call close on the specified fd, if valid. --- daemon/daemon.h | 3 +++ daemon/guestfsd.c | 9 +++++++++ 2 files changed, 12 insertions(+) diff --git a/daemon/daemon.h b/daemon/daemon.h index fb74e91..0caad45 100644 --- a/daemon/daemon.h +++ b/daemon/daemon.h @@ -173,6 +173,7 @@ asprintf_nowarn (char **strp, const char *fmt, ...) extern void cleanup_free (void *ptr); extern void

...e.c: In function ''ossl_x509name_to_der'': ossl_x509name.c:294: warning: pointer targets in assignment differ in signedness gcc -fno-common -g -O2 -pipe -fno-common -I. -I../.. -I../../. - I../.././ext/zlib -DHAVE_ZLIB_H -DOS_CODE=OS_UNIX -c zlib.c zlib.c: In function ''do_checksum'': zlib.c:285: warning: pointer targets in passing argument 2 of ''func'' differ in signedness zlib.c: In function ''zstream_expand_buffer'': zlib.c:440: warning: pointer targets in assignment differ in signedness zlib.c:459: warning: pointer targets in ass...

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-

...---- fish/more.c | 2 +- hivex/hivex.c | 4 +- src/generator.ml | 12 ++++---- 8 files changed, 54 insertions(+), 54 deletions(-) diff --git a/daemon/checksum.c b/daemon/checksum.c index 2423265..499d19d 100644 --- a/daemon/checksum.c +++ b/daemon/checksum.c @@ -36,19 +36,19 @@ do_checksum (const char *csumtype, const char *path) int r; int len; - if (strcasecmp (csumtype, "crc") == 0) + if (STRCASEEQ (csumtype, "crc")) program = "cksum"; - else if (strcasecmp (csumtype, "md5") == 0) + else if (STRCASEEQ (csumtype, "md5&quo...