search for: dnsresolv

On Sun, Nov 14, 2010 at 10:32, Gene Cumm <gene.cumm at gmail.com> wrote: > Per doc/pxelinux.txt, the special PXELINUX filename specification of > "IP address::filename" allows "IP address" to be a DNS recognizable > name. ?If it contains no dots, the domain name (DHCP option 15) is > supposed to be appended to qualify the name. > > Testing PXELINUX 3.86,

...-222,6 +357,7 @@ void parse_dhcp_options(const void *opti * boot_file - boot file name * DNSServers - DNS server IPs * LocalDomain - Local domain name + * DomainSearch - Domain search path * MAC_len, MAC - Client identifier, if MAC_len == 0 * */ diff -upr syslinux-6.03.orig/core/fs/pxe/dnsresolv.c syslinux-6.03/core/fs/pxe/dnsresolv.c --- syslinux-6.03.orig/core/fs/pxe/dnsresolv.c 2014-10-06 17:27:44.000000000 +0100 +++ syslinux-6.03/core/fs/pxe/dnsresolv.c 2015-11-26 16:09:27.904865172 +0000 @@ -93,6 +93,7 @@ __export uint32_t dns_resolv(const char err_t err; struct ip_addr ip;...

...t;>> > >>> > Despite having native network capabilities, UEFI 2.4 (the most >>> > widely deployed at the moment) has no native DNS resolver. I propose >>> > here an implementation more or less inspired by the one found in >>> > core/legacynet/dnsresolv.c. >>> > >>> > Since it's non-trivial, I'd like to ask for a deep review of this >>> > code. I tried to make it as strong as possible against malformed >>> > packets and should be devoided of remote code execution or infinite >>> >...

...lt <sylvain.gault at gmail.com> > > > > Despite having native network capabilities, UEFI 2.4 (the most > > widely deployed at the moment) has no native DNS resolver. I propose > > here an implementation more or less inspired by the one found in > > core/legacynet/dnsresolv.c. > > > > Since it's non-trivial, I'd like to ask for a deep review of this > > code. I tried to make it as strong as possible against malformed > > packets and should be devoided of remote code execution or infinite > > loops (contrary to the legacynet implem...

...s(const void *opti > * boot_file - boot file name > * DNSServers - DNS server IPs > * LocalDomain - Local domain name > + * DomainSearch - Domain search path > * MAC_len, MAC - Client identifier, if MAC_len == 0 > * > */ > diff -upr syslinux-6.03.orig/core/fs/pxe/dnsresolv.c > syslinux-6.03/core/fs/pxe/dnsresolv.c > --- syslinux-6.03.orig/core/fs/pxe/dnsresolv.c 2014-10-06 17:27:44.000000000 > +0100 > +++ syslinux-6.03/core/fs/pxe/dnsresolv.c 2015-11-26 16:09:27.904865172 > +0000 > @@ -93,6 +93,7 @@ __export uint32_t dns_resolv(const char >...

...elinux.asm:2142: error: short jump is out of range pxelinux.asm:2145: error: short jump is out of range conio.inc:101: error: short jump is out of range conio.inc:105: error: short jump is out of range conio.inc:107: error: short jump is out of range conio.inc:110: error: short jump is out of range dnsresolv.inc:281: error: short jump is out of range dnsresolv.inc:283: error: short jump is out of range dnsresolv.inc:290: error: short jump is out of range make: *** [pxelinux.bin] Error 1

...ame >> * DNSServers - DNS server IPs >> * LocalDomain - Local domain name >> + * DomainSearch - Domain search path >> * MAC_len, MAC - Client identifier, if MAC_len == 0 >> * >> */ >> diff -upr syslinux-6.03.orig/core/fs/pxe/dnsresolv.c >> syslinux-6.03/core/fs/pxe/dnsresolv.c >> --- syslinux-6.03.orig/core/fs/pxe/dnsresolv.c 2014-10-06 17:27:44.000000000 >> +0100 >> +++ syslinux-6.03/core/fs/pxe/dnsresolv.c 2015-11-26 16:09:27.904865172 >> +0000 >> @@ -93,6 +93,7 @@ __export uint32...

EFI devices should be allowed to use host names for remote servers. Only adds ipv4 host name functionality for efi devices. Reuses core/fs/pxe/dnsresolv.c parse_dotquad code to implement. Signed-off-by: Lincoln Thurlow <lincoln at isi.edu> --- efi/pxe.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 49 insertions(+) diff --git a/efi/pxe.c b/efi/pxe.c index 5b552b39..366f30fd 100644 --- a/efi/pxe.c +++ b/efi/pxe.c...

...>>>> > Despite having native network capabilities, UEFI 2.4 (the most >>>> > widely deployed at the moment) has no native DNS resolver. I propose >>>> > here an implementation more or less inspired by the one found in >>>> > core/legacynet/dnsresolv.c. >>>> > >>>> > Since it's non-trivial, I'd like to ask for a deep review of this >>>> > code. I tried to make it as strong as possible against malformed >>>> > packets and should be devoided of remote code execution or infinite &...

...e improvement. > > > > As you noted, you don't accommodate timeouts which is probably the > > most critical operation this doesn't have. We can't stay in the query > > forever. jiffies() and ms_timer() are the two available in the core. > > core/legacynet/dnsresolv.c used jiffies() but ms_timer() should be > > dealing with millisecond values, not 55ms jiffies and about CLK_TCK > > jiffies per second. > > Not sure I understand everything correctly. > Currently, the code won't stay in the query forever. It tries every > server once...

..._dec.o lwip/src/core/snmp/asn1_enc.o lwip/src/core/pbuf.o lwip/src/core/sys.o lwip/src/api/netdb.o lwip/src/api/tcpip.o lwip/src/api/sockets.o lwip/src/api/netbuf.o lwip/src/api/netifapi.o lwip/src/api/err.o lwip/src/api/api_msg.o lwip/src/api/api_lib.o lwip/src/arch/sys_arch.o fs/pxe/core.o fs/pxe/dnsresolv.o fs/pxe/ftp.o fs/pxe/ftp_readdir.o fs/pxe/gpxeurl.o fs/pxe/http.o fs/pxe/http_readdir.o fs/pxe/idle.o fs/pxe/isr.o fs/pxe/tcp.o ranlib liblpxelinux.a nasm -f elf -Ox -g -F dwarf -DDATE_STR="''" \ -DHEXDATE="0x54d7efa1" \ -Di386 \ -I/sources/syslinux-6.03/c...

From: Sylvain Gault <sylvain.gault at gmail.com> Despite having native network capabilities, UEFI 2.4 (the most widely deployed at the moment) has no native DNS resolver. I propose here an implementation more or less inspired by the one found in core/legacynet/dnsresolv.c. Since it's non-trivial, I'd like to ask for a deep review of this code. I tried to make it as strong as possible against malformed packets and should be devoided of remote code execution or infinite loops (contrary to the legacynet implementation), but I may have forgotten something. I...

.../asn1_enc.o > lwip/src/core/pbuf.o lwip/src/core/sys.o lwip/src/api/netdb.o > lwip/src/api/tcpip.o lwip/src/api/sockets.o lwip/src/api/netbuf.o > lwip/src/api/netifapi.o lwip/src/api/err.o lwip/src/api/api_msg.o > lwip/src/api/api_lib.o lwip/src/arch/sys_arch.o fs/pxe/core.o > fs/pxe/dnsresolv.o fs/pxe/ftp.o fs/pxe/ftp_readdir.o fs/pxe/gpxeurl.o > fs/pxe/http.o fs/pxe/http_readdir.o fs/pxe/idle.o fs/pxe/isr.o > fs/pxe/tcp.o > ranlib liblpxelinux.a > > nasm -f elf -Ox -g -F dwarf -DDATE_STR="''" \ > -DHEXDATE="0x54d7efa1" \ > -Di38...

...p/src/core/pbuf.o lwip/src/core/sys.o lwip/src/api/netdb.o > > lwip/src/api/tcpip.o lwip/src/api/sockets.o lwip/src/api/netbuf.o > > lwip/src/api/netifapi.o lwip/src/api/err.o lwip/src/api/api_msg.o > > lwip/src/api/api_lib.o lwip/src/arch/sys_arch.o fs/pxe/core.o > > fs/pxe/dnsresolv.o fs/pxe/ftp.o fs/pxe/ftp_readdir.o > > fs/pxe/gpxeurl.o fs/pxe/http.o fs/pxe/http_readdir.o fs/pxe/idle.o > > fs/pxe/isr.o fs/pxe/tcp.o > > ranlib liblpxelinux.a > > > > nasm -f elf -Ox -g -F dwarf -DDATE_STR="''" \ > > -DHEXDATE="0x5...

...e: > > From: Sylvain Gault <sylvain.gault at gmail.com> > > Despite having native network capabilities, UEFI 2.4 (the most widely deployed > at the moment) has no native DNS resolver. I propose here an implementation > more or less inspired by the one found in core/legacynet/dnsresolv.c. > > Since it's non-trivial, I'd like to ask for a deep review of this code. I tried > to make it as strong as possible against malformed packets and should be > devoided of remote code execution or infinite loops (contrary to the legacynet > implementation), but I may have...

...at gmail.com> >> > >> > Despite having native network capabilities, UEFI 2.4 (the most >> > widely deployed at the moment) has no native DNS resolver. I propose >> > here an implementation more or less inspired by the one found in >> > core/legacynet/dnsresolv.c. >> > >> > Since it's non-trivial, I'd like to ask for a deep review of this >> > code. I tried to make it as strong as possible against malformed >> > packets and should be devoided of remote code execution or infinite >> > loops (contrary to...

Digging more, loadfile("192.0.2.1::pxe.0", &file.data, &file.size), queries DNS, which sounds like it doesn't follow the same call path as a COM32 calling pxe_dns(). If the DNS won't resolve the IP, things won't load properly. pxechn.c32 sets sname in the intended packet to "192.0.2.1" which may be confusing something. More debugging needed. -- -Gene

...659e2a143faeffc77877b45754c52: Matt Fleming (1): Merge branch 'dynamic-debug' into elflink are available in the git repository at: git://github.com/geneC/syslinux.git pxe-dns-dotquad-for-mfleming Gene Cumm (1): core/legacynet: Enable dot quad resolution core/legacynet/dnsresolv.c | 35 +++++++++++++++++++++++++++++++++++ 1 files changed, 35 insertions(+), 0 deletions(-)

...olv.c is quite different and doesn't bother > testing quads first. > > Matt/HPA: should this be patched or somehow checked to see if it can > be factored away? I've got a crude patch that I can clean up. > > -- > -Gene Also, com32/lib/syslinux.c:pxe_dns() and core/pxe/dnsresolv.c:dns_resolv() (and now possibly core/legacynet/dns_resolv.c:dns_resolv()) both attempt to parse a dotted quad (duplicating effort that could likely be refactored). -- -Gene

...(error) Possible null pointer dereference: buf [com32/sysdump/memmap.c:52]: (error) Possible null pointer dereference: buf Probably false positive. cppcheck has problems to recognize memory allocation on demand. ----------------------------------------------------------------- [core/fs/pxe/dnsresolv.c:107]: (error) Uninitialized variable: ip Probably false positive. ----------------------------------------------------------------- [core/fs/xfs/xfs_dir2.c:588]: (error) Uninitialized variable: irec ... [core/fs/xfs/xfs_dir2.c:584]: (error) Uninitialized struct member: irec.br_blockcount...