search for: dma_xx

On 19/04/2018 19:35, Michael S. Tsirkin wrote: > virtio is using barriers to order memory accesses, thus > dma_wmb/rmb is a good match. > > Build-tested on x86: Before > > [mst at tuck linux]$ size drivers/virtio/virtio_ring.o > text data bss dec hex filename > 11392 820 0 12212 2fb4 drivers/virtio/virtio_ring.o > > After > mst

On 19/04/2018 19:46, Michael S. Tsirkin wrote: >> This should be okay, but I wonder if there should be a virtio_wmb(...) >> or an "if (weak_barriers) wmb()" before the "writel" in vm_notify >> (drivers/virtio/virtio_mmio.c). >> >> Thanks, >> >> Paolo > That one uses weak barriers AFAIK. > > IIUC you mean rproc_virtio_notify.

On Thu, Apr 19, 2018 at 07:39:21PM +0200, Paolo Bonzini wrote: > On 19/04/2018 19:35, Michael S. Tsirkin wrote: > > virtio is using barriers to order memory accesses, thus > > dma_wmb/rmb is a good match. > > > > Build-tested on x86: Before > > > > [mst at tuck linux]$ size drivers/virtio/virtio_ring.o > > text data bss dec hex

On Thu, Apr 19, 2018 at 07:39:21PM +0200, Paolo Bonzini wrote: > On 19/04/2018 19:35, Michael S. Tsirkin wrote: > > virtio is using barriers to order memory accesses, thus > > dma_wmb/rmb is a good match. > > > > Build-tested on x86: Before > > > > [mst at tuck linux]$ size drivers/virtio/virtio_ring.o > > text data bss dec hex

virtio is using barriers to order memory accesses, thus dma_wmb/rmb is a good match. Build-tested on x86: Before [mst at tuck linux]$ size drivers/virtio/virtio_ring.o text data bss dec hex filename 11392 820 0 12212 2fb4 drivers/virtio/virtio_ring.o After mst at tuck linux]$ size drivers/virtio/virtio_ring.o text data bss dec hex filename

virtio is using barriers to order memory accesses, thus dma_wmb/rmb is a good match. Build-tested on x86: Before [mst at tuck linux]$ size drivers/virtio/virtio_ring.o text data bss dec hex filename 11392 820 0 12212 2fb4 drivers/virtio/virtio_ring.o After mst at tuck linux]$ size drivers/virtio/virtio_ring.o text data bss dec hex filename

...If set - driver must use barriers suitable for hardware devices. > > + */ > > +#define VIRTIO_F_IO_BARRIER 37 > > #endif /* _UAPI_LINUX_VIRTIO_CONFIG_H */ > > Hi: > > I believe this depends on Michael's patch of > > "[PATCH] virtio_ring: switch to dma_XX barriers for rpmsg" > > ? > > Thanks We already have below commit and some other related commits in the tree: 7b21e34fd1c2 ("virtio: harsher barriers for rpmsg.") They should have already guaranteed that virtio_Xmb() will be OK for hardware devices when vq->weak_b...

...If set - driver must use barriers suitable for hardware devices. > > + */ > > +#define VIRTIO_F_IO_BARRIER 37 > > #endif /* _UAPI_LINUX_VIRTIO_CONFIG_H */ > > Hi: > > I believe this depends on Michael's patch of > > "[PATCH] virtio_ring: switch to dma_XX barriers for rpmsg" > > ? > > Thanks We already have below commit and some other related commits in the tree: 7b21e34fd1c2 ("virtio: harsher barriers for rpmsg.") They should have already guaranteed that virtio_Xmb() will be OK for hardware devices when vq->weak_b...

Fixes: 55e49dc43a8 ("virtio_ring: switch to dma_XX barriers for rpmsg") Signed-off-by: Michael S. Tsirkin <mst at redhat.com> --- tools/virtio/asm/barrier.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/virtio/asm/barrier.h b/tools/virtio/asm/barrier.h index 0ac3caf90877..d0351f83aebe 100644 --- a/tools/v...

...> > + */ > > > > +#define VIRTIO_F_IO_BARRIER 37 > > > > #endif /* _UAPI_LINUX_VIRTIO_CONFIG_H */ > > > Hi: > > > > > > I believe this depends on Michael's patch of > > > > > > "[PATCH] virtio_ring: switch to dma_XX barriers for rpmsg" > > > > > > ? > > > > > > Thanks > > We already have below commit and some other related commits > > in the tree: > > > > 7b21e34fd1c2 ("virtio: harsher barriers for rpmsg.") > > > > They...

This patch introduces the support for VIRTIO_F_IO_BARRIER. When this feature is negotiated, driver will use the barriers suitable for hardware devices. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- drivers/virtio/virtio_ring.c | 5 +++++ include/uapi/linux/virtio_config.h | 8 +++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c

This patch introduces the support for VIRTIO_F_IO_BARRIER. When this feature is negotiated, driver will use the barriers suitable for hardware devices. Signed-off-by: Tiwei Bie <tiwei.bie at intel.com> --- drivers/virtio/virtio_ring.c | 5 +++++ include/uapi/linux/virtio_config.h | 8 +++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/virtio/virtio_ring.c

...use barriers suitable for CPU cores. > + * If set - driver must use barriers suitable for hardware devices. > + */ > +#define VIRTIO_F_IO_BARRIER 37 > #endif /* _UAPI_LINUX_VIRTIO_CONFIG_H */ Hi: I believe this depends on Michael's patch of "[PATCH] virtio_ring: switch to dma_XX barriers for rpmsg" ? Thanks

...use barriers suitable for hardware devices. >>> + */ >>> +#define VIRTIO_F_IO_BARRIER 37 >>> #endif /* _UAPI_LINUX_VIRTIO_CONFIG_H */ >> Hi: >> >> I believe this depends on Michael's patch of >> >> "[PATCH] virtio_ring: switch to dma_XX barriers for rpmsg" >> >> ? >> >> Thanks > We already have below commit and some other related commits > in the tree: > > 7b21e34fd1c2 ("virtio: harsher barriers for rpmsg.") > > They should have already guaranteed that virtio_Xmb() will >...

...------------- virtio, vhost: features, fixes VF support for virtio. DMA barriers for virtio strong barriers. Bugfixes. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Michael S. Tsirkin (2): virtio_ring: switch to dma_XX barriers for rpmsg vhost: fix info leak due to uninitialized memory Tiwei Bie (2): virtio_pci: support enabling VFs virtio: update the comments for transport features drivers/vhost/vhost.c | 3 +++ drivers/virtio/virtio_pci_common.c | 30 ++++++++++++++++++++++++++...

...support for virtio. Free page hint request support for VM migration. DMA barriers for virtio strong barriers. Bugfixes. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Michael S. Tsirkin (2): virtio_ring: switch to dma_XX barriers for rpmsg vhost: fix info leak due to uninitialized memory Tiwei Bie (2): virtio_pci: support enabling VFs virtio: update the comments for transport features Wei Wang (4): mm: support reporting free page blocks virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT...

...support for virtio. Free page hint request support for VM migration. DMA barriers for virtio strong barriers. Bugfixes. Signed-off-by: Michael S. Tsirkin <mst at redhat.com> ---------------------------------------------------------------- Michael S. Tsirkin (2): virtio_ring: switch to dma_XX barriers for rpmsg vhost: fix info leak due to uninitialized memory Tiwei Bie (2): virtio_pci: support enabling VFs virtio: update the comments for transport features Wei Wang (4): mm: support reporting free page blocks virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT...