search for: dlmmaster

...a memleak situation in dlm_add_migration_mle(). When a mle found, it will be removed from dlm->hlist. If there is no pointer to it at that moment, the mle will become an ?orphan mle? that no process can find and release. Signed-off-by: Xuejiufei <xuejiufei at huawei.com> --- fs/ocfs2/dlm/dlmmaster.c | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c index 005261c..20d2307 100644 --- a/fs/ocfs2/dlm/dlmmaster.c +++ b/fs/ocfs2/dlm/dlmmaster.c @@ -284,6 +284,7 @@ static void dlm_init_mle(struct dlm_master_list_e...

...stringify_lockname(res->lockname.name, ...); --> Line 493 in dlmdebug.c (Access res->lockname.name) scnprintf(..., res->owner, ...); -->Line 498 in dlmdebug.c (Access res->owner) However, in the following calling contexts: dlm_deref_lockres_worker() --> Line 2439 in dlmmaster.c dlm_drop_lockres_ref_done() --> Line 2459 in dlmmaster.c lockname = res->lockname.name; --> Line 2416 in dlmmaster.c (Access res->lockname.name) dlm_get_lock_resource() --> Line 701 in dlmmaster.c if (res->owner != dlm->node_num) --> Line 1023 in dlmmaster...

Hi, I've found some possible deadlock in fs/ocfs2/dlm/dlmmaster.c - version 2.6.28 (probably this code is in newer versions too). Could someone confirm this? Thank you. fs/ocfs2/dlm/dlmmaster.c ================== function dlm_master_request_handler: (res->spinlock <- dlm->master_lock) ----------------------------------- spin_lock(&res->spinlo...

....name, ...); --> Line 493 in > dlmdebug.c (Access res->lockname.name) > scnprintf(..., res->owner, ...); -->Line 498 in dlmdebug.c (Access > res->owner) > > However, in the following calling contexts: > > dlm_deref_lockres_worker() --> Line 2439 in dlmmaster.c > dlm_drop_lockres_ref_done() --> Line 2459 in dlmmaster.c > lockname = res->lockname.name; --> Line 2416 in dlmmaster.c (Access > res->lockname.name) lockname won't changed during the lockres lifecycle. So this won't cause any real problem since now it hol...

These patches convert the mle list to a hash. The same patches apply on ocfs2 1.4 too. Currently, we use the same number of hash pages for mles and lockres'. This will be addressed in a future patch that will make both of them configurable. Sunil

The changes from the last drop are: 1. Patch 11 removes struct dlm_lock_name. 2. Patch 12 is an unrelated bugfix. Actually is related to a bugfix that we are retracting in mainline currently. The patch may need more testing. While I did hit the condition in my testing, Marcos hasn't. I am sending it because it can be queued for 2.6.30. Give us more time to test. 3. Patch 13 will be useful

...t it started with some problems on node 7 (esiprap01). It reported o2hb_write_timeout error and it rebooted automatically. Could you please explain what have happend with other nodes? Some of them reported bug: kernel BUG at /tmp/buildd/linux-2.6-2.6.32/debian/build/source_amd64_none/fs/ocfs2/dlm/dlmmaster.c:241! one of them (es1prap03 - node 4) reported: kernel BUG at /tmp/buildd/linux-2.6-2.6.32/debian/build/source_amd64_none/fs/ocfs2/dlm/dlmmaster.c:3260! We've had a problem to start the claster again. While one node was starting the other crashed (logged some stack strace - see attachments...

...cluster and the Nodes reboots during this time . Does anybody knows what is causing this issue? Do we need to upgrade our OCFS . We are running Oracle9i RAC on Linux (Redhat ) $ uname -r 2.6.9-55.ELsmp Mar 23 06:03:55 oradb02 kernel: kernel BUG at /rpmbuild/smushran/BUILD/ocfs2-1.2.9/fs/ocfs2/dlm/dlmmaster.c:2300! Mar 23 06:03:55 oradb02 kernel: invalid operand: 0000 [#1] Regards Jabulani -------------- next part -------------- An HTML attachment was scrubbed... URL: http://oss.oracle.com/pipermail/ocfs2-users/attachments/20100323/3ef9f00f/attachment-0001.html

...ngify_lockname(res->lockname.name, ...);? --> Line 493 in dlmdebug.c (Access res->lockname.name) ????? scnprintf(..., res->owner, ...);? -->Line 498 in dlmdebug.c (Access res->owner) However, in the following calling contexts: ? dlm_deref_lockres_worker() --> Line 2439 in dlmmaster.c ??? dlm_drop_lockres_ref_done() --> Line 2459 in dlmmaster.c ????? lockname = res->lockname.name; --> Line 2416 in dlmmaster.c (Access res->lockname.name) ? dlm_get_lock_resource() --> Line 701 in dlmmaster.c ??? if (res->owner != dlm->node_num) --> Line 1023 in dlmm...

Mainline commit d4f7e650e55af6b235871126f747da88600e8040 attempts to delay the dlm_thread from sending the drop ref message if the lockres is being migrated. The problem is that we make the dlm_thread wait for the migration to complete. This causes a deadlock as dlm_thread also participates in the lockres migration process. A better fix for the original oss bugzilla#1012 is in testing.

...de_heartbeating_from_callback - cluster/heartbeat.c: o2hb_stop_all_regions - cluster/nodemanager.c: o2nm_get_node_by_num - cluster/nodemanager.c: o2nm_configured_node_map - cluster/nodemanager.c: o2nm_get_node_by_ip - cluster/nodemanager.c: o2nm_node_put - cluster/nodemanager.c: o2nm_node_get - dlm/dlmmaster.c: dlm_migrate_lockres Signed-off-by: Adrian Bunk <bunk at stusta.de> --- fs/ocfs2/cluster/heartbeat.c | 2 -- fs/ocfs2/cluster/nodemanager.c | 5 ----- fs/ocfs2/dlm/dlmmaster.c | 1 - 3 files changed, 8 deletions(-) --- linux-2.6.17-rc1-mm2-full/fs/ocfs2/cluster/heartbe...

Please review the list of patches being applied to the ocfs2 1.4 tree. All patches list the mainline commit hash. Thanks Sunil

Found 15 patches (out of 162) that appeared relevant to ocfs2 1.4. Please review. Sunil

...t;lock waiting for the dlm->master_lock, with the function dlm_master_request_handler. Another task holds the &dlm->master_lock waiting for the res->lock with dlm_get_lock_resource. So the deadlock may be up. I changed some code, and the patch request reviews. *** ocfs2-ko-3.16/dlm/dlmmaster.c 2014-09-11 12:45:45.821657634 +0800 --- ocfs2-ko-3.16_compared/dlm/dlmmaster.c 2014-09-11 18:54:34.970243238 +0800 *************** way_up_top: *** 1506,1512 **** --- 1506,1515 ---- } // mlog(0, "lockres is in progress...\n"); + spin_unl...

...t;lock waiting for the dlm->master_lock, with the function dlm_master_request_handler. Another task holds the &dlm->master_lock waiting for the res->lock with dlm_get_lock_resource. So the deadlock may be up. I changed some code, and the patch request reviews. *** ocfs2-ko-3.16/dlm/dlmmaster.c 2014-09-11 12:45:45.821657634 +0800 --- ocfs2-ko-3.16_compared/dlm/dlmmaster.c 2014-09-11 18:54:34.970243238 +0800 *************** way_up_top: *** 1506,1512 **** --- 1506,1515 ---- } // mlog(0, "lockres is in progress...\n"); + spin_unl...

Hi, i dont seem to be able to get ocfs running on RH3 U8 32Bit [root@libra-devb-db1 root]# uname -a Linux devb-db1.mydomain 2.4.21-47.ELsmp #1 SMP Wed Jul 5 20:38:41 EDT 2006 i686 athlon i386 GNU/Linux [root@devb-db1 root]# cat /etc/redhat-release Red Hat Enterprise Linux AS release 3 (Taroon Update 8) [root@devb-db1 root]# rpm -ivh ocfs-2.4.21-EL-smp-1.0.14-1.i686.rpm Preparing...

...r allocation strategy. These have been around since early June, so I think they've had enough testing that they can go upstream. Please pull from 'upstream-linus' branch of git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git to receive the following updates: fs/ocfs2/dlm/dlmmaster.c | 1 fs/ocfs2/dlm/dlmunlock.c | 43 +++---- fs/ocfs2/localalloc.c | 8 + fs/ocfs2/ocfs2.h | 2 fs/ocfs2/suballoc.c | 261 +++++++++++++++++++++++++++++++++++++++++------ fs/ocfs2/suballoc.h | 2 fs/ocfs2/super.c | 8 + 7 files changed, 263 inserti...

...put() will not be called during dput(dentry). This patch fixes the oops that accompanies the following message: (3996,1):dlm_empty_lockres:2708 ERROR: lockres W00000000000000000a1046b06a4382 still has local locks! kernel BUG in dlm_empty_lockres at /rpmbuild/smushran/BUILD/ocfs2-1.4.2/fs/ocfs2/dlm/dlmmaster.c:2709! Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com> --- fs/ocfs2/dcache.c | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) diff --git a/fs/ocfs2/dcache.c b/fs/ocfs2/dcache.c index 7d60448..b574431 100644 --- a/fs/ocfs2/dcache.c +++ b/fs/ocfs2/dcache....

...ocfs2/cluster/nodemanager.c | 9 +- fs/ocfs2/dir.c | 2806 ++++++++++++++++++++++++++++++++++++++-- fs/ocfs2/dir.h | 57 +- fs/ocfs2/dlm/dlmcommon.h | 58 +- fs/ocfs2/dlm/dlmdebug.c | 87 +- fs/ocfs2/dlm/dlmdomain.c | 29 +- fs/ocfs2/dlm/dlmmaster.c | 387 +++--- fs/ocfs2/dlm/dlmthread.c | 20 +- fs/ocfs2/dlmglue.c | 46 + fs/ocfs2/dlmglue.h | 2 + fs/ocfs2/export.c | 84 ++- fs/ocfs2/inode.c | 48 +- fs/ocfs2/inode.h | 5 + fs/ocfs2/journal.c...

...tem); + list_for_each_entry_safe(nmh, n, list, nh_unregister_item) { mlog(ML_TCP, "unregistering handler func %p type %u key %08x\n", nmh->nh_func, nmh->nh_msg_type, nmh->nh_key); rb_erase(&nmh->nh_node, &o2net_handler_tree); Index: linux-2.6/fs/ocfs2/dlm/dlmmaster.c =================================================================== --- linux-2.6.orig/fs/ocfs2/dlm/dlmmaster.c 2007-04-30 11:33:04.000000000 +0200 +++ linux-2.6/fs/ocfs2/dlm/dlmmaster.c 2007-05-17 15:00:14.000000000 +0200 @@ -192,25 +192,20 @@ static void dlm_print_one_mle(struct dlm static voi...