search for: dllvm_optimize_tablegen

IIRC the issues with defaulting to –DLLVM_OPTIMIZE_TABLEGEN=ON came up in two places: First, if it's not a Debug build, this actually slows down the build. The defaulting has to be for Debug config only. This is arguably bad UI, because it makes the default modal, but there's a clear benefit in build time so I think we can live with that. Second, i...

...l slow down the build, since > tablegen will get even slower. Ideally, there would be some (perhaps > default?) configuration where we build the tablegen binaries with > optimizations on and then use them in the build, as if we were > cross-compiling. > Maybe something simple like -DLLVM_OPTIMIZE_TABLEGEN=ON (enabled by default for Debug builds). You would need to set it to off only if you want to debug tablegen. > > > On Jan 4, 2019, at 15:14, Davide Italiano via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > Hi, > > I would like to propose, based on a...

...slow down the build, since tablegen will get even slower. Ideally, there would be some (perhaps default?) configuration where we build the tablegen binaries with optimizations on and then use them in the build, as if we were cross-compiling. >> >> >> Maybe something simple like -DLLVM_OPTIMIZE_TABLEGEN=ON (enabled by default for Debug builds). You would need to set it to off only if you want to debug tablegen. > > > I proposed this a while back, but it think there were some problems with it, I don't remember what exactly but maybe related to bootstrapping / 2-stages builds? > >...

...deally, there would be some (perhaps > > default?) configuration where we build the tablegen binaries with > > optimizations on and then use them in the build, as if we were cross- > > compiling. > > >> > > >> > > >> Maybe something simple like -DLLVM_OPTIMIZE_TABLEGEN=ON (enabled by > > default for Debug builds). You would need to set it to off only if you > > want to debug tablegen. > > > > > > > > > I proposed this a while back, but it think there were some problems > with > > it, I don't remember what exactl...

...deally, there would be some (perhaps > > default?) configuration where we build the tablegen binaries with > > optimizations on and then use them in the build, as if we were cross- > > compiling. > > >> > > >> > > >> Maybe something simple like -DLLVM_OPTIMIZE_TABLEGEN=ON (enabled by > > default for Debug builds). You would need to set it to off only if you > > want to debug tablegen. > > > > > > > > > I proposed this a while back, but it think there were some problems with > > it, I don't remember what exactly but...

Hi, I would like to propose, based on a previous discussion on llvm-dev, the following change. https://reviews.llvm.org/D56337 The main motivation for annotating member functions of ADT clases with LLVM_ALWAYS_INLINE was that of speeding up `check-llvm` at `-O0`. Turns out this significantly degrades the debuggability of fundamental classes in llvm itself, e.g. StringRef or SmallVector. After