search for: display_number

https://bugzilla.mindrot.org/show_bug.cgi?id=3730 Bug ID: 3730 Summary: Integer overflow when adding 6000 and display_number Product: Portable OpenSSH Version: 9.8p1 Hardware: Other OS: All Status: NEW Severity: minor Priority: P5 Component: Build system Assignee: unassigned-bugs at mindrot.org Reporter: suhov.ra...

https://bugzilla.mindrot.org/show_bug.cgi?id=3731 Bug ID: 3731 Summary: Integer overflow when adding 6000 and display_number Product: Portable OpenSSH Version: 9.8p1 Hardware: Other OS: All Status: NEW Severity: minor Priority: P5 Component: Build system Assignee: unassigned-bugs at mindrot.org Reporter: suhov.ra...

...variable, or NULL if an error - * occurs. + * Returns a suitable display number for the DISPLAY variable, or -1 if + * an error occurs. */ -char * -x11_create_display_inet(int screen_number, int x11_display_offset) +int +x11_create_display_inet(int x11_display_offset, int gateway_ports) { int display_number, sock; u_short port; struct addrinfo hints, *ai, *aitop; char strport[NI_MAXSERV]; int gaierr, n, num_socks = 0, socks[NUM_SOCKS]; - char display[512]; - char hostname[MAXHOSTNAMELEN]; for (display_number = x11_display_offset; display_number < MAX_DISPLAYS; @@ -2416,12 +2414,12...

...Maximum number of fake X11 displays to try. */ -#define MAX_DISPLAYS 1000 - /* Saved X11 local (client) display. */ static char *x11_saved_display = NULL; @@ -3890,7 +3887,8 @@ */ int x11_create_display_inet(int x11_display_offset, int x11_use_localhost, - int single_connection, u_int *display_numberp, int **chanids) + int max_displays, int single_connection, u_int *display_numberp, + int **chanids) { Channel *nc = NULL; int display_number, sock; @@ -3902,8 +3900,11 @@ if (chanids == NULL) return -1; + /* Try max_displays ports starting at the range 6000+X11DisplayOffset */ + max_d...

...UNIX socket. Therefore a patch (relative to OpenSSH 2.5.1p1) is suggested. Cheers. Andy. *** channels.c.orig Fri Feb 16 16:56:31 2001 --- channels.c Wed Feb 21 11:49:06 2001 *************** *** 1909,1915 **** char * x11_create_display_inet(int screen_number, int x11_display_offset) { ! int display_number, sock; u_short port; struct addrinfo hints, *ai, *aitop; char strport[NI_MAXSERV]; --- 1909,1915 ---- char * x11_create_display_inet(int screen_number, int x11_display_offset) { ! int display_number, sock=-1; u_short port; struct addrinfo hints, *ai, *aitop; char strport[NI...

...S $SCREEN_BPP $GAMMA [snip] Here's the winerun.sh script. Feel free to tweak it to your liking (esp mouse sensitivity). [snip] PROGRAM=$1 SCREEN_RES=$2 SCREEN_BPP=$3 GAMMA=$4 # Sensitivity works according to "xset mouse" MOUSE_SENSITIVITY="1.15/15" # Display number to use DISPLAY_NUMBER=":1" # Nice priority to give to wine. Note some games (ex Starcraft) do not like -20. PRIORITY=-10 # extract APPDIR=${PROGRAM%/*} APPEXE=./${PROGRAM##*/} SCRIPT="xgamma -gamma $GAMMA xset mouse $MOUSE_SENSITIVITY cd \"$HOME/.wine/dosdevices/$APPDIR\" nice $PRIORITY...

...AIX Versions, Solaris and Linux later) configure --with-cppflags=-DLOCALHOST_IN_DISPLAY activates the change *** channels.c Wed Jun 13 21:18:05 2001 --- ../openssh-2.9p2.aix/channels.c Wed Aug 8 14:55:24 2001 *************** *** 2268,2276 **** --- 2268,2282 ---- display_number, screen_number); } #else /* IPADDR_IN_DISPLAY */ + #ifdef LOCALHOST_IN_DISPLAY + /* Just set DISPLAY to localhost:screen.display */ + snprintf(display, sizeof display, "%.400s:%d.%d", "localhost", + display_number, screen_number); + #else...

Hi! Here is the patch to support tcp wrappers with x11-forwarded connections. The patch is for openssh-3.0.1p1 but it works fine with 2.9.9p2 too. I've understood that this will not be included in the official version because it adds complexity (?!) to openssh. Binding the forwarded port to localhost doesn't solve all problems. I've understood that you should also implement

On Mon, Jul 23, 2001 at 12:49:14AM +0100, Matthew Vernon wrote: > ------- start of forwarded message ------- > From: <mouring at etoh.eviladmin.org> > To: Matthew Vernon <matthew at empire.ucam.org> > cc: <openssh-unix-dev at mindrot.org> > Subject: Re: [patch] GNU/Hurd compatibility patches > Date: Sun, 22 Jul 2001 12:39:32 -0500 (CDT) > > > We

...ls.c Sun Oct 29 16:44:49 2000 @@ -1720,7 +1720,7 @@ char strport[NI_MAXSERV]; int gaierr, n, num_socks = 0, socks[NUM_SOCKS]; char display[512]; - char hostname[MAXHOSTNAMELEN]; + char hostname[401]; /* we only use the first 400 bytes anyway*/ for (display_number = x11_display_offset; display_number < MAX_DISPLAYS; @@ -1791,7 +1791,8 @@ /* Set up a suitable value for the DISPLAY variable. */ - if (gethostname(hostname, sizeof(hostname)) < 0) + if (gethostname(hostname, sizeof(hostname)) < 0 + &&amp...

...= 0; i < num_permitted_opens; i++) xfree(permitted_opens[i].host_to_connect); num_permitted_opens = 0; @@ -2448,6 +2494,7 @@ 0, xstrdup("X11 inet listener"), 1); nc->single_connection = single_connection; } + log("X11 forwarding listening on port %d", 6000+display_number); /* Return the display number for the DISPLAY environment variable. */ *display_numberp = display_number; --- channels.h 28 Jan 2003 18:06:51 -0000 1.1.1.2 +++ channels.h 28 Jan 2003 19:06:35 -0000 1.4 @@ -176,7 +177,9 @@ void channel_input_oclose(int, u_int32_t, void *); void channel_in...

Hi, sorry if it is the wrong approuch to suggest improvments to OpenSSH, but here comes my suggestion: I recently stumbled upon the scponly shell which in it's chroot:ed form is an ideal solution when you want to share some files with people you trust more or less. The problem is, if you use the scponlyc as shell, port forwarding is still allowed. This can of course be dissallowed in

Hello, Was looking in the archives... and haven't seen this one listed. When I compile openssh-1.2pre17 on AIX v4.3.3 with the native compiler I get the following errors. I haven't see this __attribute__ code.. What compiler/libraries are needed to compile this? I have seen that people have compiled openssh on AIX.. Just wondering what you have used. # make cc -g