search for: diskstatus

On Sun, Mar 17, 2019 at 2:59 PM Nir Soffer <nsoffer@redhat.com> wrote: > > On Sun, Mar 17, 2019 at 2:07 PM Daniel Erez <derez@redhat.com> wrote: >> >> After invoking transfer_service.finalize, check operation >> status by examining ImageTransferPhase and DiskStatus. >> This is done instead of failing after a predefined timeout >> regardless the status. >> >> * not verified * >> >> Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 >> --- >> v2v/rhv-upload-plugin.py | 26 +++++++++++++++++++++----- >...

This is a patch which Daniel Erez wrote originally. I have modified it only to fix a small bug in the debug() statement, and Ilanit kindly tested it here: https://bugzilla.redhat.com/show_bug.cgi?id=1680361#c38 Rich.

On Sun, Mar 17, 2019 at 3:51 PM Daniel Erez <derez@redhat.com> wrote: > After invoking transfer_service.finalize, check operation > status by examining DiskStatus. > This is done instead of failing after a predefined timeout > regardless the status. > > * not verified * > > Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 > --- > v2v/rhv-upload-plugin.py | 18 +++++++++++++----- > 1 file changed, 13 insertions(+), 5 de...

After invoking transfer_service.finalize, check operation status by examining ImageTransferPhase and DiskStatus. This is done instead of failing after a predefined timeout regardless the status. * not verified * Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 --- v2v/rhv-upload-plugin.py | 26 +++++++++++++++++++++----- 1 file changed, 21 insertions(+), 5 deletions(-) diff --git a/v2v/rhv-up...

On Mon, Sep 9, 2019 at 7:02 PM Richard W.M. Jones <rjones@redhat.com> wrote: > From: Daniel Erez <derez@redhat.com> > > After invoking transfer_service.finalize, check operation status by > examining DiskStatus. This is done instead of failing after a > predefined timeout regardless the status. > > Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 > Signed-off-by: Richard W.M. Jones <rjones@redhat.com> > Tested-by: Ilanit Stein <istein@redhat.com> > --- > v2v/...

On Mon, Mar 18, 2019 at 06:51:26PM +0200, Daniel Erez wrote: > After invoking transfer_service.finalize, check operation > status by examining DiskStatus. > This is done instead of failing after a predefined timeout > regardless the status. > > * not verified * > > Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 > --- > v2v/rhv-upload-plugin.py | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6...

After invoking transfer_service.finalize, check operation status by examining DiskStatus. This is done instead of failing after a predefined timeout regardless the status. * not verified * Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 --- v2v/rhv-upload-plugin.py | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/v2v/rhv-upload-plu...

After invoking transfer_service.finalize, check operation status by examining DiskStatus. This is done instead of failing after a predefined timeout regardless the status. * not verified * Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 --- v2v/rhv-upload-plugin.py | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/v2v/rhv-upload-pl...

From: Daniel Erez <derez@redhat.com> After invoking transfer_service.finalize, check operation status by examining DiskStatus. This is done instead of failing after a predefined timeout regardless the status. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 Signed-off-by: Richard W.M. Jones <rjones@redhat.com> Tested-by: Ilanit Stein <istein@redhat.com> --- v2v/rhv-upload-plugin.py | 19 ++++++++...

...ns(+), 1 deletion(-) > > diff --git a/v2v/rhv-upload-plugin.py b/v2v/rhv-upload-plugin.py > index 9b433bd7e..e79e7ddf7 100644 > --- a/v2v/rhv-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -575,6 +575,11 @@ def create_disk(connection): > if disk.status == types.DiskStatus.OK: > break > if time.time() > endt: > - raise RuntimeError("timed out waiting for disk to become unlocked") > + try: > + disk_service.remove() > + except Exception as e: > + debug...

On Thu, Aug 8, 2019 at 5:05 PM Richard W.M. Jones <rjones@redhat.com> wrote: > On Mon, Mar 18, 2019 at 06:51:26PM +0200, Daniel Erez wrote: > > After invoking transfer_service.finalize, check operation > > status by examining DiskStatus. > > This is done instead of failing after a predefined timeout > > regardless the status. > > > > * not verified * > > > > Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 > > --- > > v2v/rhv-upload-plugin.py | 19 +++++++++++++------ &gt...

...v-upload-plugin.py > +++ b/v2v/rhv-upload-plugin.py > @@ -161,7 +161,7 @@ def open(readonly): > > endt = time.time() + timeout > while True: > - time.sleep(5) > + time.sleep(1) > disk = disk_service.get() > if disk.status == types.DiskStatus.OK: > break > @@ -197,7 +197,7 @@ def open(readonly): > transfer_service.cancel() > raise RuntimeError("timed out waiting for transfer status " > "!= INITIALIZING") > - time.sleep(5)...

On Sun, Mar 17, 2019 at 2:07 PM Daniel Erez <derez@redhat.com> wrote: > After invoking transfer_service.finalize, check operation > status by examining ImageTransferPhase and DiskStatus. > This is done instead of failing after a predefined timeout > regardless the status. > > * not verified * > > Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1680361 > --- > v2v/rhv-upload-plugin.py | 26 +++++++++++++++++++++----- > 1 file changed, 21 insertions(...

...-upload-module/ovirtsdk4/types.py index 9b3f557ee..60ba541cd 100644 --- a/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/types.py +++ b/v2v/test-v2v-o-rhv-upload-module/ovirtsdk4/types.py @@ -73,7 +73,7 @@ class Disk(object): ): pass - id = 123 + id = "123" status = DiskStatus.OK class ImageTransferPhase(Enum): @@ -104,7 +104,7 @@ class ImageTransfer(object): ): pass - id = 456 + id = "456" phase = ImageTransferPhase.TRANSFERRING transfer_url = "http://localhost:" + str(imageio_port) + "/" -- 2.21.0

Fix NameError introduced by inocomplete change to extract create_transfer() by extracting cancel_transfer() function. Finally extract finallize_transfer() function, dealing with the poorly documented and over complicated oVirt SDK. Tested with: libguestfs-1.40.2-4.fc30.x86_64 nbdkit-1.12.8-1.fc30.x86_64 Tested flows: - Successful import - Error in close() - by injecting long sleep in vdsm

On Fri, Aug 09, 2019 at 02:58:18AM +0300, Nir Soffer wrote: > On Thu, Aug 8, 2019 at 5:05 PM Richard W.M. Jones <rjones@redhat.com> wrote: > > > > + if disk.status == types.DiskStatus.OK: > > > + debug("finalized after %s seconds", time.time() - > > start) > > > > Maybe this was the real error? (using , instead of %) I fixed this in a later build. However the error we're talking about here seems to be unrelated to it...

This series extract oVirt SDK and imageio code to make it eaiser to follow the code and improve error handing in open() and close(). The first small patches can be consider as fixes for downstream. Tested based on libguestfs v1.41.5, since I had trouble building virt-v2v and libguestfs from master. Nir Soffer (18): rhv-upload: Remove unused exception class rhv-upload: Check status more

..., image): + self._image = image + + def __str__(self): + return self._image + +class DiskFormat(Enum): + COW = "cow" + RAW = "raw" + + def __init__(self, image): + self._image = image + + def __str__(self): + return self._image + +class DiskStatus(Enum): + ILLEGAL = "illegal" + LOCKED = "locked" + OK = "ok" + + def __init__(self, image): + self._image = image + + def __str__(self): + return self._image + +class Disk(object): + def __init__( + self, + id = Non...

v1 was here: https://www.redhat.com/archives/libguestfs/2018-September/msg00121.html v2: - Rewrote patch 2 from scratch so it incorporates Nir's suggestions. - Add fake module to EXTRA_DIST. - Retested. Unfortunately I am no longer able to test the ordinary conversion path because ovirtsdk4 is incompatible with Fedora 29 / Python 3.7:

Fixes the majority of the pycodestyle issues in the Python scripts, and fix the existing test-v2v-python-syntax.sh to use pycodestyle to actually perform style checks. Pino Toscano (6): PEP 8: adapt whitespaces in lines PEP 8: move imports at the top PEP 8: adapt empty lines tests: find all the Python scripts for syntax checks -o rhv-upload: remove unused Python imports Revamp check