search for: disk_part_it

...2/modules/chain.c | 112 ++++++++++++++++++++++++++++--------------------- 1 files changed, 64 insertions(+), 48 deletions(-) diff --git a/com32/modules/chain.c b/com32/modules/chain.c index b5c1d8f..6c3bb64 100644 --- a/com32/modules/chain.c +++ b/com32/modules/chain.c @@ -464,6 +464,9 @@ struct disk_part_iter; typedef struct disk_part_iter *(*disk_part_iter_func) (struct disk_part_iter * part); +/* Forward declaration */ +static struct disk_part_iter *next_ebr_part(struct disk_part_iter *part); + /* Contains details for a partition under examination */ struct disk_part_iter { /...

...t;soltys at ziu.info> --- com32/modules/chain.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/com32/modules/chain.c b/com32/modules/chain.c index 91db9f7..b5c1d8f 100644 --- a/com32/modules/chain.c +++ b/com32/modules/chain.c @@ -558,7 +558,7 @@ static struct disk_part_iter *next_ebr_part(struct disk_part_iter *part) if (ebr_table[0].start_lba >= extended->start_lba + extended->length) { dprintf("Insane logical partition!\n"); - goto err_insane; + goto err_ebr; } } /* Success */ @@ -568,12 +568,7 @@ static struct disk...

>From the earlier patches - that simple fix for indexes not counting non-data partitions in gpt and mbr cases. Patches don't touch any other parts of the code at this stage - bigger stuff later for disklib as we agreed - but this is potentially useful right now. Michal Soltys (1): chain.c: fix public index value in mbr and gpt iterators

This patch introduces extra functionality to chain.c, mainly with reference to BPB adjustments, but not only that. It expects 3 small patches I sent earlier (they are included for easy reference, patches 1-3/4). The changes introduced are: 1) file and boot sector use separate options to control load address and jump address (if applicable). Options are as described below: *

1) code split and move Iterator related functionality is yanked from chain.c and moved to iterator.{c,h}. Both are moved to com32/chain and this way chain.c is ready for further splitting. Alternatively, partiter could be moved to com32/lib at any time in the future. It's potentially useful for other modules (e.g. if someone wanted to code partition dumper or editor). 2) Iterator updates

...b/block/genhd.c @@ -506,12 +506,10 @@ static int exact_lock(dev_t devt, void *data) return 0; } -static void register_disk(struct gendisk *disk) +static void register_disk(struct gendisk *disk, bool gen_uevent) { struct device *ddev = disk_to_dev(disk); struct block_device *bdev; - struct disk_part_iter piter; - struct hd_struct *part; int err; ddev->parent = disk->driverfs_dev; @@ -563,6 +561,22 @@ static void register_disk(struct gendisk *disk) exit: /* announce disk after possible partitions are created */ dev_set_uevent_suppress(ddev, 0); + if (gen_uevent) + disk_gen_uevent...

The race condition is noticed between disk_add() and disk attributes, on virtio-blk hotplug. Userspace listens to the KOBJ_ADD uevent generated in add_disk(). At that point we haven't created the serial attribute file, therefore depending on how fast udev reacts, the /dev/disk/by-id/ entry doesn't always get created. As pointed out by Christoph Hellwig in the specific fix [1], virtio-blk

The race condition is noticed between disk_add() and disk attributes, on virtio-blk hotplug. Userspace listens to the KOBJ_ADD uevent generated in add_disk(). At that point we haven't created the serial attribute file, therefore depending on how fast udev reacts, the /dev/disk/by-id/ entry doesn't always get created. As pointed out by Christoph Hellwig in the specific fix [1], virtio-blk