search for: disk_format

...logical volume, created at the requested > "initial_size": > > From: > > https://github.com/oVirt/ovirt-engine-sdk/blob/aba2a83ec94ecac1594adfff62d3cfcfdbdef416/sdk/examples/upload_disk.py#L113 > > > if image_info["format"] == "qcow2": > disk_format = types.DiskFormat.COW > else: > disk_format = types.DiskFormat.RAW > > disks_service = connection.system_service().disks_service() > disk = disks_service.add( > disk=types.Disk( > name=os.path.basename(image_path), > description='Uploaded disk...

...isioned disk, which in oVirt is a regular logical volume, created at the requested "initial_size": From: https://github.com/oVirt/ovirt-engine-sdk/blob/aba2a83ec94ecac1594adfff62d3cfcfdbdef416/sdk/examples/upload_disk.py#L113 if image_info["format"] == "qcow2": disk_format = types.DiskFormat.COW else: disk_format = types.DiskFormat.RAW disks_service = connection.system_service().disks_service() disk = disks_service.add( disk=types.Disk( name=os.path.basename(image_path), description='Uploaded disk', format=disk_format,...

...b/generator/actions.ml index 4cfba0d..370e6e0 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -2744,19 +2744,19 @@ data." }; style = RString "format", [String "filename"], []; tests = [ InitEmpty, Always, TestResultString ( - [["disk_format"; "../data/blank-disk-1s.raw"]], "raw"), []; + [["disk_format"; "$databuilddir/blank-disk-1s.raw"]], "raw"), []; InitEmpty, Always, TestResultString ( - [["disk_format"; "../data/blank-disk-1s.qcow2"]],...

...ster-host-0_root.qcow2" libguestfs: trace: add_drive "/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-0_root.qcow2" "readonly:true" libguestfs: creating COW overlay to protect original drive content libguestfs: trace: disk_format "/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-0_root.qcow2" libguestfs: command: run: qemu-img libguestfs: command: run: \ info libguestfs: command: run: \ --output json libguestfs: command: run: \ /dev/fd/7 qemu-img: Could not o...

...= 0 >> > libguestfs: trace: launch >> > libguestfs: trace: get_tmpdir >> > libguestfs: trace: get_tmpdir = "/tmp" >> > libguestfs: trace: get_cachedir >> > libguestfs: trace: get_cachedir = "/var/tmp" >> > libguestfs: trace: disk_format "/var/lib/libvirt/images/prop-expand.img" >> > libguestfs: trace: disk_format = "raw" >> > libguestfs: trace: get_cachedir >> > libguestfs: trace: get_cachedir = "/var/tmp" >> > [...] 100% --:-- >> > libguestfs: trace: launc...

..."prop-expand.img" "readonly:false" libguestfs: trace: add_drive = 0 libguestfs: trace: launch libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp" libguestfs: trace: get_cachedir libguestfs: trace: get_cachedir = "/var/tmp" libguestfs: trace: disk_format "/var/lib/libvirt/images/prop-expand.img" libguestfs: trace: disk_format = "raw" libguestfs: trace: get_cachedir libguestfs: trace: get_cachedir = "/var/tmp" [...] 100% --:-- libguestfs: trace: launch = 0 libguestfs: trace: lvm_set_filter "/dev/sda" libguestf...

..."prop-expand.img" "readonly:false" libguestfs: trace: add_drive = 0 libguestfs: trace: launch libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp" libguestfs: trace: get_cachedir libguestfs: trace: get_cachedir = "/var/tmp" libguestfs: trace: disk_format "/var/lib/libvirt/images/prop-expand.img" libguestfs: trace: disk_format = "raw" libguestfs: trace: get_cachedir libguestfs: trace: get_cachedir = "/var/tmp" [...] 100% --:-- libguestfs: trace: launch = 0 libguestfs: trace: lvm_set_filter "/dev/sda" libguestf...

...b/generator/actions.ml index eec3b94..fde0b25 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -2732,19 +2732,19 @@ data." }; style = RString "format", [String "filename"], []; tests = [ InitEmpty, Always, TestResultString ( - [["disk_format"; "../data/blank-disk-1s.raw"]], "raw"), []; + [["disk_format"; "$datadir/blank-disk-1s.raw"]], "raw"), []; InitEmpty, Always, TestResultString ( - [["disk_format"; "../data/blank-disk-1s.qcow2"]], &quot...

...>> >> > libguestfs: trace: get_tmpdir >> >> > libguestfs: trace: get_tmpdir = "/tmp" >> >> > libguestfs: trace: get_cachedir >> >> > libguestfs: trace: get_cachedir = "/var/tmp" >> >> > libguestfs: trace: disk_format "/var/lib/libvirt/images/prop-expand.img" >> >> > libguestfs: trace: disk_format = "raw" >> >> > libguestfs: trace: get_cachedir >> >> > libguestfs: trace: get_cachedir = "/var/tmp" >> >> > [...] 100% --:-- &g...

...b/generator/actions.ml index 35af981..d2b057d 100644 --- a/generator/actions.ml +++ b/generator/actions.ml @@ -2767,19 +2767,19 @@ data." }; style = RString "format", [String "filename"], []; tests = [ InitEmpty, Always, TestResultString ( - [["disk_format"; "../data/blank-disk-1s.raw"]], "raw"), []; + [["disk_format"; "$datadir/blank-disk-1s.raw"]], "raw"), []; InitEmpty, Always, TestResultString ( - [["disk_format"; "../data/blank-disk-1s.qcow2"]], &quot...

...readonly:false" > libguestfs: trace: add_drive = 0 > libguestfs: trace: launch > libguestfs: trace: get_tmpdir > libguestfs: trace: get_tmpdir = "/tmp" > libguestfs: trace: get_cachedir > libguestfs: trace: get_cachedir = "/var/tmp" > libguestfs: trace: disk_format "/var/lib/libvirt/images/prop-expand.img" > libguestfs: trace: disk_format = "raw" > libguestfs: trace: get_cachedir > libguestfs: trace: get_cachedir = "/var/tmp" > [...] 100% --:-- > libguestfs: trace: launch = 0 > libguestfs: trace: lvm_set_filter...

...isioned_size=image_info["virtual-size"], Can you describe exactly what these two sizes mean? Remember that virt-v2v works by streaming. At the point where we are calling this API virt-v2v only knows the virtual size. We never know the size of the final qcow2 file. > sparse=disk_format == types.DiskFormat.COW, > storage_domains=[ > types.StorageDomain( > name='mydata' > ) > ] > ) > ) > > Internally we do allocated 10% more then the requested initial_size > to leave room for qcow2 me...

...: add_drive > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > master/default/images/lago-basic-suite-master-host-0_root.qcow2" > > "readonly:true" > > libguestfs: creating COW overlay to protect original drive content > > libguestfs: trace: disk_format > > "/home/ykaul/ovirt-system-tests/deployment-basic-suite- > master/default/images/lago-basic-suite-master-host-0_root.qcow2" > > libguestfs: command: run: qemu-img > > libguestfs: command: run: \ info > > libguestfs: command: run: \ --output json > > lib...

My stab at fixing this: https://bugzilla.redhat.com/show_bug.cgi?id=1789279 It took me quite some time to go through the whole rfc 4122 just to realize we do not need to do anything with the versions. Martin Kletzander (2): rhv-upload: Validate UUIDs passed to -oo rhv-disk-uuid (RHBZ#1789279) rhv-upload: Check that rhv-disk-uuid is not already taken (RHBZ#1789279)

...sparsify/copying.ml +++ b/sparsify/copying.ml @@ -60,7 +60,7 @@ let run indisk outdisk check_tmpdir compress convert | Some fmt -> fmt (* user specified input format, use that *) | None -> (* Don't know, so we must autodetect. *) - match (new G.guestfs ())#disk_format indisk with + match (open_guestfs ())#disk_format indisk with | "unknown" -> error (f_"cannot detect input disk format; use the --format parameter") | fmt -> fmt in @@ -79,9 +79,7 @@ let run indisk outdisk check_tmpdir compress convert...

...aybe, I'm not familiar with the SDK. > > What is the motivation for disabling this flag? > > >> > [snipped] >> > >> > > + # Create the disk. >> > > + disks_service = system_service.disks_service() >> > > + if params['disk_format'] == "raw": >> > > + disk_format = types.DiskFormat.RAW >> > > + else: >> > > + disk_format = types.DiskFormat.COW >> > > + disk = disks_service.add( >> > > + disk = types.Disk( >> > > +...

...ot; > libguestfs: trace: add_drive > "/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-0_root.qcow2" > "readonly:true" > libguestfs: creating COW overlay to protect original drive content > libguestfs: trace: disk_format > "/home/ykaul/ovirt-system-tests/deployment-basic-suite-master/default/images/lago-basic-suite-master-host-0_root.qcow2" > libguestfs: command: run: qemu-img > libguestfs: command: run: \ info > libguestfs: command: run: \ --output json > libguestfs: command: run: \ /dev/f...

...) + if uuid is not None: + try: + disks_service.disk_service(uuid).get() + nbdkit.set_error(errno.EINVAL) + raise ValueError("Disk with the specified UUID already exists") + except sdk.NotFoundError: + pass + if params['disk_format'] == "raw": disk_format = types.DiskFormat.RAW else: -- 2.25.0

...uuid is not None: + try: + disks_service.disk_service(uuid).get() + nbdkit.set_error(errno.EEXIST) + raise ValueError("Disk with the UUID '%s' already exists" % uuid) + except sdk.NotFoundError: + pass + if params['disk_format'] == "raw": disk_format = types.DiskFormat.RAW else: -- 2.25.0

..."prop-expand.img" "readonly:false" libguestfs: trace: add_drive = 0 libguestfs: trace: launch libguestfs: trace: get_tmpdir libguestfs: trace: get_tmpdir = "/tmp" libguestfs: trace: get_cachedir libguestfs: trace: get_cachedir = "/var/tmp" libguestfs: trace: disk_format "/var/lib/libvirt/images/prop-expand.img" libguestfs: trace: disk_format = "raw" libguestfs: trace: get_cachedir libguestfs: trace: get_cachedir = "/var/tmp" [...] 100% --:-- libguestfs: trace: launch = 0 libguestfs: trace: lvm_set_filter "/dev/sda" libguestf...