search for: directorywatcher

Hi Jan, our builds have been failing on Redhat linux kernel version 2.6.32 with the following error: 2019.07.15 11:10:28 ../llvm/tools/clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:335:47: error: 'IN_EXCL_UNLINK' was not declared in this scope 2019.07.15 11:10:28 IN_CREATE | IN_DELETE | IN_DELETE_SELF | IN_EXCL_UNLINK | IN_MODIFY | this is because of the patch https://reviews.llvm.org/rG77dd8a79286d2fff94c765f787d7f7debb2a10c...

...ael > > On 2019-07-15 12:56, Ranjeet Singh via llvm-dev wrote: >> Hi Jan, >> >> >> our builds have been failing on Redhat linux kernel version 2.6.32 with >> the following error: >> >> >> *2019.07.15 11:10:28* >> ../llvm/tools/clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:335:47: >> error: 'IN_EXCL_UNLINK' was not declared in this scope *2019.07.15 >> 11:10:28* IN_CREATE | IN_DELETE | IN_DELETE_SELF | IN_EXCL_UNLINK | >> IN_MODIFY | >> >> >> this is because of the patch >> https:/...

...s > } Hmm. I don''t know. I''m not sure if I wanna remember the ChangeNotify::INFINITE constant - the default behaviour is intuitive, to me(though the name''s more ipc-ish than filesystem). Maybe a new method in changenotify - something like the start_monitoring(sic) in DirectoryWatcher. (I feel the API is too much tied with ipc as it is. True, it inherits from ipc, but I''m not sure if someone with the general watch-for-file-system-changes use-case wants to know that there is ipc and monitors going on behind the scenes. Just my 2 paise, and hope I''m not treading...