Displaying 10 results from an estimated 10 matches for "dir_pmu".
2024 Oct 29
1
[PATCH 2/2] [v8] drm/nouveau: expose GSP-RM logging buffers via debugfs
...ugfs. The wrapper objects need to remain
> > + * in memory until the dentry is deleted.
> > + */
> > + struct dentry *dir; /* Parent dentry */
> > + struct dentry *dir_init;
> > + struct dentry *dir_rm;
> > + struct dentry *dir_intr;
> > + struct dentry *dir_pmu;
>
> I think `dir` is confusing, maybe just `dent_*`? Or maybe just wrap all those in
> a `struct { ... } debugfs;` and just name them `init`, `rm`, etc.?
Ok, but I'm pretty sure this is like the fifth time I've moved these fields
around because you keep telling me to put them so...
2024 Oct 03
1
[PATCH 2/2] [v8] drm/nouveau: expose GSP-RM logging buffers via debugfs
.../*
> + * Logging buffers in debugfs. The wrapper objects need to remain
> + * in memory until the dentry is deleted.
> + */
> + struct dentry *dir; /* Parent dentry */
> + struct dentry *dir_init;
> + struct dentry *dir_rm;
> + struct dentry *dir_intr;
> + struct dentry *dir_pmu;
I think `dir` is confusing, maybe just `dent_*`? Or maybe just wrap all those in
a `struct { ... } debugfs;` and just name them `init`, `rm`, etc.?
> + struct debugfs_blob_wrapper blob_init;
> + struct debugfs_blob_wrapper blob_intr;
> + struct debugfs_blob_wrapper blob_rm;
> + struc...
2024 Jul 29
1
[PATCH 2/2] [v6] drm/nouveau: expose GSP-RM logging buffers via debugfs
...debugfs entries before
+ * r535_gsp_booter_load() is called, so that if GSP-RM fails to initialize,
+ * there could still be a log to capture.
+ */
+static void
+r535_gsp_libos_debugfs_init(struct nvkm_gsp *gsp)
+{
+ struct dentry *dir, *dir_init;
+ struct dentry *dir_intr = NULL, *dir_rm = NULL, *dir_pmu = NULL;
+ struct device *dev = gsp->subdev.device->dev;
+
+ /* Each GPU has a subdir based on its device name, so find it */
+ struct drm_device *drm_dev = dev_get_drvdata(dev);
+
+ if (!drm_dev || !drm_dev->debugfs_root) {
+ nvkm_error(&gsp->subdev, "could not find debugfs pa...
2024 Sep 10
1
[PATCH 1/2] [v2] drm/nouveau: retain device pointer in nvkm_gsp_mem object
Store the struct device pointer used to allocate the DMA buffer in
the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release
the buffer without needing the nvkm_gsp. This is needed so that
we can retain DMA buffers even after the nvkm_gsp object is deleted.
Signed-off-by: Timur Tabi <ttabi at nvidia.com>
---
.../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 1 +
2024 Jul 30
1
[PATCH 2/2] [v6] drm/nouveau: expose GSP-RM logging buffers via debugfs
...p_booter_load() is called, so that if GSP-RM fails to initialize,
> + * there could still be a log to capture.
> + */
> +static void
> +r535_gsp_libos_debugfs_init(struct nvkm_gsp *gsp)
> +{
> + struct dentry *dir, *dir_init;
> + struct dentry *dir_intr = NULL, *dir_rm = NULL, *dir_pmu = NULL;
> + struct device *dev = gsp->subdev.device->dev;
> +
> + /* Each GPU has a subdir based on its device name, so find it */
> + struct drm_device *drm_dev = dev_get_drvdata(dev);
> +
> + if (!drm_dev || !drm_dev->debugfs_root) {
I don't think we need any of th...
2024 Jun 12
2
[PATCH 1/2] [v2] drm/nouveau: retain device pointer in nvkm_gsp_mem object
Store the struct device pointer used to allocate the DMA buffer in
the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release
the buffer without needing the nvkm_gsp. This is needed so that
we can retain DMA buffers even after the nvkm_gsp object is deleted.
Signed-off-by: Timur Tabi <ttabi at nvidia.com>
---
v2: rebased to drm-misc-next
2024 Aug 02
1
[PATCH 1/2] [v2] drm/nouveau: retain device pointer in nvkm_gsp_mem object
Store the struct device pointer used to allocate the DMA buffer in
the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release
the buffer without needing the nvkm_gsp. This is needed so that
we can retain DMA buffers even after the nvkm_gsp object is deleted.
Signed-off-by: Timur Tabi <ttabi at nvidia.com>
---
Notes:
v2:
added get/put_device calls
2024 Jul 29
2
[PATCH 1/2] [v2] drm/nouveau: retain device pointer in nvkm_gsp_mem object
Store the struct device pointer used to allocate the DMA buffer in
the nvkm_gsp_mem object. This allows nvkm_gsp_mem_dtor() to release
the buffer without needing the nvkm_gsp. This is needed so that
we can retain DMA buffers even after the nvkm_gsp object is deleted.
Signed-off-by: Timur Tabi <ttabi at nvidia.com>
v2:
added get/put_device calls
---
2024 Jul 30
1
[PATCH 2/2] [v6] drm/nouveau: expose GSP-RM logging buffers via debugfs
...RPC version" <= "current
VGPU version" at the time the RPC was created/updated.
> > +static void
> > +r535_gsp_libos_debugfs_init(struct nvkm_gsp *gsp)
> > +{
> > + struct dentry *dir, *dir_init;
> > + struct dentry *dir_intr = NULL, *dir_rm = NULL, *dir_pmu = NULL;
> > + struct device *dev = gsp->subdev.device->dev;
> > +
> > + /* Each GPU has a subdir based on its device name, so find it */
> > + struct drm_device *drm_dev = dev_get_drvdata(dev);
> > +
> > + if (!drm_dev || !drm_dev->debugfs_root) {
>...
2024 Jun 18
1
[PATCH 2/2] [v5] drm/nouveau: expose GSP-RM logging buffers via debugfs
...te much of the code that is compiled, and these class IDs are one example.
+ i_size_write(d_inode(dir_init), gsp->blob_init.size);
+ i_size_write(d_inode(dir_intr), gsp->blob_intr.size);
+ i_size_write(d_inode(dir_rm), gsp->blob_rm.size);
+ i_size_write(d_inode(dir_pmu), gsp->blob_pmu.size);
+
+ r535_gsp_msg_ntfy_add(gsp, 0x0000100C, r535_gsp_msg_libos_print, gsp);
Please, don't add random magic values. Add a useful explanation instead that
also new contributors are able to make sense of.
Ah, I can just use the macro that's already defined...