search for: digitaleric

...This primarily removes the IDT from being a target for arbitrary memory write attacks. It has an added benefit of also not leaking (via the "sidt" instruction) the kernel base offset, if it has been relocated. Signed-off-by: Kees Cook <keescook at chromium.org> Cc: Eric Northup <digitaleric at google.com> --- arch/x86/include/asm/fixmap.h | 4 +--- arch/x86/kernel/cpu/intel.c | 15 --------------- arch/x86/kernel/traps.c | 8 ++++++++ arch/x86/xen/mmu.c | 4 +--- 4 files changed, 10 insertions(+), 21 deletions(-) diff --git a/arch/x86/include/asm/fix...

...This primarily removes the IDT from being a target for arbitrary memory write attacks. It has an added benefit of also not leaking (via the "sidt" instruction) the kernel base offset, if it has been relocated. Signed-off-by: Kees Cook <keescook at chromium.org> Cc: Eric Northup <digitaleric at google.com> --- arch/x86/include/asm/fixmap.h | 4 +--- arch/x86/kernel/cpu/intel.c | 15 --------------- arch/x86/kernel/traps.c | 8 ++++++++ arch/x86/xen/mmu.c | 4 +--- 4 files changed, 10 insertions(+), 21 deletions(-) diff --git a/arch/x86/include/asm/fix...

...unk before 2613af0ed18a (PAGE_SIZE buf): 3861.08Gb/s net-next trunk (MTU 1500- packet uses two buf due to size bug): 4076.62Gb/s net-next trunk (MTU 1480- packet fits in one buf): 6301.34Gb/s net-next trunk w/ size fix (MTU 1500 - packet fits in one buf): 6445.44Gb/s Suggested-by: Eric Northup <digitaleric at google.com> Signed-off-by: Michael Dalton <mwdalton at google.com> --- drivers/net/virtio_net.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 01f4eb5..69fb225 100644 --- a/d...

...unk before 2613af0ed18a (PAGE_SIZE buf): 3861.08Gb/s net-next trunk (MTU 1500- packet uses two buf due to size bug): 4076.62Gb/s net-next trunk (MTU 1480- packet fits in one buf): 6301.34Gb/s net-next trunk w/ size fix (MTU 1500 - packet fits in one buf): 6445.44Gb/s Suggested-by: Eric Northup <digitaleric at google.com> Signed-off-by: Michael Dalton <mwdalton at google.com> --- drivers/net/virtio_net.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 01f4eb5..69fb225 100644 --- a/d...

...to be very specific. This patch extends the readonly alias to all CPUs, but does not activate the #PF to #UD conversion code needed to deliver the proper exception in the F0 0F case except on Intel family 5 processors. Signed-off-by: Kees Cook <keescook at chromium.org> Cc: Eric Northup <digitaleric at google.com> --- v3: - clarify commit, thanks to HPA - add missing header file, thanks to buildbot. :) v2: - clarify commit and comments --- arch/x86/include/asm/fixmap.h | 4 +--- arch/x86/kernel/cpu/intel.c | 18 +----------------- arch/x86/kernel/traps.c | 9 +++++++++ a...

...to be very specific. This patch extends the readonly alias to all CPUs, but does not activate the #PF to #UD conversion code needed to deliver the proper exception in the F0 0F case except on Intel family 5 processors. Signed-off-by: Kees Cook <keescook at chromium.org> Cc: Eric Northup <digitaleric at google.com> --- v3: - clarify commit, thanks to HPA - add missing header file, thanks to buildbot. :) v2: - clarify commit and comments --- arch/x86/include/asm/fixmap.h | 4 +--- arch/x86/kernel/cpu/intel.c | 18 +----------------- arch/x86/kernel/traps.c | 9 +++++++++ a...

...PAGE_SIZE buf): 3861.08Gb/s > net-next trunk (MTU 1500- packet uses two buf due to size bug): 4076.62Gb/s > net-next trunk (MTU 1480- packet fits in one buf): 6301.34Gb/s > net-next trunk w/ size fix (MTU 1500 - packet fits in one buf): 6445.44Gb/s > > Suggested-by: Eric Northup <digitaleric at google.com> > Signed-off-by: Michael Dalton <mwdalton at google.com> > --- Acked-by: Eric Dumazet <edumazet at google.com>

...unk before 2613af0ed18a (PAGE_SIZE buf): 3861.08Gb/s net-next trunk (MTU 1500- packet uses two buf due to size bug): 4076.62Gb/s net-next trunk (MTU 1480- packet fits in one buf): 6301.34Gb/s net-next trunk w/ size fix (MTU 1500 - packet fits in one buf): 6445.44Gb/s Suggested-by: Eric Northup <digitaleric at google.com> Signed-off-by: Michael Dalton <mwdalton at google.com> --- drivers/net/virtio_net.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 01f4eb5..69fb225 100644 --- a/d...

...unk before 2613af0ed18a (PAGE_SIZE buf): 3861.08Gb/s net-next trunk (MTU 1500- packet uses two buf due to size bug): 4076.62Gb/s net-next trunk (MTU 1480- packet fits in one buf): 6301.34Gb/s net-next trunk w/ size fix (MTU 1500 - packet fits in one buf): 6445.44Gb/s Suggested-by: Eric Northup <digitaleric at google.com> Signed-off-by: Michael Dalton <mwdalton at google.com> --- drivers/net/virtio_net.c | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index 01f4eb5..69fb225 100644 --- a/d...

...t;sidt" instruction) read-only. This primarily removes the IDT from being a target for arbitrary memory write attacks, and has the added benefit of also not leaking the kernel base offset, if it has been relocated. Signed-off-by: Kees Cook <keescook at chromium.org> Cc: Eric Northup <digitaleric at google.com> --- v2: - clarify commit and comments --- arch/x86/include/asm/fixmap.h | 4 +--- arch/x86/kernel/cpu/intel.c | 18 +----------------- arch/x86/kernel/traps.c | 8 ++++++++ arch/x86/xen/mmu.c | 4 +--- 4 files changed, 11 insertions(+), 23 deletions...

...t;sidt" instruction) read-only. This primarily removes the IDT from being a target for arbitrary memory write attacks, and has the added benefit of also not leaking the kernel base offset, if it has been relocated. Signed-off-by: Kees Cook <keescook at chromium.org> Cc: Eric Northup <digitaleric at google.com> --- v2: - clarify commit and comments --- arch/x86/include/asm/fixmap.h | 4 +--- arch/x86/kernel/cpu/intel.c | 18 +----------------- arch/x86/kernel/traps.c | 8 ++++++++ arch/x86/xen/mmu.c | 4 +--- 4 files changed, 11 insertions(+), 23 deletions...

...ating MTU-sized packet > buffers using page frag allocators. If more than MAX_SKB_FRAGS > buffers are needed, the SKB frag_list is used. This looks really good, just one nit below -- should we add MTU-sized packets, or add MTU+sizeof(virtnet_hdr)-sized packets? Reviewed-by: Eric Northup <digitaleric at google.com> > > Signed-off-by: Michael Dalton <mwdalton at google.com> > --- > drivers/net/virtio_net.c | 164 ++++++++++++++++++++++++++++++----------------- > 1 file changed, 106 insertions(+), 58 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/...

The virtio_net driver's mergeable receive buffer allocator uses 4KB packet buffers. For MTU-sized traffic, SKB truesize is > 4KB but only ~1500 bytes of the buffer is used to store packet data, reducing the effective TCP window size substantially. This patch addresses the performance concerns with mergeable receive buffers by allocating MTU-sized packet buffers using page frag allocators.

The virtio_net driver's mergeable receive buffer allocator uses 4KB packet buffers. For MTU-sized traffic, SKB truesize is > 4KB but only ~1500 bytes of the buffer is used to store packet data, reducing the effective TCP window size substantially. This patch addresses the performance concerns with mergeable receive buffers by allocating MTU-sized packet buffers using page frag allocators.

Hi Rob & Mihai, I wrote vhost-nvme patches on top of Christoph's NVMe target. vhost-nvme still uses mmio. So the guest OS can run unmodified NVMe driver. But the tests I have done didn't show competitive performance compared to virtio-blk/virtio-scsi. The bottleneck is in mmio. Your nvme vendor extension patches reduces greatly the number of MMIO writes. So I'd like to push it

Hi Rob & Mihai, I wrote vhost-nvme patches on top of Christoph's NVMe target. vhost-nvme still uses mmio. So the guest OS can run unmodified NVMe driver. But the tests I have done didn't show competitive performance compared to virtio-blk/virtio-scsi. The bottleneck is in mmio. Your nvme vendor extension patches reduces greatly the number of MMIO writes. So I'd like to push it

...Lapuyade <eric.lapuyade@intel.com> Eric Leblond <eric@regit.org> Eric Miao <eric.y.miao@gmail.com> Eric Millbrandt <emillbrandt@dekaresearch.com> Eric Multanen <eric.w.multanen@intel.com> Eric Nelson <eric.nelson@boundarydevices.com> Eric Northup <digitaleric@google.com> Eric Paris <eparis@parisplace.org> Eric Paris <eparis@redhat.com> Eric Sandeen <sandeen@redaht.com> Eric Sandeen <sandeen@redhat.com> Eric Van Hensbergen <ericvh@gmail.com> Eric W. Biederman <ebiederm@xmission.com> Eric Whitney <en...

...Lapuyade <eric.lapuyade@intel.com> Eric Leblond <eric@regit.org> Eric Miao <eric.y.miao@gmail.com> Eric Millbrandt <emillbrandt@dekaresearch.com> Eric Multanen <eric.w.multanen@intel.com> Eric Nelson <eric.nelson@boundarydevices.com> Eric Northup <digitaleric@google.com> Eric Paris <eparis@parisplace.org> Eric Paris <eparis@redhat.com> Eric Sandeen <sandeen@redaht.com> Eric Sandeen <sandeen@redhat.com> Eric Van Hensbergen <ericvh@gmail.com> Eric W. Biederman <ebiederm@xmission.com> Eric Whitney <en...

...Lapuyade <eric.lapuyade@intel.com> Eric Leblond <eric@regit.org> Eric Miao <eric.y.miao@gmail.com> Eric Millbrandt <emillbrandt@dekaresearch.com> Eric Multanen <eric.w.multanen@intel.com> Eric Nelson <eric.nelson@boundarydevices.com> Eric Northup <digitaleric@google.com> Eric Paris <eparis@parisplace.org> Eric Paris <eparis@redhat.com> Eric Sandeen <sandeen@redaht.com> Eric Sandeen <sandeen@redhat.com> Eric Van Hensbergen <ericvh@gmail.com> Eric W. Biederman <ebiederm@xmission.com> Eric Whitney <en...

...Eric Leblond <eric@regit.org> Eric Miao <eric.y.miao@gmail.com> Eric Mico <eric.y.miao@gmail.com> Eric Millbrandt <emillbrandt@dekaresearch.com> Eric Multanen <eric.w.multanen@intel.com> Eric Nelson <eric.nelson@boundarydevices.com> Eric Northup <digitaleric@google.com> Eric Paris <eparis@parisplace.org> Eric Paris <eparis@redhat.com> Eric Sandeen <sandeen@redaht.com> Eric Sandeen <sandeen@redhat.com> Eric Van Hensbergen <ericvh@gmail.com> Eric W. Biederman <ebiederm@xmission.com> Eric Whitney <en...