search for: dhildenb

...irtio-mem v4 installed in the guest) > > #! /bin/bash > sudo x86_64-softmmu/qemu-system-x86_64 \ > -machine pc-i440fx-5.0,accel=kvm,usb=off \ > -cpu host \ > -no-reboot \ > -nographic \ > -device ide-hd,drive=hd \ > -drive if=none,id=hd,file=/home/dhildenb/git/Fedora-Cloud-Base-31-1.9.x86_64.qcow2,format=qcow2 \ > -m 1g,slots=10,maxmem=2G \ > -smp 1 \ > -object memory-backend-ram,id=mem0,size=256m \ > -device pc-dimm,id=dimm0,memdev=mem0 \ > -s \ > -monitor unix:/var/tmp/monitor,server,nowait > > >...

...gt; I still could reproduce this issue with pc-i440fx-5.0 or pc. Did I miss anything? > Below I don't even see virtio_mem. I had to repair the image (filesystem fsck) because it was broken, can you try that as well? Also, it would be great if you could test with v4. -- Thanks, David / dhildenb

...gt; I still could reproduce this issue with pc-i440fx-5.0 or pc. Did I miss anything? > Below I don't even see virtio_mem. I had to repair the image (filesystem fsck) because it was broken, can you try that as well? Also, it would be great if you could test with v4. -- Thanks, David / dhildenb

...S_DONE) -> config.free_page_report_cmd_id = ... VIRTIO_BALLOON_CMD_ID_DONE Linux: drivers/virtio/virtio_balloon.c:report_free_page_func() -> if (cmd_id_received == VIRTIO_BALLOON_CMD_ID_DONE) { -> return_free_pages_to_mm() So it's VIRTIO_BALLOON_CMD_ID_DONE. -- Thanks, David / dhildenb

...ber to > pick this. > Makes sense? Yes, it's somehow a fix (for kexec). So Fixes: 5f1f79bbc9e26 ("virtio-mem: Paravirtualized memory hotplug") I can respin after -rc1 with the commit id fixed as noted by Pankaj. Just let me know what you prefer. Thanks! -- Thanks, David / dhildenb

...ber to > pick this. > Makes sense? Yes, it's somehow a fix (for kexec). So Fixes: 5f1f79bbc9e26 ("virtio-mem: Paravirtualized memory hotplug") I can respin after -rc1 with the commit id fixed as noted by Pankaj. Just let me know what you prefer. Thanks! -- Thanks, David / dhildenb

...(linus/master) Merge: b9388959ba50 16f8036086a9 Author: Linus Torvalds <torvalds at linux-foundation.org> Date: Wed May 6 20:53:22 2020 -0700 Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net I can resend based on that, after giving it a short test. -- Thanks, David / dhildenb

...(linus/master) Merge: b9388959ba50 16f8036086a9 Author: Linus Torvalds <torvalds at linux-foundation.org> Date: Wed May 6 20:53:22 2020 -0700 Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net I can resend based on that, after giving it a short test. -- Thanks, David / dhildenb

...ust means "don't give me any > more hints, I finished migration". > Guest will stop hinting even without that once it scans all > free memory. Yeah, that's the end of the whole process where you can be sure the host processed all requests definetly. -- Thanks, David / dhildenb

...notifier should be used instead, I will submit patches to move to > OOM notifier as well. Will do. It all sounds sub-optimal to me at this point ... but I prefer the old variant where a simple "drop_slab()" won't deflate the balloon. That looks broken to me. -- Thanks, David / dhildenb

...notifier should be used instead, I will submit patches to move to > OOM notifier as well. Will do. It all sounds sub-optimal to me at this point ... but I prefer the old variant where a simple "drop_slab()" won't deflate the balloon. That looks broken to me. -- Thanks, David / dhildenb

...ne set in step 3. > Then the modified page gets sent. So, if you run a TCG guest and use it with free page reporting, the race is possible? So the correctness depends on two dirty bitmaps in the hypervisor and how they interact. wow this is fragile. Thanks for the info :) -- Thanks, David / dhildenb

...ne set in step 3. > Then the modified page gets sent. So, if you run a TCG guest and use it with free page reporting, the race is possible? So the correctness depends on two dirty bitmaps in the hypervisor and how they interact. wow this is fragile. Thanks for the info :) -- Thanks, David / dhildenb

...uot; (that skips nothing..) > Anyway, it's a hint used for optimization. Yes, an optimization that might easily lead to data corruption when the two bitmaps are either not in place or don't play along in that specific way (and I suspect this is the case under TCG). -- Thanks, David / dhildenb

...uot; (that skips nothing..) > Anyway, it's a hint used for optimization. Yes, an optimization that might easily lead to data corruption when the two bitmaps are either not in place or don't play along in that specific way (and I suspect this is the case under TCG). -- Thanks, David / dhildenb

On 29.03.20 14:42, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2020 at 06:14:12PM +0100, David Hildenbrand wrote: >> This series is based on latest linux-next. The patches are located at: >> https://github.com/davidhildenbrand/linux.git virtio-mem-v2 >> >> I now have acks for all !virtio-mem changes. I'll be happy to get review >> feedback, testing reports, etc. for the virtio-mem changes. If there are >> no further comments, I guess this is good to go as a v1 soon. > > I'd like...

On 29.03.20 14:42, Michael S. Tsirkin wrote: > On Wed, Mar 11, 2020 at 06:14:12PM +0100, David Hildenbrand wrote: >> This series is based on latest linux-next. The patches are located at: >> https://github.com/davidhildenbrand/linux.git virtio-mem-v2 >> >> I now have acks for all !virtio-mem changes. I'll be happy to get review >> feedback, testing reports, etc. for the virtio-mem changes. If there are >> no further comments, I guess this is good to go as a v1 soon. > > I'd like...

...these are more features, you can just post them on list noting "next" in subject and saying "this is on top of vhost tree" after --. I don't know how to make 0-day figure out where to apply such dependent patches unfortunately. > > -- > Thanks, > > David / dhildenb

...these are more features, you can just post them on list noting "next" in subject and saying "this is on top of vhost tree" after --. I don't know how to make 0-day figure out where to apply such dependent patches unfortunately. > > -- > Thanks, > > David / dhildenb

...io_pmem.h like struct virtio_pmem_resp { __virtio32 ret; } #define VIRTIO_PMEM_REQ_TYPE_FLUSH 1 struct virtio_pmem_req { __virtio16 type; } ... and this way we also define a proper endianess format for exchange and keep it extensible @MST, what's your take on this? -- Thanks, David / dhildenb