search for: dhcp_options

...s is a minimal change to fix. > } This patch should help: > > > diff --git a/core/fs/pxe/dhcp_option.c b/core/fs/pxe/dhcp_option.c > index 8d93a6a..5cc0ef7 100644 > --- a/core/fs/pxe/dhcp_option.c > +++ b/core/fs/pxe/dhcp_option.c > @@ -143,7 +143,6 @@ static const struct dhcp_options dhcp_opts[] = { > {15, local_domain}, > {43, vendor_encaps}, > {52, option_overload}, > - {54, server}, > {61, client_identifier}, > {67, bootfile_name}, > {97, uuid_client_identifier}, Euh, could this be reviewed: diff --git a/core/fs...

...rote: >> Euh, could this be reviewed: >> >> diff --git a/core/fs/pxe/dhcp_option.c b/core/fs/pxe/dhcp_option.c >> index 8d93a6a..b82e944 100644 >> --- a/core/fs/pxe/dhcp_option.c >> +++ b/core/fs/pxe/dhcp_option.c >> @@ -143,8 +143,8 @@ static const struct dhcp_options dhcp_opts[] = { >> {15, local_domain}, >> {43, vendor_encaps}, >> {52, option_overload}, >> - {54, server}, >> {61, client_identifier}, >> + {66, tftpserver_name}, >> {67, bootfile_name}, >> {97, uuid_client...

On Sat, Sep 12, 2015 at 7:08 AM, Gene Cumm <gene.cumm at gmail.com> wrote: > On Sat, Sep 12, 2015 at 5:54 AM, Teun Docter > <teun.docter at brightcomputing.com> wrote: >> On 2015-09-12 04:58, Gene Cumm wrote: >>>> >>>> I've captured the following DHCP ACK: >>>> >>>> 10.141.20.1.bootps > 10.141.20.2.bootpc: [udp sum ok]

...> > } This patch should help: >> >> >> diff --git a/core/fs/pxe/dhcp_option.c b/core/fs/pxe/dhcp_option.c >> index 8d93a6a..5cc0ef7 100644 >> --- a/core/fs/pxe/dhcp_option.c >> +++ b/core/fs/pxe/dhcp_option.c >> @@ -143,7 +143,6 @@ static const struct dhcp_options dhcp_opts[] = { >> {15, local_domain}, >> {43, vendor_encaps}, >> {52, option_overload}, >> - {54, server}, >> {61, client_identifier}, >> {67, bootfile_name}, >> {97, uuid_client_identifier}, > > Euh, could thi...

...END) { + if (inp - udata >= opt_len) + state = FINISH; + + if (cpp - udata >= opt_len) + state = FINISH; + + if (outp - DomainSearch >= sizeof(DomainSearch) - 1) + state = FINISH; + } + } +} + struct dhcp_options { int opt_num; @@ -150,6 +284,7 @@ static const struct dhcp_options dhcp_op {61, client_identifier}, {67, bootfile_name}, {97, uuid_client_identifier}, + {119, domain_search}, {209, pxelinux_configfile}, {210, pxelinux_pathprefix}, {211, pxelinux_reboottime}...

...pay attention to siaddr for now, this is a minimal change to fix. This should help. -- -Gene diff --git a/core/fs/pxe/dhcp_option.c b/core/fs/pxe/dhcp_option.c index 8d93a6a..5cc0ef7 100644 --- a/core/fs/pxe/dhcp_option.c +++ b/core/fs/pxe/dhcp_option.c @@ -143,7 +143,6 @@ static const struct dhcp_options dhcp_opts[] = { {15, local_domain}, {43, vendor_encaps}, {52, option_overload}, - {54, server}, {61, client_identifier}, {67, bootfile_name}, {97, uuid_client_identifier},

...ng stupid. :) How does your code handle malformed packets? What if we reach the end of the data during the reading of the second byte of a pointer? What if the pointer points after or before the buffer? What if we reach the end of the data at a random point while reading a label? > > struct dhcp_options { > int opt_num; > @@ -150,6 +284,7 @@ static const struct dhcp_options dhcp_op > {61, client_identifier}, > {67, bootfile_name}, > {97, uuid_client_identifier}, > + {119, domain_search}, > {209, pxelinux_configfile}, > {210, pxelinux_path...

...x 8d93a6a..b82e944 100644 > >> --- a/core/fs/pxe/dhcp_option.c > >> +++ b/core/fs/pxe/dhcp_option.c > >> @@ -252,4 +252,6 @@ void parse_dhcp(const void *pkt, size_t pkt_len, int pkt_type) > >> > >> if (over_load & 2) > >> parse_dhcp_options(dhcp->sname, 64, 0); > >> + > >> + /* What about option 66, tftserver_name ? FIXME */ > >> } > > > > Something like this would be preferable except it's not quite so > > simple. We'd need to not store BOOTP siaddr before parsing. Store...

...4 >> >> --- a/core/fs/pxe/dhcp_option.c >> >> +++ b/core/fs/pxe/dhcp_option.c >> >> @@ -252,4 +252,6 @@ void parse_dhcp(const void *pkt, size_t pkt_len, int pkt_type) >> >> >> >> if (over_load & 2) >> >> parse_dhcp_options(dhcp->sname, 64, 0); >> >> + >> >> + /* What about option 66, tftserver_name ? FIXME */ >> >> } >> > >> > Something like this would be preferable except it's not quite so >> > simple. We'd need to not store BOOTP siadd...

...code handle malformed packets? What if we reach the end > of the data during the reading of the second byte of a pointer? What > if the pointer points after or before the buffer? What if we reach the > end of the data at a random point while reading a label? > >> >> struct dhcp_options { >> int opt_num; >> @@ -150,6 +284,7 @@ static const struct dhcp_options dhcp_op >> {61, client_identifier}, >> {67, bootfile_name}, >> {97, uuid_client_identifier}, >> + {119, domain_search}, >> {209, pxelinux_configfile}, &...

On 02/12/2012 06:01 AM, Gene Cumm wrote: > I had grabbed dhcp.h/dhcppack.c/dhcpunpack.c from > http://www.zytor.com/~hpa/syslinux/dhcp/ months ago when we were > talking about it more and it's been rather nice to use. Should it > contain a copyright/license header? Currently I'm just using them > as-is in com32/lib/ for pxechn.c32. It really should, yes. > Also, as I

When attempting to build syslinux in parallel (make -j5), I encountered the following error at the end: rm -f liblpxelinux.a ar cq liblpxelinux.a rawcon.o ./fs/pxe/dhcp_option.o ./fs/pxe/pxe.o ./fs/pxe/tftp.o ./fs/pxe/urlparse.o ./lwip/src/netif/ethernetif.o ./lwip/src/netif/etharp.o ./lwip/src/netif/slipif.o ./lwip/src/netif/ppp/md5.o ./lwip/src/netif/ppp/randm.o ./lwip/src/netif/ppp/chpms.o

...adcast addr */ 40, /* NIS domain name (why?) */ + 119, /* Domain Search Option */ }; static uint8_t dhcp_discover_hdr[] = { @@ -158,7 +159,7 @@ static int dhcp_parse(struct netdev *dev, struct bootp_hdr *hdr, static int dhcp_recv(struct netdev *dev) { struct bootp_hdr bootp; - uint8_t dhcp_options[1500]; + uint8_t dhcp_options[BOOTP_EXTS_SIZE]; struct iovec iov[] = { /* [0] = ip + udp header */ [1] = {&bootp, sizeof(struct bootp_hdr)}, diff --git a/usr/kinit/ipconfig/main.c b/usr/kinit/ipconfig/main.c index 148ccb6..476384a 100644 --- a/usr/kinit/ipconfig/main.c +++ b/usr/kinit/i...

Hi guys, I'm have a pure 64-bit system (Intel based). Due to that I can't use 32-bit ELF extlinux binary provided in the syslinux-6.03 package. Unfortunately building extlinux installer failed... See error below after these command: make bios clean make bios (failed) ... ar cq liblpxelinux.a rawcon.o pxeboot.o pxelinux-c.o fs/pxe/dhcp_option.o fs/pxe/pxe.o fs/pxe/tftp.o

On Sun, Feb 8, 2015 at 7:49 PM, Alexey Orishko via Syslinux <syslinux at zytor.com> wrote: > Hi guys, > > I'm have a pure 64-bit system (Intel based). Due to that I can't use 32-bit ELF > extlinux binary provided in the syslinux-6.03 package. > > Unfortunately building extlinux installer failed... > > See error below after these command: > make bios clean

On Sun, 8 Feb 2015 20:21:58 -0500 Gene Cumm via Syslinux <syslinux at zytor.com> wrote: > On Sun, Feb 8, 2015 at 7:49 PM, Alexey Orishko via Syslinux > <syslinux at zytor.com> wrote: > > Hi guys, > > > > I'm have a pure 64-bit system (Intel based). Due to that I can't > > use 32-bit ELF extlinux binary provided in the syslinux-6.03 > >

I am working on setting up a global boot server that serves up files across the WAN. I am running into a 5 minute timer that is rebooting my hosts before they can complete the kernel and initrd file download. The servers in questions are HP DL60s, and they use UEFI. I am using syslinux.efi version 6.03. They get the kernel file from the TFTP server in about 2 ? minutes, then get 2 ? more minutes

On 01.07.2015 17:46, Ady via Syslinux wrote: > >> On 01.07.2015 12:10, Gene Cumm wrote: >>> On Wed, Jul 1, 2015 at 4:35 AM, poma <pomidorabelisima at gmail.com> wrote: >>>> >>>> To remind you once again. >>>> ISOLINUX >= 6.00 built with GCC >= 5.0.0 causes a broken boot. >>>> This relates specifically to the use of the

...mething other than TFTP to get the kernel/initrd > files (FTP, HTTP, etc)? TFTP is inherently slow across the WAN since > every packet has to be acknowledge before the next one can be sent. > DHCP 211 is "pxelinux.reboottime". See http://www.syslinux.org/wiki/index.php/PXELINUX#DHCP_options for further information. And karma bonus points for reporting your milage. Groeten Geert Stappers -- Leven en laten leven ------------- volgend deel ------------ Een niet-tekst bijlage is gescrubt... Naam: signature.asc Type: application/pgp-signature Grootte: 836 bytes Omschrijving: Digital si...

On 01.07.2015 12:10, Gene Cumm wrote: > On Wed, Jul 1, 2015 at 4:35 AM, poma <pomidorabelisima at gmail.com> wrote: >> >> To remind you once again. >> ISOLINUX >= 6.00 built with GCC >= 5.0.0 causes a broken boot. >> This relates specifically to the use of the vesamenu.c32, >> menu.c32 works without problemos. > > isolinux-debug.bin is not for