search for: dguestfs_warn_deprecated

Since there are deprecated APIs, make sure that users notice they are deprecated in more prominent ways than done so far: - using deprecated C functions now warns by default - it is possible to use the C library making sure no deprecated function is ever used - Python/Ruby/Perl scripts now get warning messages (configured according to their own systems) when deprecated functions are used The

...mon/utils SUBDIRS += lib docs examples po # The daemon and the appliance. diff --git a/align/Makefile.am b/align/Makefile.am index 8d4fce11b..99a80dd73 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -30,6 +30,7 @@ virt_alignment_scan_SOURCES = \ virt_alignment_scan_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ + -I$(top_srcdir)/common/cleanups -I$(top_builddir)/common/cleanups \ -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/lib -I$(top_builddir)/lib \ -I$(top_srcdir)/common/options -I$(top_builddir)/common/options \ @@ -47,6 +48,7 @@ virt_alignment_scan_LDADD = \...

...common/utils SUBDIRS += src docs examples po # The daemon and the appliance. diff --git a/align/Makefile.am b/align/Makefile.am index aaa0453..86975a3 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -39,6 +39,7 @@ virt_alignment_scan_SOURCES = \ virt_alignment_scan_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ + -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/src -I$(top_builddir)/src \ -I$(top_srcdir)/df \ -I$(top_srcdir)/fish \ @@ -52,7 +53,7 @@ virt_alignment_scan_CFLAGS = \ $(LIBVIRT_CFLAGS) virt_alignment_scan_LDADD = \ - $(top_builddir)/src/libutils.la \...

...mon/structs SUBDIRS += lib docs examples po # The daemon and the appliance. diff --git a/align/Makefile.am b/align/Makefile.am index 8d4fce11b..cc8df13f7 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -31,6 +31,7 @@ virt_alignment_scan_SOURCES = \ virt_alignment_scan_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ + -I$(top_srcdir)/common/structs -I$(top_builddir)/common/structs \ -I$(top_srcdir)/lib -I$(top_builddir)/lib \ -I$(top_srcdir)/common/options -I$(top_builddir)/common/options \ -I$(top_srcdir)/common/parallel -I$(top_builddi...

...essions/Makefile.am | 6 ++---- 5 files changed, 2 insertions(+), 9 deletions(-) diff --git a/align/Makefile.am b/align/Makefile.am index 04eea16..833739a 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -50,7 +50,6 @@ virt_alignment_scan_SOURCES = \ virt_alignment_scan_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ - -DGUESTFS_PRIVATE=1 \ -I$(top_srcdir)/src -I$(top_builddir)/src \ -I$(top_srcdir)/df \ -I$(top_srcdir)/fish \ diff --git a/df/Makefile.am b/df/Makefile.am index 256263d..83879cd 100644 --- a/df/Makefile.am +++ b/df/Makefile.am @@ -54,7 +54,6 @@ virt_df_SOURCES = \ virt_df_CPPFLAGS =...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.

On 09/04/2014 06:49 PM, Pino Toscano wrote: > On Thursday 04 September 2014 18:06:05 Maros Zatko wrote: >> I'm trying to convince autotools to allow me to include fish.c in a C >> file containing a bunch of unit tests. In order to do that I need to >> convince it add include path (-I../) to gcc for that particular file >> (test-quoting.c originally, but dash seems to

From: "Richard W.M. Jones" <rjones at redhat.com> If the parent process uses a pipe (or any fd, but pipes are a particular problem), then the recovery process would hold open the file descriptor(s) of the pipe, meaning that it could not be fully closed in the parent. Because the recovery process doesn't use exec(2), this wasn't avoidable even using FD_CLOEXEC. Avoid this

...-27,8 +27,8 @@ if HAVE_FUSE test_parallel_mount_local_SOURCES = \ test-parallel-mount-local.c \ - $(top_srcdir)/df/estimate-max-threads.c \ - $(top_srcdir)/df/estimate-max-threads.h + ../../df/estimate-max-threads.c \ + ../../df/estimate-max-threads.h test_parallel_mount_local_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ diff --git a/v2v/Makefile.am b/v2v/Makefile.am index 7435d5c..cbc14be 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -86,7 +86,7 @@ SOURCES_ML = \ v2v.ml SOURCES_C = \ - $(top_srcdir)/mllib/mkdtemp-c.c \ + ../mllib/mkdtemp-...

.../Makefile.am > index 063706f8f..18b6dd678 100644 > --- a/lib/Makefile.am > +++ b/lib/Makefile.am > @@ -130,7 +130,6 @@ libguestfs_la_SOURCES = \ > libguestfs.syms > > libguestfs_la_CPPFLAGS = \ > - -DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"' \ > -DGUESTFS_WARN_DEPRECATED=1 \ > -DGUESTFS_PRIVATE=1 \ > -DLIBOSINFO_DB_PATH='"$(datadir)/libosinfo/db"' \ > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > index 890b1999c..81c43879f 100644 > --- a/m4/guestfs_appliance.m4 > +++ b/m4/guestfs_appliance.m4 > @@ -128,3...

...ons.c \ + test-tool.c libguestfs_test_tool_CPPFLAGS = \ -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/lib -I$(top_builddir)/lib \ + -I$(top_srcdir)/common/options -I$(top_builddir)/common/options \ -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ -DGUESTFS_WARN_DEPRECATED=1 \ -DLOCALEBASEDIR=\""$(datadir)/locale"\" diff --git a/test-tool/test-tool.c b/test-tool/test-tool.c index 49e9ab22a..73e084e50 100644 --- a/test-tool/test-tool.c +++ b/test-tool/test-tool.c @@ -37,6 +37,7 @@ #include "guestfs.h" #include "guestfs-utils.h&...

...he old APIs continue to be supported, along with the LIBGUESTFS_ATTACH_METHOD environment variable, and the synonym "appliance" instead of "direct". Because these are part of the C API they will be supported forever, but you can get a warning about using them by compiling with -DGUESTFS_WARN_DEPRECATED=1. See this large but mostly mechanical patch: https://github.com/libguestfs/libguestfs/commit/68990840b64491b39ab8da5f1e46367ae5f01594 Also note this change will be included in RHEL 7. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones virt-top is 'top...

...guestfs_lstatns > guestfs_lstatnslist > > which return the new struct (or array of structs in the last case). > > The old APIs may of course still be used, forever, but are deprecated > and shouldn't be used in new programs. > > Because virt tools are compiled with -DGUESTFS_WARN_DEPRECATED=1, I > have updated all the places calling the deprecated functions. This > has revealed some areas for improvement: in particular virt-diff and > virt-ls could be changed to print the nanosecond fields. > > FUSE now returns nanoseconds in stat calls where available, fixing > ht...

..._SOURCES = \ tmpdirs.c \ libguestfs.syms +if DARWIN +# gnulib requires program_name to be defined on non-glibc systems, in +# particular MacOS X. +libguestfs_la_SOURCES += program_name.c +endif + libguestfs_la_CPPFLAGS = \ -DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"' \ -DGUESTFS_WARN_DEPRECATED=1 \ diff --git a/src/program_name.c b/src/program_name.c new file mode 100644 index 0000000..e1b2e19 --- /dev/null +++ b/src/program_name.c @@ -0,0 +1,4 @@ +/* gnulib requires char *program_name to be defined for non-glibc systems + * (like MacOS X). + */ +const char *program_name = "libguestf...

...pi/Makefile.am | 1 + 25 files changed, 116 insertions(+), 46 deletions(-) diff --git a/align/Makefile.am b/align/Makefile.am index cd80c19..857253f 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -41,7 +41,7 @@ virt_alignment_scan_SOURCES = \ virt_alignment_scan_CFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ - -DGUESTFS_PRIVATE_FUNCTIONS=1 \ + -DGUESTFS_PRIVATE=1 \ -I$(top_srcdir)/src -I$(top_builddir)/src \ -I$(top_srcdir)/fish \ -I$(srcdir)/../gnulib/lib -I../gnulib/lib \ diff --git a/df/Makefile.am b/df/Makefile.am index eeec484..52cb4ab 100644 --- a/df/Makefile.am +++ b/df/Makefile.am @@...

Some of the C tools were building also config.c as part of the shared sources from guestfish, and thus bringing a dependency on libconfig. Since none of them actually read the libguestfs configuration at all, then exclude fish/config.c from their build, and stop linking to libconfig. --- align/Makefile.am | 3 --- df/Makefile.am | 3 --- edit/Makefile.am | 3 ---

...d-cleanups.h \ structs-cleanup.c \ structs-print.c \ - structs-print.h \ - uefi.c + structs-print.h BUILT_SOURCES = \ $(generator_built) @@ -40,7 +39,6 @@ libutils_la_SOURCES = \ structs-cleanup.c \ structs-print.c \ structs-print.h \ - uefi.c \ utils.c libutils_la_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ diff --git a/common/utils/guestfs-internal-frontend.h b/common/utils/guestfs-internal-frontend.h index e48f4eb49..489b54ffd 100644 --- a/common/utils/guestfs-internal-frontend.h +++ b/common/utils/guestfs-internal-frontend.h @@ -102,18 +102,6 @@ extern void guestfs_int_fadvise_noreuse (int fd);...

This turned out to be rather more involved than I thought. We have lots of utility functions, spread all over the repository, with not a lot of structure. This moves many of them under common/ and structures them so there are clear dependencies. This doesn't complete the job by any means. Other items I had on my to-do list for this change were: - Split up mllib/common_utils into: -

...ython binding adds explicit g.close() method. - Python programs can now use the new event API. - Python GIL is released during libguestfs calls, allowing multithreaded Python programs to work properly. - 9pfs (Plan 9 filesystems exported from the host) are now supported. - Add -DGUESTFS_WARN_DEPRECATED=1 to warn about use of deprecated API functions in C programs. - New manual page guestfs-recipes(1) with recipes. - mkfs-opts can now set inode size and sector size on created filesystems (thanks Nikita Menkovich). - guestfs_last_errno is now accessible from OCaml (as g#last_e...