search for: dguestfs_private

...5 files changed, 2 insertions(+), 9 deletions(-) diff --git a/align/Makefile.am b/align/Makefile.am index 04eea16..833739a 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -50,7 +50,6 @@ virt_alignment_scan_SOURCES = \ virt_alignment_scan_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ - -DGUESTFS_PRIVATE=1 \ -I$(top_srcdir)/src -I$(top_builddir)/src \ -I$(top_srcdir)/df \ -I$(top_srcdir)/fish \ diff --git a/df/Makefile.am b/df/Makefile.am index 256263d..83879cd 100644 --- a/df/Makefile.am +++ b/df/Makefile.am @@ -54,7 +54,6 @@ virt_df_SOURCES = \ virt_df_CPPFLAGS = \ -DGUESTFS_WARN_DEPRE...

Shuffle the order of the various CFLAGS used when building the Ruby extension: first the flags from manywarnings (gnulib), then libguestfs own CFLAGS, and then -DGUESTFS_PRIVATE=1 (so it is not overridden). This matches also what happens in automake parts, and makes it possible to override any flags from manywarnings also in the Ruby extension. --- ruby/ext/guestfs/extconf.rb.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ruby/ext/guestfs/ext...

...files changed, 116 insertions(+), 46 deletions(-) diff --git a/align/Makefile.am b/align/Makefile.am index cd80c19..857253f 100644 --- a/align/Makefile.am +++ b/align/Makefile.am @@ -41,7 +41,7 @@ virt_alignment_scan_SOURCES = \ virt_alignment_scan_CFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ - -DGUESTFS_PRIVATE_FUNCTIONS=1 \ + -DGUESTFS_PRIVATE=1 \ -I$(top_srcdir)/src -I$(top_builddir)/src \ -I$(top_srcdir)/fish \ -I$(srcdir)/../gnulib/lib -I../gnulib/lib \ diff --git a/df/Makefile.am b/df/Makefile.am index eeec484..52cb4ab 100644 --- a/df/Makefile.am +++ b/df/Makefile.am @@ -44,7 +44,7 @@ virt_df_S...

Since there are deprecated APIs, make sure that users notice they are deprecated in more prominent ways than done so far: - using deprecated C functions now warns by default - it is possible to use the C library making sure no deprecated function is ever used - Python/Ruby/Perl scripts now get warning messages (configured according to their own systems) when deprecated functions are used The

> > After using 'python sdist', can't you use the tarball (in python/dist) > > in order to create a venv directly? > > I think I will be able to install the python library in the venv using > the tarball. However, won't my liguestfs application require some of > the binaries installed as part of 'make install' for running? I am > trying to not

...RARIES = libutils.la + +libutils_la_SOURCES = \ + ../src/guestfs.h \ + cleanup.c \ + guestfs-internal-frontend.h \ + guestfs-internal-frontend-cleanups.h \ + structs-cleanup.c \ + structs-print.c \ + structs-print.h \ + uefi.c \ + utils.c +libutils_la_CPPFLAGS = \ + -DGUESTFS_WARN_DEPRECATED=1 \ + -DGUESTFS_PRIVATE=1 \ + -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ + -I$(top_srcdir)/src -I$(top_builddir)/src +libutils_la_CFLAGS = \ + $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(GCC_VISIBILITY_HIDDEN) \ + $(LIBXML2_CFLAGS) diff --git a/src/cleanup.c b/common/utils/cleanup.c similarity index 100% rename f...

I needed to add a few patches to be able to build libguestfs 1.20.2 out of tree. Mostly srcdir/builddir issues -- I think that I had posted something for building the daemon before. As mentioned on IRC, I found that compiling (Ruby bindings) caused config.h file shipped with the Ruby headers to be included rather than ${builddir}/config.h. This can be fixed because the relevant checks can be

...akefile.am @@ -34,7 +34,6 @@ noinst_LTLIBRARIES = libutils.la libutils_la_SOURCES = \ ../../lib/guestfs.h \ - cleanup.c \ guestfs-internal-frontend.h \ guestfs-internal-frontend-cleanups.h \ structs-cleanup.c \ @@ -46,6 +45,7 @@ libutils_la_CPPFLAGS = \ -DGUESTFS_WARN_DEPRECATED=1 \ -DGUESTFS_PRIVATE=1 \ -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ + -I$(top_srcdir)/common/cleanups -I$(top_builddir)/common/cleanups \ -I$(top_srcdir)/lib -I$(top_builddir)/lib libutils_la_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) \ diff --git a/common/utils/guestfs-internal-frontend.h b/commo...

...irst attempt to Cédric tried was to call guestfs_internal_parse_mountable which conveniently splits the internal string into a device and a volume. As the name suggests, that is an internal API. We shouldn't be calling this from our tools, and in any case it doesn't work unless we define -DGUESTFS_PRIVATE=1 all over the place. So that's a bad idea. I think probably the way to solve this is with new public APIs for returning the device and volume name from a mountable. Similar to guestfs_internal_parse_mountable in fact, but a public API that we commit to. char *device = guestfs_mountable_d...

...Ruby bindings). AC_ARG_ENABLE([ruby], diff --git a/python/Makefile.am b/python/Makefile.am index e514a76..ecc25d5 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -43,7 +43,7 @@ libguestfsmod_la_SOURCES = guestfs-py.c guestfs-py.h guestfs-py-byhand.c libguestfsmod_la_CPPFLAGS = \ -DGUESTFS_PRIVATE=1 \ - -I$(PYTHON_INCLUDEDIR) \ + $(PYTHON_CFLAGS) \ -I$(top_srcdir)/src -I$(top_builddir)/src libguestfsmod_la_CFLAGS = \ -- 1.7.10.4

...ME_SPACE \ -I. \ -I$(top_builddir) \ -I$(shell $(OCAMLC) -where) \ diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am index 4d13eed97..b31e8fc65 100644 --- a/ocaml/Makefile.am +++ b/ocaml/Makefile.am @@ -78,6 +78,7 @@ endif touch $@ libguestfsocaml_a_CPPFLAGS = \ + -DCAML_NAME_SPACE \ -DGUESTFS_PRIVATE=1 \ -I$(top_builddir) -I$(OCAMLLIB) -I$(top_srcdir)/ocaml \ -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ diff --git a/v2v/Makefile.am b/v2v/Makefile.am index b5761ef46..277b95c31 100644 --- a/v2v/Makefile.am +++ b/v2v/Makefile.am @@ -179,6 +179,7 @@ bin_PROGRAMS = virt-v2v virt...

version 3: - Split requires into configure_requires/etc. - Use lists for extra_compiler_flags, extra_linker_flags. - Suppress .packlist file. - Set the release_status field. Rich.

...anups.h \ + structs-print.c \ + structs-print.h + +BUILT_SOURCES = \ + $(generator_built) + +EXTRA_DIST = \ + $(BUILT_SOURCES) + +noinst_LTLIBRARIES = libstructs.la + +libstructs_la_SOURCES = \ + ../../lib/guestfs.h \ + $(BUILT_SOURCES) +libstructs_la_CPPFLAGS = \ + -DGUESTFS_WARN_DEPRECATED=1 \ + -DGUESTFS_PRIVATE=1 \ + -I$(top_srcdir)/gnulib/lib -I$(top_builddir)/gnulib/lib \ + -I$(top_srcdir)/lib -I$(top_builddir)/lib +libstructs_la_CFLAGS = \ + $(WARN_CFLAGS) $(WERROR_CFLAGS) \ + $(GCC_VISIBILITY_HIDDEN) diff --git a/common/utils/Makefile.am b/common/utils/Makefile.am index 5c9728797..a86b715f6 100644 ---...

This patch series moves some files and directories around but is only code motion (or supposed to be). A new directory, common/, is created for all of the common code which is currently shared in random ways between parts of the project. And src/ becomes lib/ (the largest change, but mostly mechanical). In full this series makes the following changes: src/libprotocol -> common/protocol

...b6dd678 100644 > --- a/lib/Makefile.am > +++ b/lib/Makefile.am > @@ -130,7 +130,6 @@ libguestfs_la_SOURCES = \ > libguestfs.syms > > libguestfs_la_CPPFLAGS = \ > - -DGUESTFS_DEFAULT_PATH='"$(libdir)/guestfs"' \ > -DGUESTFS_WARN_DEPRECATED=1 \ > -DGUESTFS_PRIVATE=1 \ > -DLIBOSINFO_DB_PATH='"$(datadir)/libosinfo/db"' \ > diff --git a/m4/guestfs_appliance.m4 b/m4/guestfs_appliance.m4 > index 890b1999c..81c43879f 100644 > --- a/m4/guestfs_appliance.m4 > +++ b/m4/guestfs_appliance.m4 > @@ -128,3 +128,14 @@ AC_ARG_WITH([extr...

Previous patch series was posted here: https://www.redhat.com/archives/libguestfs/2017-January/msg00059.html v2 simply extends this patch series to cover the extra directories common/edit, common/progress, common/windows and common/parallel. The only remaining item is to consider whether we should rename mllib to something else, mlcommon was my suggestion. Rich.

...test-big-heap rhbz501893_SOURCES = rhbz501893.c rhbz501893_CPPFLAGS = \ @@ -130,5 +132,14 @@ rhbz1055452_CFLAGS = \ rhbz1055452_LDADD = \ $(top_builddir)/src/libguestfs.la +test_big_heap_SOURCES = test-big-heap.c +test_big_heap_CPPFLAGS = \ + -I$(top_srcdir)/src -I$(top_builddir)/src \ + -DGUESTFS_PRIVATE=1 +test_big_heap_CFLAGS = \ + $(WARN_CFLAGS) $(WERROR_CFLAGS) +test_big_heap_LDADD = \ + $(top_builddir)/src/libguestfs.la + check-slow: $(MAKE) TESTS="rhbz909624.sh" check diff --git a/tests/regressions/test-big-heap.c b/tests/regressions/test-big-heap.c new file mode 100644 index 000...

...file.am b/python/Makefile.am index c2f57a6ba..b470d2df2 100644 --- a/python/Makefile.am +++ b/python/Makefile.am @@ -63,7 +63,8 @@ libguestfsmod_la_SOURCES = \ actions.h \ handle.c \ module.c \ - structs.c + structs.c \ + ../common/utils/stringlists-utils.c libguestfsmod_la_CPPFLAGS = \ -DGUESTFS_PRIVATE=1 \ @@ -75,7 +76,6 @@ libguestfsmod_la_CFLAGS = \ $(WARN_CFLAGS) $(WERROR_CFLAGS) libguestfsmod_la_LIBADD = \ - $(top_builddir)/common/utils/libutils_la-utils.lo \ $(top_builddir)/lib/libguestfs.la libguestfsmod_la_LDFLAGS = -avoid-version -shared -module -shrext $(PYTHON_EXT_SUFFIX) @@ -...

...uot;%%m\"); RETVAL = newSVpv (str, 0); free (str); OUTPUT: diff --git a/lua/Makefile.am b/lua/Makefile.am index f90c1d7cb..a26c0baee 100644 --- a/lua/Makefile.am +++ b/lua/Makefile.am @@ -41,6 +41,7 @@ libluaguestfs_la_SOURCES = lua-guestfs.c libluaguestfs_la_CPPFLAGS = \ -DGUESTFS_PRIVATE=1 \ + -I$(srcdir)/../gnulib/lib -I../gnulib/lib \ -I$(top_srcdir)/common/utils -I$(top_builddir)/common/utils \ -I$(top_srcdir)/lib -I$(top_builddir)/lib -- 2.13.2

This is almost just refactoring, but I also set the memory limit to really 1 GB, and not 1×10⁹. --- src/info.c | 27 +++++++++++++++------------ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/src/info.c b/src/info.c index d7f45f0..616ef50 100644 --- a/src/info.c +++ b/src/info.c @@ -56,6 +56,7 @@ static yajl_val get_json_output (guestfs_h *g, const char *filename); static char