search for: dgilbert

From: "Dr. David Alan Gilbert" <dgilbert at redhat.com> Add the virtio shared memory region definitions that have just got merged into the spec. Dr. David Alan Gilbert (4): virtio_pci: Define id field virtio_pci: Define virtio_pci_cap64 virtio_pci: Defined shared memory capability virito_mmio: Define shared memory region regi...

...st_reset_is_le to do just half >> of the job. Let us make vhost_reset_is_le reinitialize is_le. >> >> Signed-off-by: Halil Pasic <pasic at linux.vnet.ibm.com> >> Reported-by: Michael A. Tebolt <miket at us.ibm.com> >> Reported-by: Dr. David Alan Gilbert <dgilbert at redhat.com> >> Fixes: commit 2751c9882b94 ("vhost: cross-endian support for legacy devices") >> --- > Reviewed-by: Greg Kurz <groug at kaod.org> > Thanks! We have some tests on s390x (that is BE) running, but I won't be able to test the change with cr...

...st_reset_is_le to do just half >> of the job. Let us make vhost_reset_is_le reinitialize is_le. >> >> Signed-off-by: Halil Pasic <pasic at linux.vnet.ibm.com> >> Reported-by: Michael A. Tebolt <miket at us.ibm.com> >> Reported-by: Dr. David Alan Gilbert <dgilbert at redhat.com> >> Fixes: commit 2751c9882b94 ("vhost: cross-endian support for legacy devices") >> --- > Reviewed-by: Greg Kurz <groug at kaod.org> > Thanks! We have some tests on s390x (that is BE) running, but I won't be able to test the change with cr...

...ration Time (average) > > Optimization v.s. Legacy = 1407ms v.s. 2528ms --> ~44% reduction > > - Linux Compilation Time > > Optimization v.s. Legacy = 5min4s v.s. 5min12s > > --> no obvious difference > > I'd like to see dgilbert's take on whether this kind of gain > justifies adding a PV interfaces, and what kind of guest workload > is appropriate. > > Cc'd. Well, 44% is great ... although the measurement is a bit weird. a) A 2 second downtime is very large; 300-500ms is more normal b) I'm not su...

...With the above, there is no reason for vhost_reset_is_le to do just half of the job. Let us make vhost_reset_is_le reinitialize is_le. Signed-off-by: Halil Pasic <pasic at linux.vnet.ibm.com> Reported-by: Michael A. Tebolt <miket at us.ibm.com> Reported-by: Dr. David Alan Gilbert <dgilbert at redhat.com> Fixes: commit 2751c9882b94 ("vhost: cross-endian support for legacy devices") --- The bug was already discussed here: http://www.spinics.net/lists/kvm/msg144365.html This is a follow up patch. --- drivers/vhost/vhost.c | 10 ++++------ 1 file changed, 4 insertions(+)...

...With the above, there is no reason for vhost_reset_is_le to do just half of the job. Let us make vhost_reset_is_le reinitialize is_le. Signed-off-by: Halil Pasic <pasic at linux.vnet.ibm.com> Reported-by: Michael A. Tebolt <miket at us.ibm.com> Reported-by: Dr. David Alan Gilbert <dgilbert at redhat.com> Fixes: commit 2751c9882b94 ("vhost: cross-endian support for legacy devices") --- The bug was already discussed here: http://www.spinics.net/lists/kvm/msg144365.html This is a follow up patch. --- drivers/vhost/vhost.c | 10 ++++------ 1 file changed, 4 insertions(+)...

At this point, I've been through 4 AMD64 motherboards. Commonly, AE_BAD_CHARACTER stops ACPI (or apic?) from figuring out the system --- this has happened on 3 out of four boards. On this latest board, it can turn off APIC. If I do that, FreeBSD hangs after detecting the disks. The only "wrong" thing on the screen is module_register_init: MOD_LOAD (amr_linux,

...in the second migration, QEMU will request the guest for free pages Information, and the guest will traverse it's current free page list to construct a new free page bitmap and send it to QEMU. Just like in the first migration. Liang > > Dave > > -- > Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK

...in the second migration, QEMU will request the guest for free pages Information, and the guest will traverse it's current free page list to construct a new free page bitmap and send it to QEMU. Just like in the first migration. Liang > > Dave > > -- > Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK

...>page_bitmap[i]); > +} It might be worth commenting that pair of functions to make it clear why they are so different; I guess the kfree_page_bitmap is used just before you free the structure above it so you don't need to keep the count/pointers updated? Dave -- Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK

...>page_bitmap[i]); > +} It might be worth commenting that pair of functions to make it clear why they are so different; I guess the kfree_page_bitmap is used just before you free the structure above it so you don't need to keep the count/pointers updated? Dave -- Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK

...the performance > downgrade is still obvious. > > > Could anyone give some help about this issue? > > Feng Li <lifeng1519 at gmail.com> ?2018?10?1??? ??10:58??? > > > > Hi Dave, > > My comments are in-line. > > > > Dr. David Alan Gilbert <dgilbert at redhat.com> ?2018?10?1??? ??7:41??? > > > > > > * Feng Li (lifeng1519 at gmail.com) wrote: > > > > Hi, > > > > I found an obvious performance downgrade when virtio-console combined > > > > with virtio-pci-blk. > > > > > >...

...Optimization v.s. Legacy = 1407ms v.s. 2528ms --> ~44% reduction > > > > - Linux Compilation Time > > > > Optimization v.s. Legacy = 5min4s v.s. 5min12s > > > > --> no obvious difference > > > I'd like to see dgilbert's take on whether this kind of gain > > > justifies adding a PV interfaces, and what kind of guest workload > > > is appropriate. > > > > > > Cc'd. > > Well, 44% is great ... although the measurement is a bit weird. > > > > a) A 2 seco...

...for free pages > Information, and the guest will traverse it's current free page list to construct a > new free page bitmap and send it to QEMU. Just like in the first migration. Right. Dave > Liang > > > > Dave > > > > -- > > Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK -- Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK

...it's current free page list to construct a > > new free page bitmap and send it to QEMU. Just like in the first migration. > > Right. > > Dave > > > Liang > > > > > > Dave > > > > > > -- > > > Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK > -- > Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK

...it's current free page list to construct a > > new free page bitmap and send it to QEMU. Just like in the first migration. > > Right. > > Dave > > > Liang > > > > > > Dave > > > > > > -- > > > Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK > -- > Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK

> > Could provide more information on how to use virtio-serial to exchange > data? Thread , Wiki or code are all OK. > > I have not find some useful information yet. > > See this commit in the Linux sources: > > 108fc82596e3b66b819df9d28c1ebbc9ab5de14c > > that adds a way to send guest trace data over to the host. I think that's the > most relevant to

> > Could provide more information on how to use virtio-serial to exchange > data? Thread , Wiki or code are all OK. > > I have not find some useful information yet. > > See this commit in the Linux sources: > > 108fc82596e3b66b819df9d28c1ebbc9ab5de14c > > that adds a way to send guest trace data over to the host. I think that's the > most relevant to

On Fri, Jan 13, 2017 at 09:24:22AM +0000, Li, Liang Z wrote: > > On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > > > Add a new feature which supports sending the page information with > > > range array. The current implementation uses PFNs array, which is not > > > very efficient. Using ranges can improve the performance of > > >

On Fri, Jan 13, 2017 at 09:24:22AM +0000, Li, Liang Z wrote: > > On Wed, Dec 21, 2016 at 02:52:25PM +0800, Liang Li wrote: > > > Add a new feature which supports sending the page information with > > > range array. The current implementation uses PFNs array, which is not > > > very efficient. Using ranges can improve the performance of > > >