search for: devmajor

...return 1; } +#define CHECK_MODE \ + do { \ + if ((mode & ~07777) != 0) { \ + reply_with_error ("%o: mode must specify only file permission bits", \ + (unsigned int) mode); \ + return -1; \ + } \ + } while (0) + int do_mknod (int mode, int devmajor, int devminor, const char *path) { @@ -63,18 +72,24 @@ do_mknod (int mode, int devmajor, int devminor, const char *path) int do_mkfifo (int mode, const char *path) { + CHECK_MODE; + return do_mknod (mode | S_IFIFO, 0, 0, path); } int do_mknod_b (int mode, int devmajor, int devminor, co...

...bguestfs - the guestfsd daemon - * Copyright (C) 2009 Red Hat Inc. + * Copyright (C) 2009-2012 Red Hat Inc. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by @@ -67,7 +67,7 @@ do_mknod (int mode, int devmajor, int devminor, const char *path) return 0; #else - NOT_AVAILABLE (-1); + NOT_AVAILABLE (mknod, -1); #endif } diff --git a/daemon/modprobe.c b/daemon/modprobe.c index 1063043..d7c5656 100644 --- a/daemon/modprobe.c +++ b/daemon/modprobe.c @@ -1,5 +1,5 @@ /* libguestfs - the guestfsd dae...

This started as a simple warning-elimination change. I'll get back to that series shortly ;-) It turned into a factorization and constification exercise during which I got a taste of ocaml. Thanks to Rich Jones for help with a few snippets in generator.ml. The overall result is that many previously-manually-maintained bits from daemon/*.c functions are now hoisted into the automatically-

I'm currently working on gobject bindings for libguestfs. I haven't got as far as compiling anything yet, but I've attached the C header for initial review. Matt -- Matthew Booth, RHCA, RHCSS Red Hat Engineering, Virtualisation Team GPG ID: D33C3490 GPG FPR: 3733 612D 2D05 5458 8A8A 1600 3441 EA19 D33C 3490 -------------- next part -------------- An embedded and

...ot;uuid"]; once_had_no_optargs = true; tests = [ InitEmpty, Always, TestRun ( @@ -4003,7 +4003,7 @@ label and/or UUID of the new swap partition." }; { defaults with name = "mknod"; added = (1, 0, 55); - style = RErr, [Int "mode"; Int "devmajor"; Int "devminor"; Pathname "path"], []; + style = RErr, [Int "mode"; Int "devmajor"; Int "devminor"; String (Pathname, "path")], []; optional = Some "mknod"; tests = [ InitScratchFS, Always, TestResult (...

Very large but mechanical change to the generator. Rich.

This is a follow-up to the other generator changes in: https://www.redhat.com/archives/libguestfs/2017-February/msg00217.html Rich.

Split up the huge generator/actions.ml into several smaller files. Rich.

The existing mechanism was clunky, slow and used ~ 10 MB of local disk. Rich.