search for: device_shutdown

...000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> ? __die+0x20/0x60 ? page_fault_oops+0x14c/0x3c0 ? exc_page_fault+0x75/0x140 ? asm_exc_page_fault+0x22/0x30 ? mlx5v_shutdown+0xe/0x50 [mlx5_vdpa] device_shutdown+0x13e/0x1e0 kernel_restart+0x36/0x90 __do_sys_reboot+0x141/0x210 ? vfs_writev+0xcd/0x140 ? handle_mm_fault+0x161/0x260 ? do_writev+0x6b/0x110 do_syscall_64+0x3d/0x90 entry_SYSCALL_64_after_hwframe+0x46/0xb0 RIP: 0033:0x7f496990fb56 RSP: 002b:00007fffc7bdde88 EFLAGS: 00000206 ORIG_RA...

...> > ?Call Trace: > > > ? <TASK> > > > ? ? __die+0x20/0x60 > > > ? ? page_fault_oops+0x14c/0x3c0 > > > ? ? exc_page_fault+0x75/0x140 > > > ? ? asm_exc_page_fault+0x22/0x30 > > > ? ? mlx5v_shutdown+0xe/0x50 [mlx5_vdpa] > > > ? device_shutdown+0x13e/0x1e0 > > > ? kernel_restart+0x36/0x90 > > > ? __do_sys_reboot+0x141/0x210 > > > ? ? vfs_writev+0xcd/0x140 > > > ? ? handle_mm_fault+0x161/0x260 > > > ? ? do_writev+0x6b/0x110 > > > ? do_syscall_64+0x3d/0x90 > > > ? entry_SYSCALL_...

...t; > ? <TASK> > > > > ? ? __die+0x20/0x60 > > > > ? ? page_fault_oops+0x14c/0x3c0 > > > > ? ? exc_page_fault+0x75/0x140 > > > > ? ? asm_exc_page_fault+0x22/0x30 > > > > ? ? mlx5v_shutdown+0xe/0x50 [mlx5_vdpa] > > > > ? device_shutdown+0x13e/0x1e0 > > > > ? kernel_restart+0x36/0x90 > > > > ? __do_sys_reboot+0x141/0x210 > > > > ? ? vfs_writev+0xcd/0x140 > > > > ? ? handle_mm_fault+0x161/0x260 > > > > ? ? do_writev+0x6b/0x110 > > > > ? do_syscall_64+0x3d/0x90 &...

...t; > > > ? ? __die+0x20/0x60 > > > > > ? ? page_fault_oops+0x14c/0x3c0 > > > > > ? ? exc_page_fault+0x75/0x140 > > > > > ? ? asm_exc_page_fault+0x22/0x30 > > > > > ? ? mlx5v_shutdown+0xe/0x50 [mlx5_vdpa] > > > > > ? device_shutdown+0x13e/0x1e0 > > > > > ? kernel_restart+0x36/0x90 > > > > > ? __do_sys_reboot+0x141/0x210 > > > > > ? ? vfs_writev+0xcd/0x140 > > > > > ? ? handle_mm_fault+0x161/0x260 > > > > > ? ? do_writev+0x6b/0x110 > > > > &g...

...ie+0x20/0x60 > > > > > > ? page_fault_oops+0x14c/0x3c0 > > > > > > ? exc_page_fault+0x75/0x140 > > > > > > ? asm_exc_page_fault+0x22/0x30 > > > > > > ? mlx5v_shutdown+0xe/0x50 [mlx5_vdpa] > > > > > > device_shutdown+0x13e/0x1e0 > > > > > > kernel_restart+0x36/0x90 > > > > > > __do_sys_reboot+0x141/0x210 > > > > > > ? vfs_writev+0xcd/0x140 > > > > > > ? handle_mm_fault+0x161/0x260 > > > > > > ? do_writev+0x6b/0x1...

...t; > > > > ? ? page_fault_oops+0x14c/0x3c0 > > > > > > > ? ? exc_page_fault+0x75/0x140 > > > > > > > ? ? asm_exc_page_fault+0x22/0x30 > > > > > > > ? ? mlx5v_shutdown+0xe/0x50 [mlx5_vdpa] > > > > > > > ? device_shutdown+0x13e/0x1e0 > > > > > > > ? kernel_restart+0x36/0x90 > > > > > > > ? __do_sys_reboot+0x141/0x210 > > > > > > > ? ? vfs_writev+0xcd/0x140 > > > > > > > ? ? handle_mm_fault+0x161/0x260 > > > > > > &g...

...know that much about suspend, but ISTR seeing comments about > resuming devices before we shutdown. If we do that, maybe there's > some kind of race between that resume and the reboot? I think we do in fact resume PCI devices before shutdown. Here's the path I'm looking at: device_shutdown pm_runtime_get_noresume pm_runtime_barrier dev->bus->shutdown pci_device_shutdown pm_runtime_resume __pm_runtime_resume(dev, 0) rpm_resume(dev, 0) __update_runtime_status(dev, RPM_RESUMING) callback = RPM_GET_CALLBACK...

...utdown as well, as the driver gets unloaded? I don???t remember > seeing that issue there though. Sorry Pierre, I missed this question and am seeing it only now on saving the message away: On shutdown the driver isn't unloaded, rather the driver core walks the device hierarchy bottom-up in device_shutdown() and, for PCI- enumerated GPUs, invokes the bus shutdown hook pci_device_shutdown(). This in turn would normally invoke ->shutdown in nouveau_drm_pci_driver, but we haven't defined it. So the only thing that happens is that pci_device_shutdown() runtime resumes the device and optionally tu...

...ISTR seeing comments about > > resuming devices before we shutdown. If we do that, maybe there's > > some kind of race between that resume and the reboot? > > I think we do in fact resume PCI devices before shutdown. Here's the > path I'm looking at: > > device_shutdown > pm_runtime_get_noresume > pm_runtime_barrier > dev->bus->shutdown > pci_device_shutdown > pm_runtime_resume > __pm_runtime_resume(dev, 0) > rpm_resume(dev, 0) > __update_runtime_status(dev, RPM_RESUMING) &...

Unbinding nouveau on a dual GPU MacBook Pro oopses because we iterate over the bl_connectors list in nouveau_backlight_exit() but skipped initializing it in nouveau_backlight_init(). Stacktrace for posterity: BUG: unable to handle kernel NULL pointer dereference at 0000000000000010 IP: nouveau_backlight_exit+0x2b/0x70 [nouveau] nouveau_display_destroy+0x29/0x80 [nouveau]

...; > resuming devices before we shutdown. If we do that, maybe there's > > > some kind of race between that resume and the reboot? > > > > I think we do in fact resume PCI devices before shutdown. Here's the > > path I'm looking at: > > > > device_shutdown > > pm_runtime_get_noresume > > pm_runtime_barrier > > dev->bus->shutdown > > pci_device_shutdown > > pm_runtime_resume > > __pm_runtime_resume(dev, 0) > > rpm_resume(dev, 0) > > __up...

[+cc Rafael] On Wed, Mar 13, 2019 at 06:25:02PM -0400, Lyude Paul wrote: > On Fri, 2019-02-15 at 16:17 -0500, Lyude Paul wrote: > > On Thu, 2019-02-14 at 18:43 -0600, Bjorn Helgaas wrote: > > > On Tue, Feb 12, 2019 at 05:02:30PM -0500, Lyude Paul wrote: > > > > On a very specific subset of ThinkPad P50 SKUs, particularly > > > > ones that come with a