search for: device_reset

...e don't free the unused buffers attached with the port. Re-plug the same port tries to allocate new buffers in virtqueue and results in this error if queue is full. This patch removes the unused buffers in vq's when we unplug the port. This is the best we can do as we cannot call device_reset because virtio device is still active. This was the working behaviour before the change introduced in commit b3258ff1d6. Reported-by: Xiaohui Li <xiaohli at redhat.com> Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") Signed-off-by: Pankaj Gupta <pagupt...

...e don't free the unused buffers attached with the port. Re-plug the same port tries to allocate new buffers in virtqueue and results in this error if queue is full. This patch removes the unused buffers in vq's when we unplug the port. This is the best we can do as we cannot call device_reset because virtio device is still active. This was the working behaviour before the change introduced in commit b3258ff1d6. Reported-by: Xiaohui Li <xiaohli at redhat.com> Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") Signed-off-by: Pankaj Gupta <pagupt...

...used buffers > attached with the port. Re-plug the same port tries to allocate new > buffers in virtqueue and results in this error if queue is full. > > This patch removes the unused buffers in vq's when we unplug the port. > This is the best we can do as we cannot call device_reset because virtio > device is still active. Why is this indented? > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") Fixes: b3258ff1d608 ("virtio: Decrement avail idx on buffer detach") is th...

...attached with the port. Re-plug the same port tries to allocate new > > buffers in virtqueue and results in this error if queue is full. > > > > This patch removes the unused buffers in vq's when we unplug the port. > > This is the best we can do as we cannot call device_reset because virtio > > device is still active. This was the working behaviour before the change > > introduced in commit b3258ff1d6. > > > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset...

...attached with the port. Re-plug the same port tries to allocate new > > buffers in virtqueue and results in this error if queue is full. > > > > This patch removes the unused buffers in vq's when we unplug the port. > > This is the best we can do as we cannot call device_reset because virtio > > device is still active. This was the working behaviour before the change > > introduced in commit b3258ff1d6. > > > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset...

...ocate new > buffers in virtqueue and results in this error if queue is full. So why not reuse the buffers that are already there in this case? Seems quite possible. > This patch removes the unused buffers in vq's when we unplug the port. > This is the best we can do as we cannot call device_reset because virtio > device is still active. > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > Cc: stable at vger.kernel.org > Signed-off-by: Pankaj Gupta <pagupta at redhat.com> This is rea...

...ocate new > buffers in virtqueue and results in this error if queue is full. So why not reuse the buffers that are already there in this case? Seems quite possible. > This patch removes the unused buffers in vq's when we unplug the port. > This is the best we can do as we cannot call device_reset because virtio > device is still active. > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > Cc: stable at vger.kernel.org > Signed-off-by: Pankaj Gupta <pagupta at redhat.com> This is rea...

This patch series fixes the issue with unplug/replug of a port in virtio console device, which fails with an error "Error allocating inbufs\n". Patch 2 makes virtio packed ring code compatible with virtio split ring. Tested the packed ring code with the qemu virtio 1.1 device code posted here [1]. Changes from v1[2] ----- Make virtio packed ring code compatible with split ring -

This patch series fixes the issue with unplug/replug of a port in virtio console driver which fails with an error "Error allocating inbufs\n". Patch 1 makes use of 'virtqueue_detach_unused_buf' function to detach the unused buffers during port hotunplug time. Patch 2 updates the next avail index for packed ring code. Tested the packed ring code with the qemu virtio 1.1 device

...ed buffers > attached with the port. Re-plug the same port tries to allocate new > buffers in virtqueue and results in this error if queue is full. > > This patch removes the unused buffers in vq's when we unplug the port. > This is the best we can do as we cannot call device_reset because virtio > device is still active. This was the working behaviour before the change > introduced in commit b3258ff1d6. > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") > Signed-o...

...used buffers > attached with the port. Re-plug the same port tries to allocate new > buffers in virtqueue and results in this error if queue is full. > > This patch removes the unused buffers in vq's when we unplug the port. > This is the best we can do as we cannot call device_reset because virtio > device is still active. This was the working behaviour before the change > introduced in commit b3258ff1d6. ping. This patch fixes a regression in upstream kernel, virtio_console driver. Can we please have this merged. Thanks, Pankaj > > Reported-by: Xiaohui...

...we don't free the unused buffers attached with the port. Re-plug the same port tries to allocate new buffers in virtqueue and results in this error if queue is full. This patch removes the unused buffers in vq's when we unplug the port. This is the best we can do as we cannot call device_reset because virtio device is still active. Reported-by: Xiaohui Li <xiaohli at redhat.com> Fixes: b3258ff1d6 ("virtio_console: free buffers after reset") Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/char/virtio_console.c | 14 +++++++++++--- 1 file changed,...

...quot;. As we don't free the unused buffers attached with the port. Re-plug the same port tries to allocate new buffers in virtqueue and results in this error if queue is full. This patch removes the unused buffers in vq's when we unplug the port. This is the best we can do as we cannot call device_reset because virtio device is still active. Reported-by: Xiaohui Li <xiaohli at redhat.com> Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") Cc: stable at vger.kernel.org Signed-off-by: Pankaj Gupta <pagupta at redhat.com> --- drivers/char/virtio_console.c | 14 ++...

...is error if queue is full. That's the basic issue, isn't it? Why aren't we reusing buffers that are already there? > > > > > > This patch removes the unused buffers in vq's when we unplug the port. > > > This is the best we can do as we cannot call device_reset because virtio > > > device is still active. This was the working behaviour before the change > > > introduced in commit b3258ff1d6. > > > > > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > > > Fixes: b3258ff1d6 ("virtio_console:...

...buffers while hot-unplugging port is simple and was working fine before. It seems logically correct as well. I agree we need a spec change for this. > > > This patch removes the unused buffers in vq's when we unplug the port. > > This is the best we can do as we cannot call device_reset because virtio > > device is still active. > > > > Reported-by: Xiaohui Li <xiaohli at redhat.com> > > Fixes: a7a69ec0d8e4 ("virtio_console: free buffers after reset") > > Cc: stable at vger.kernel.org > > Signed-off-by: Pankaj Gupta <pagupta...