Displaying 9 results from an estimated 9 matches for "device_get_dma_attr".
2017 Feb 08
2
[PATCH] virtio: Try to untangle DMA coherency
...tuation
>>>> + * already exists in the wild, maintain the old behaviour there.
>>>> */
>>>> - if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
>>>> + if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
>>>> + device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
>>>> return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
>>>>
>>>> return false;
>>>
>>> This is exactly what I feared.
>>
>> Yes, sorry about this. It works fine for virtio-pci (where &...
2017 Feb 08
2
[PATCH] virtio: Try to untangle DMA coherency
...tuation
>>>> + * already exists in the wild, maintain the old behaviour there.
>>>> */
>>>> - if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
>>>> + if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
>>>> + device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
>>>> return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
>>>>
>>>> return false;
>>>
>>> This is exactly what I feared.
>>
>> Yes, sorry about this. It works fine for virtio-pci (where &...
2017 Feb 01
3
[PATCH] virtio: Try to untangle DMA coherency
...going to break badly; since this situation
> > + * already exists in the wild, maintain the old behaviour there.
> > */
> > - if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
> > + if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
> > + device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
> > return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
> >
> > return false;
>
> This is exactly what I feared.
Yes, sorry about this. It works fine for virtio-pci (where "dma-coherent"
is used) and it also works...
2017 Feb 01
3
[PATCH] virtio: Try to untangle DMA coherency
...going to break badly; since this situation
> > + * already exists in the wild, maintain the old behaviour there.
> > */
> > - if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
> > + if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
> > + device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
> > return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
> >
> > return false;
>
> This is exactly what I feared.
Yes, sorry about this. It works fine for virtio-pci (where "dma-coherent"
is used) and it also works...
2017 Feb 01
4
[PATCH] virtio: Try to untangle DMA coherency
...y coherent, but has
+ * forgotten to tell us, is going to break badly; since this situation
+ * already exists in the wild, maintain the old behaviour there.
*/
- if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
+ if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
+ device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
return false;
--
2.11.0.dirty
2017 Feb 01
4
[PATCH] virtio: Try to untangle DMA coherency
...y coherent, but has
+ * forgotten to tell us, is going to break badly; since this situation
+ * already exists in the wild, maintain the old behaviour there.
*/
- if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
+ if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
+ device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
return false;
--
2.11.0.dirty
2017 Feb 09
0
[PATCH] virtio: Try to untangle DMA coherency
...ready exists in the wild, maintain the old behaviour there.
> > > > > */
> > > > > - if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
> > > > > + if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
> > > > > + device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
> > > > > return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
> > > > >
> > > > > return false;
> > > >
> > > > This is exactly what I feared.
> > >
> > > Yes, so...
2017 Feb 01
0
[PATCH] virtio: Try to untangle DMA coherency
...forgotten to tell us, is going to break badly; since this situation
> + * already exists in the wild, maintain the old behaviour there.
> */
> - if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
> + if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
> + device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
> return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
>
> return false;
This is exactly what I feared.
Could we identify fastboot and do the special dance just for it?
I'd like to do that instead. It's fastboot doing the unreasona...
2017 Feb 01
0
[PATCH] virtio: Try to untangle DMA coherency
...ce this situation
> > > + * already exists in the wild, maintain the old behaviour there.
> > > */
> > > - if (IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64))
> > > + if ((IS_ENABLED(CONFIG_ARM) || IS_ENABLED(CONFIG_ARM64)) &&
> > > + device_get_dma_attr(&vdev->dev) == DEV_DMA_COHERENT)
> > > return !virtio_has_feature(vdev, VIRTIO_F_VERSION_1);
> > >
> > > return false;
> >
> > This is exactly what I feared.
>
> Yes, sorry about this. It works fine for virtio-pci (where "dma-coheren...