search for: device_featur

From: Allen Hubbe <allen.hubbe at amd.com> Consume the parameter to device_features when parsing command line options. Otherwise the parameter may be used again as an option name. # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55 Unknown option "0xdeadbeef" Fixes: a4442ce58ebb ("vdpa: allow provisioning device features") Signed-off-by:...

From: Allen Hubbe <allen.hubbe at amd.com> Consume the parameter to device_features when parsing command line options. Otherwise the parameter may be used again as an option name. # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55 Unknown option "0xdeadbeef" Fixes: a4442ce58ebb ("vdpa: allow provisioning device features") Signed-off-by:...

...saving over packet rate could enable > this feature but we want to keep it off by default. > > One can still enable it when creating the vdpa device using vdpa tool by > providing features that include it. > > For example: > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > > Acked-by: Jason Wang <jasowang at redhat.com> > Signed-off-by: Eli Cohen <elic at nvidia.com> I have a question. Could you guys try with the recent XDP mergeable buffer rework? Does this address the performance issue you are observing? Specifically:...

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

...Would it be possible to merge at your earliest convenience? PS, adding my R-b to the patch. Thanks, -Siwei On Sat, May 13, 2023 at 12:42?AM Shannon Nelson <shannon.nelson at amd.com> wrote: > > From: Allen Hubbe <allen.hubbe at amd.com> > > Consume the parameter to device_features when parsing command line > options.? Otherwise the parameter may be used again as an option name. > >? # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55 >? Unknown option "0xdeadbeef" > > Fixes: a4442ce58ebb ("vdpa: allow provisioning devi...

...Would it be possible to merge at your earliest convenience? PS, adding my R-b to the patch. Thanks, -Siwei On Sat, May 13, 2023 at 12:42?AM Shannon Nelson <shannon.nelson at amd.com> wrote: > > From: Allen Hubbe <allen.hubbe at amd.com> > > Consume the parameter to device_features when parsing command line > options.? Otherwise the parameter may be used again as an option name. > >? # vdpa dev add ... device_features 0xdeadbeef mac 00:11:22:33:44:55 >? Unknown option "0xdeadbeef" > > Fixes: a4442ce58ebb ("vdpa: allow provisioning devi...

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

This patchset is pre-requisite to export and provision device config attributes and features for vdpa live migration, in a way backward and forward compatibility can be retained. The follow up work [1] will need to be built around the new feature provisioning uAPI, with which it's easier to formalize migration compatibility support at the driver level. Thanks, -Siwei [1] [PATCH v3 0/4] vDPA:

On Sun, Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: > One can still enable it when creating the vdpa device using vdpa tool by > providing features that include it. > > For example: > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > Signed-off-by: Eli Cohen <elic at nvidia.com> What's the reason to turn it off by default? It's generally a performance win isn't it? > --- > drivers/vdpa/mlx5/net/mlx5_vnet.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/d...

...Mar 12, 2023 at 10:39:19AM +0200, Eli Cohen wrote: > > > One can still enable it when creating the vdpa device using vdpa tool by > > > providing features that include it. > > > > > > For example: > > > $ vdpa dev add name vdpa0 mgmtdev pci/0000:86:00.2 device_features 0x300cb982b > > > > > > Signed-off-by: Eli Cohen <elic at nvidia.com> > > What's the reason to turn it off by default? It's generally a > > performance win isn't it? > It has negative impact on packet rate so we want to keep it off by default....

..._table_size_legacy; i++) + if (drv->feature_table_legacy[i] == fbit) + return; + } + BUG(); } EXPORT_SYMBOL_GPL(virtio_check_driver_offered_feature); @@ -161,6 +168,7 @@ static int virtio_dev_probe(struct device *_d) struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); u64 device_features; u64 driver_features; + u64 driver_features_legacy; unsigned status; /* We have a driver! */ @@ -177,7 +185,22 @@ static int virtio_dev_probe(struct device *_d) driver_features |= (1ULL << f); } - dev->features = driver_features & device_features; + /* Some drivers hav...

..._table_size_legacy; i++) + if (drv->feature_table_legacy[i] == fbit) + return; + } + BUG(); } EXPORT_SYMBOL_GPL(virtio_check_driver_offered_feature); @@ -161,6 +168,7 @@ static int virtio_dev_probe(struct device *_d) struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); u64 device_features; u64 driver_features; + u64 driver_features_legacy; unsigned status; /* We have a driver! */ @@ -177,7 +185,22 @@ static int virtio_dev_probe(struct device *_d) driver_features |= (1ULL << f); } - dev->features = driver_features & device_features; + /* Some drivers hav...

On 9/7/2023 5:07 PM, David Ahern wrote: > On 9/7/23 2:41 PM, Si-Wei Liu wrote: >> Hi David, >> >> Why this patch doesn't get picked in the last 4 months? Maybe the >> subject is not clear, but this is an iproute2 patch. Would it be >> possible to merge at your earliest convenience? >> >> PS, adding my R-b to the patch. >> > It got marked

On 9/7/2023 5:07 PM, David Ahern wrote: > On 9/7/23 2:41 PM, Si-Wei Liu wrote: >> Hi David, >> >> Why this patch doesn't get picked in the last 4 months? Maybe the >> subject is not clear, but this is an iproute2 patch. Would it be >> possible to merge at your earliest convenience? >> >> PS, adding my R-b to the patch. >> > It got marked

...rivers/virtio/virtio.c index a3df817..0f44cff 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -160,6 +160,7 @@ static int virtio_dev_probe(struct device *_d) struct virtio_device *dev = dev_to_virtio(_d); struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); u64 device_features; + u64 driver_features; unsigned status; /* We have a driver! */ @@ -168,15 +169,16 @@ static int virtio_dev_probe(struct device *_d) /* Figure out what features the device supports. */ device_features = dev->config->get_features(dev); - /* Features supported by both device and...

...e *dev); diff --git a/drivers/virtio/virtio.c b/drivers/virtio/virtio.c index 0f44cff..85a164e 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -161,6 +161,7 @@ static int virtio_dev_probe(struct device *_d) struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); u64 device_features; u64 driver_features; + u64 driver_features_legacy; unsigned status; /* We have a driver! */ @@ -177,7 +178,22 @@ static int virtio_dev_probe(struct device *_d) driver_features |= (1ULL << f); } - dev->features = driver_features & device_features; + /* Some drivers hav...

...rivers/virtio/virtio.c index a3df817..0f44cff 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -160,6 +160,7 @@ static int virtio_dev_probe(struct device *_d) struct virtio_device *dev = dev_to_virtio(_d); struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); u64 device_features; + u64 driver_features; unsigned status; /* We have a driver! */ @@ -168,15 +169,16 @@ static int virtio_dev_probe(struct device *_d) /* Figure out what features the device supports. */ device_features = dev->config->get_features(dev); - /* Features supported by both device and...

...rivers/virtio/virtio.c index a3df817..0f44cff 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -160,6 +160,7 @@ static int virtio_dev_probe(struct device *_d) struct virtio_device *dev = dev_to_virtio(_d); struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); u64 device_features; + u64 driver_features; unsigned status; /* We have a driver! */ @@ -168,15 +169,16 @@ static int virtio_dev_probe(struct device *_d) /* Figure out what features the device supports. */ device_features = dev->config->get_features(dev); - /* Features supported by both device and...

...rivers/virtio/virtio.c index 6faa014..498bded 100644 --- a/drivers/virtio/virtio.c +++ b/drivers/virtio/virtio.c @@ -160,6 +160,7 @@ static int virtio_dev_probe(struct device *_d) struct virtio_device *dev = dev_to_virtio(_d); struct virtio_driver *drv = drv_to_virtio(dev->dev.driver); u64 device_features; + u64 driver_features; unsigned status; /* We have a driver! */ @@ -168,15 +169,16 @@ static int virtio_dev_probe(struct device *_d) /* Figure out what features the device supports. */ device_features = dev->config->get_features(dev); - /* Features supported by both device and...