search for: device_attr_rw

Again, very minor fixups for later (I can even do them...) > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); DEVICE_ATTR_RW() please. Same for the other attributes you create in this patch. thanks, greg k-h

Again, very minor fixups for later (I can even do them...) > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); DEVICE_ATTR_RW() please. Same for the other attributes you create in this patch. thanks, greg k-h

On Thu, 2013-09-05 at 21:58 -0700, Greg Kroah-Hartman wrote: > Again, very minor fixups for later (I can even do them...) > > > +static DEVICE_ATTR(state, S_IRUGO|S_IWUSR, mic_show_state, mic_store_state); > > DEVICE_ATTR_RW() please. > > Same for the other attributes you create in this patch. > Sure, we will incorporate these changes along with your other feedback in patch 1 and post the next revision of this patch series. Thanks for the review! Sudeep Dutt

...+ return sprintf(buf, "%d\n", vi->in); +} + +/* + * struct device_attribute dev_attr_virtio_buf = { + * .attr = { + * .name = "virtio_buf", + * .mode = 0644 + * }, + * .show = virtio_buf_show, + * .store = virtio_buf_store + * } + */ +static DEVICE_ATTR_RW(virtio_buf); + + +/* + * The example_attr defined above is then grouped in the struct attribute group + * as follows: + */ +struct attribute *example_attrs[] = { + &dev_attr_virtio_buf.attr, + NULL, +}; + +static const struct attribute_group example_attr_group = { + .name = "examp...

...: 2aefbef0414981 Matt Redfearn 2016-10-19 58 mutex_unlock(&rproc->lock); 2aefbef0414981 Matt Redfearn 2016-10-19 59 2aefbef0414981 Matt Redfearn 2016-10-19 60 return err ? err : count; 2aefbef0414981 Matt Redfearn 2016-10-19 61 } 2aefbef0414981 Matt Redfearn 2016-10-19 62 static DEVICE_ATTR_RW(firmware); 2aefbef0414981 Matt Redfearn 2016-10-19 63 :::::: The code at line 55 was first introduced by commit :::::: 2aefbef041498182ce1d186ed2300298b7a7101a remoteproc: Add a sysfs interface for firmware and state :::::: TO: Matt Redfearn <matt.redfearn at imgtec.com> :::::: CC: Bjorn...

...static const struct bin_attribute dpf_attrs_1 = { - .attr = {.name = "l3_parity_slice_1", .mode = (S_IRUSR | S_IWUSR)}, + .attr = {.name = "l3_parity_slice_1", .mode = 0600}, .size = GEN7_L3LOG_SIZE, .read = i915_l3_read, .write = i915_l3_write, @@ -460,9 +460,9 @@ static DEVICE_ATTR_RW(gt_min_freq_mhz); static DEVICE_ATTR_RO(vlv_rpe_freq_mhz); static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf); -static DEVICE_ATTR(gt_RP0_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL); -static DEVICE_ATTR(gt_RP1_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL); -sta...

...e dpf_attrs_1 = { > - .attr = {.name = "l3_parity_slice_1", .mode = (S_IRUSR | S_IWUSR)}, > + .attr = {.name = "l3_parity_slice_1", .mode = 0600}, > .size = GEN7_L3LOG_SIZE, > .read = i915_l3_read, > .write = i915_l3_write, > @@ -460,9 +460,9 @@ static DEVICE_ATTR_RW(gt_min_freq_mhz); > static DEVICE_ATTR_RO(vlv_rpe_freq_mhz); > > static ssize_t gt_rp_mhz_show(struct device *kdev, struct device_attribute *attr, char *buf); > -static DEVICE_ATTR(gt_RP0_freq_mhz, S_IRUGO, gt_rp_mhz_show, NULL); > -static DEVICE_ATTR(gt_RP1_freq_mhz, S_IRUGO,...

ChangeLog: ========= v2 => v3: a) Patch 1 data structure cleanups, header file include cleanups, IDA interface reuse and switching to device_create_with_groups(..) as per feedback from Greg Kroah-Hartman. b) Patch 7 signal documentation, sleep workaround removal and sysfs access API cleanups as per feedback from Michael S. Tsirkin. v1 => v2: @ http://lwn.net/Articles/563131/ a)

ChangeLog: ========= v2 => v3: a) Patch 1 data structure cleanups, header file include cleanups, IDA interface reuse and switching to device_create_with_groups(..) as per feedback from Greg Kroah-Hartman. b) Patch 7 signal documentation, sleep workaround removal and sysfs access API cleanups as per feedback from Michael S. Tsirkin. v1 => v2: @ http://lwn.net/Articles/563131/ a)